Re: [PATCH v12 01/14] unwind_user: Add user space unwinding API

[Mathieu Desnoyers <mathieu.desnoyers@efficios.com>]

On 2025-06-30 20:53, Steven Rostedt wrote:
> From: Josh Poimboeuf <jpoimboe@kernel.org>
> 
> Introduce a generic API for unwinding user stacks.
> 
> In order to expand user space unwinding to be able to handle more complex
> scenarios, such as deferred unwinding and reading user space information,
> create a generic interface that all architectures can use that support the
> various unwinding methods.
> 
> This is an alternative method for handling user space stack traces from
> the simple stack_trace_save_user() API. This does not replace that
> interface, but this interface will be used to expand the functionality of
> user space stack walking.
> 
> None of the structures introduced will be exposed to user space tooling.

Would it be possible to make those unwind APIs EXPORT_SYMBOL_GPL
so they are available for GPL kernel modules ?

Thanks,

Mathieu

> 
> Signed-off-by: Josh Poimboeuf <jpoimboe@kernel.org>
> Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
> ---
>   MAINTAINERS                       |  8 +++++
>   arch/Kconfig                      |  3 ++
>   include/linux/unwind_user.h       | 15 +++++++++
>   include/linux/unwind_user_types.h | 31 +++++++++++++++++
>   kernel/Makefile                   |  1 +
>   kernel/unwind/Makefile            |  1 +
>   kernel/unwind/user.c              | 55 +++++++++++++++++++++++++++++++
>   7 files changed, 114 insertions(+)
>   create mode 100644 include/linux/unwind_user.h
>   create mode 100644 include/linux/unwind_user_types.h
>   create mode 100644 kernel/unwind/Makefile
>   create mode 100644 kernel/unwind/user.c
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 4bac4ea21b64..ed5705c4f7d9 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -25924,6 +25924,14 @@ F:	Documentation/driver-api/uio-howto.rst
>   F:	drivers/uio/
>   F:	include/linux/uio_driver.h
>   
> +USERSPACE STACK UNWINDING
> +M:	Josh Poimboeuf <jpoimboe@kernel.org>
> +M:	Steven Rostedt <rostedt@goodmis.org>
> +S:	Maintained
> +F:	include/linux/unwind*.h
> +F:	kernel/unwind/
> +
> +
>   UTIL-LINUX PACKAGE
>   M:	Karel Zak <kzak@redhat.com>
>   L:	util-linux@vger.kernel.org
> diff --git a/arch/Kconfig b/arch/Kconfig
> index a3308a220f86..ea59e5d7cc69 100644
> --- a/arch/Kconfig
> +++ b/arch/Kconfig
> @@ -435,6 +435,9 @@ config HAVE_HARDLOCKUP_DETECTOR_ARCH
>   	  It uses the same command line parameters, and sysctl interface,
>   	  as the generic hardlockup detectors.
>   
> +config UNWIND_USER
> +	bool
> +
>   config HAVE_PERF_REGS
>   	bool
>   	help
> diff --git a/include/linux/unwind_user.h b/include/linux/unwind_user.h
> new file mode 100644
> index 000000000000..aa7923c1384f
> --- /dev/null
> +++ b/include/linux/unwind_user.h
> @@ -0,0 +1,15 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +#ifndef _LINUX_UNWIND_USER_H
> +#define _LINUX_UNWIND_USER_H
> +
> +#include <linux/unwind_user_types.h>
> +
> +int unwind_user_start(struct unwind_user_state *state);
> +int unwind_user_next(struct unwind_user_state *state);
> +
> +int unwind_user(struct unwind_stacktrace *trace, unsigned int max_entries);
> +
> +#define for_each_user_frame(state) \
> +	for (unwind_user_start((state)); !(state)->done; unwind_user_next((state)))
> +
> +#endif /* _LINUX_UNWIND_USER_H */

[...]


-- 
Mathieu Desnoyers
EfficiOS Inc.
https://www.efficios.com