From: "jiale yao" <19888972804@163.com>
To: "Herton Ronaldo Krzesinski" <herton@canonical.com>,
"Hans de Goede" <hansg@kernel.org>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re:[PATCH v3 2/3] platform/x86: topstar-laptop: Check ACPI_COMPANION() against NULL
Date: Sat, 17 Oct 2026 15:42:57 +0800 (CST) [thread overview]
Message-ID: <12cb3ffb.191b.1a148d05e4a.Coremail.19888972804@163.com> (raw)
In-Reply-To: <20261017064350.3817228-1-yaojiale02@163.com>
At 2026-10-17 14:43:50, "Jiale Yao" <yaojiale02@163.com> wrote:
>Add a requisite ACPI_COMPANION() check against NULL to the
>topstar-laptop driver, aligning with the fix applied to
>asus-wireless driver.
>
Fixes: 3471415c8186 ("platform/x86: topstar-laptop: Convert ACPI driver to a platform one")
>Assisted-by: claude:deepseek-v4-pro
>Signed-off-by: Jiale Yao <yaojiale02@163.com>
>---
> drivers/platform/x86/topstar-laptop.c | 3 +++
> 1 file changed, 3 insertions(+)
>
>diff --git a/drivers/platform/x86/topstar-laptop.c b/drivers/platform/x86/topstar-laptop.c
>index e09d7f8ce45f..f6fafa345f93 100644
>--- a/drivers/platform/x86/topstar-laptop.c
>+++ b/drivers/platform/x86/topstar-laptop.c
>@@ -291,6 +291,9 @@ static int topstar_acpi_probe(struct platform_device *pdev)
> struct topstar_laptop *topstar;
> int err;
>
>+ if (!device)
>+ return -ENODEV;
>+
> dmi_check_system(topstar_dmi_ids);
>
> topstar = kzalloc_obj(struct topstar_laptop);
>--
>2.34.1
next prev parent reply other threads:[~2026-10-17 7:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-17 6:43 [PATCH " Jiale Yao
2026-10-17 7:42 ` jiale yao [this message]
2026-10-19 6:09 ` Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12cb3ffb.191b.1a148d05e4a.Coremail.19888972804@163.com \
--to=19888972804@163.com \
--cc=hansg@kernel.org \
--cc=herton@canonical.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®