mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Jiale Yao <yaojiale02@163.com>
Cc: Herton Ronaldo Krzesinski <herton@canonical.com>,
	 Hans de Goede <hansg@kernel.org>,
	platform-driver-x86@vger.kernel.org,
	 LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 2/3] platform/x86: topstar-laptop: Check ACPI_COMPANION() against NULL
Date: Mon, 19 Oct 2026 09:09:30 +0300 (EEST)	[thread overview]
Message-ID: <e3b27eae-df1e-4687-aa61-fd7a476ab477@linux.intel.com> (raw)
In-Reply-To: <20261017064350.3817228-1-yaojiale02@163.com>

On Sat, 17 Oct 2026, Jiale Yao wrote:

> Add a requisite ACPI_COMPANION() check against NULL to the
> topstar-laptop driver, aligning with the fix applied to
> asus-wireless driver.
> 
> Assisted-by: claude:deepseek-v4-pro
> Signed-off-by: Jiale Yao <yaojiale02@163.com>
> ---
>  drivers/platform/x86/topstar-laptop.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/platform/x86/topstar-laptop.c b/drivers/platform/x86/topstar-laptop.c
> index e09d7f8ce45f..f6fafa345f93 100644
> --- a/drivers/platform/x86/topstar-laptop.c
> +++ b/drivers/platform/x86/topstar-laptop.c
> @@ -291,6 +291,9 @@ static int topstar_acpi_probe(struct platform_device *pdev)
>  	struct topstar_laptop *topstar;
>  	int err;
>  
> +	if (!device)

Call and it's error handling should kept together.

> +		return -ENODEV;
> +
>  	dmi_check_system(topstar_dmi_ids);
>  
>  	topstar = kzalloc_obj(struct topstar_laptop);
> 

-- 
 i.


  parent reply	other threads:[~2026-10-19  6:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-17  6:43 Jiale Yao
2026-10-17  7:42 ` jiale yao
2026-10-19  6:09 ` Ilpo Järvinen [this message]
  -- strict thread matches above, loose matches on Subject: below --
2026-07-13 15:14 [PATCH v3 1/3] platform/x86: asus-wireless: " Jiale Yao
2026-07-13 15:14 ` [PATCH v3 2/3] platform/x86: topstar-laptop: " Jiale Yao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e3b27eae-df1e-4687-aa61-fd7a476ab477@linux.intel.com \
    --to=ilpo.jarvinen@linux.intel.com \
    --cc=hansg@kernel.org \
    --cc=herton@canonical.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=yaojiale02@163.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®