From: David Daney <ddaney@caviumnetworks.com>
To: linux-serial@vger.kernel.org, gregkh@suse.de,
linux-kernel@vger.kernel.org,
devicetree-discuss@lists.ozlabs.org, grant.likely@secretlab.ca
Cc: David Daney <ddaney@caviumnetworks.com>
Subject: [RFC PATCH 0/2] serial: Hack up 8520.c for evil device tree hookin.
Date: Wed, 16 Mar 2011 18:26:05 -0700 [thread overview]
Message-ID: <1300325167-26433-1-git-send-email-ddaney@caviumnetworks.com> (raw)
I wanted to get some feedback on my attempts to control my serial
device registration with device tree data.
It was suggested by Grant Likely that I could use of_serial.c for my
purposes. However I think it is simpler to do my own registration
code, because I need to set my own device type, required port flags,
and I/O functions, instead of using general purpose ones. Adding this
to of_serial.c would be quite ugly, so I would like to keep it with my
chip/board code.
This leads to a problem: You cannot call serial8250_register_port()
until the 8250.c driver is registered. of_serial.c is lucky that it
comes after 8250.c in the make file so that the device initcall order
is correct. When I put the code in my board's serial.c file, I am not
so lucky. To get the initialization order correct, I add a notifier
chain to 8250.c
What say you all to this approach?
David Daney (2):
serial: 8250: Add a notifier chain for driver registration.
MIPS: Octeon: Use device tree to register serial ports.
arch/mips/cavium-octeon/serial.c | 140 ++++++++++++++++----------------------
drivers/tty/serial/8250.c | 20 ++++++
include/linux/serial_8250.h | 21 ++++++
3 files changed, 101 insertions(+), 80 deletions(-)
--
1.7.2.3
next reply other threads:[~2011-03-17 1:27 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-17 1:26 David Daney [this message]
2011-03-17 1:26 ` [RFC PATCH 1/2] serial: 8250: Add a notifier chain for driver registration David Daney
2011-03-17 12:18 ` Alan Cox
2011-03-17 16:42 ` David Daney
2011-03-17 18:25 ` Grant Likely
2011-03-17 18:42 ` David Daney
2011-03-17 18:47 ` Grant Likely
2011-03-17 19:24 ` Alan Cox
2011-03-17 19:31 ` Grant Likely
2011-03-17 20:13 ` David Daney
2011-03-17 20:31 ` Grant Likely
2011-03-17 23:48 ` Alan Cox
2011-03-18 5:18 ` Grant Likely
2011-03-17 1:26 ` [RFC PATCH 2/2] MIPS: Octeon: Use device tree to register serial ports David Daney
2011-03-17 18:28 ` Grant Likely
2011-03-17 18:35 ` David Daney
2011-03-17 1:46 ` [RFC PATCH 0/2] serial: Hack up 8520.c for evil device tree hookin Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1300325167-26433-1-git-send-email-ddaney@caviumnetworks.com \
--to=ddaney@caviumnetworks.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®