mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: David Daney <ddaney@caviumnetworks.com>,
	linux-serial@vger.kernel.org, gregkh@suse.de,
	linux-kernel@vger.kernel.org,
	devicetree-discuss@lists.ozlabs.org
Subject: Re: [RFC PATCH 1/2] serial: 8250: Add a notifier chain for driver registration.
Date: Thu, 17 Mar 2011 19:24:41 +0000	[thread overview]
Message-ID: <20110317192441.69c699b1@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <20110317184723.GQ9597@angua.secretlab.ca>

> > If we did that, serial8250_probe() would automatically do the right thing.
> 
> Take a look at the way arch/powerpc/platforms/512x/pdm360ng.c uses a
> notifier for amending a platform_device with additional data..

I tend to view arch specific embedded code as rather like very dubious
parties. What goes on in other peoples' house out of sight is none of my
business.

The 8250 however is core code so it should keep its clothers on and behave
in a manner befitting its status.

What part of the problem can't be solved by doing it properly using the
device registration interfaces we have today ?

Alan

  reply	other threads:[~2011-03-17 19:24 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-17  1:26 [RFC PATCH 0/2] serial: Hack up 8520.c for evil device tree hookin David Daney
2011-03-17  1:26 ` [RFC PATCH 1/2] serial: 8250: Add a notifier chain for driver registration David Daney
2011-03-17 12:18   ` Alan Cox
2011-03-17 16:42     ` David Daney
2011-03-17 18:25     ` Grant Likely
2011-03-17 18:42       ` David Daney
2011-03-17 18:47         ` Grant Likely
2011-03-17 19:24           ` Alan Cox [this message]
2011-03-17 19:31             ` Grant Likely
2011-03-17 20:13               ` David Daney
2011-03-17 20:31                 ` Grant Likely
2011-03-17 23:48               ` Alan Cox
2011-03-18  5:18                 ` Grant Likely
2011-03-17  1:26 ` [RFC PATCH 2/2] MIPS: Octeon: Use device tree to register serial ports David Daney
2011-03-17 18:28   ` Grant Likely
2011-03-17 18:35     ` David Daney
2011-03-17  1:46 ` [RFC PATCH 0/2] serial: Hack up 8520.c for evil device tree hookin Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110317192441.69c699b1@lxorguk.ukuu.org.uk \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=ddaney@caviumnetworks.com \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=grant.likely@secretlab.ca \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®