* [PATCH 1/3] drivers/mmc/host/mvsdio.c: Convert release_resource to release_mem_region
@ 2011-03-22 17:14 Julia Lawall
2011-03-22 19:04 ` Nicolas Pitre
0 siblings, 1 reply; 2+ messages in thread
From: Julia Lawall @ 2011-03-22 17:14 UTC (permalink / raw)
To: Nicolas Pitre
Cc: kernel-janitors, Chris Ball, Andrew Morton, Michal Miroslaw,
Anton Vorontsov, Martin K. Petersen, Sascha Sommer, linux-mmc,
linux-kernel
Request_mem_region should be used with release_mem_region, not
release_resource.
A semantic patch that partially fixes this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@b@
expression x,E;
@@
x = request_mem_region(x->start,...)
... when != release_mem_region(x->start,...)
when != x = E
(
- release_resource(x);
- kfree(x);
+ release_mem_region(x->start,resource_size(x));
|
?- release_resource(x);
+ release_mem_region(x->start,resource_size(x));
)
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
---
drivers/mmc/host/mvsdio.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mmc/host/mvsdio.c b/drivers/mmc/host/mvsdio.c
index a5bf60e..4606087 100644
--- a/drivers/mmc/host/mvsdio.c
+++ b/drivers/mmc/host/mvsdio.c
@@ -825,7 +825,7 @@ out:
iounmap(host->base);
}
if (r)
- release_resource(r);
+ release_mem_region(r->start, resource_size(r));
if (mmc)
mmc_free_host(mmc);
@@ -850,7 +850,7 @@ static int __exit mvsd_remove(struct platform_device *pdev)
del_timer_sync(&host->timer);
mvsd_power_down(host);
iounmap(host->base);
- release_resource(host->res);
+ release_mem_region(host->res->start, resource_size(host->res));
mmc_free_host(mmc);
}
platform_set_drvdata(pdev, NULL);
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH 1/3] drivers/mmc/host/mvsdio.c: Convert release_resource to release_mem_region
2011-03-22 17:14 [PATCH 1/3] drivers/mmc/host/mvsdio.c: Convert release_resource to release_mem_region Julia Lawall
@ 2011-03-22 19:04 ` Nicolas Pitre
0 siblings, 0 replies; 2+ messages in thread
From: Nicolas Pitre @ 2011-03-22 19:04 UTC (permalink / raw)
To: Julia Lawall
Cc: kernel-janitors, Chris Ball, Andrew Morton, Michal Miroslaw,
Anton Vorontsov, Martin K. Petersen, Sascha Sommer, linux-mmc,
lkml
On Tue, 22 Mar 2011, Julia Lawall wrote:
> Request_mem_region should be used with release_mem_region, not
> release_resource.
>
> A semantic patch that partially fixes this problem is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @b@
> expression x,E;
> @@
>
> x = request_mem_region(x->start,...)
> ... when != release_mem_region(x->start,...)
> when != x = E
> (
> - release_resource(x);
> - kfree(x);
> + release_mem_region(x->start,resource_size(x));
> |
> ?- release_resource(x);
> + release_mem_region(x->start,resource_size(x));
> )
> // </smpl>
>
> Signed-off-by: Julia Lawall <julia@diku.dk>
Acked-by: Nicolas Pitre <nico@fluxnic.net>
> ---
> drivers/mmc/host/mvsdio.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/mvsdio.c b/drivers/mmc/host/mvsdio.c
> index a5bf60e..4606087 100644
> --- a/drivers/mmc/host/mvsdio.c
> +++ b/drivers/mmc/host/mvsdio.c
> @@ -825,7 +825,7 @@ out:
> iounmap(host->base);
> }
> if (r)
> - release_resource(r);
> + release_mem_region(r->start, resource_size(r));
> if (mmc)
> mmc_free_host(mmc);
>
> @@ -850,7 +850,7 @@ static int __exit mvsd_remove(struct platform_device *pdev)
> del_timer_sync(&host->timer);
> mvsd_power_down(host);
> iounmap(host->base);
> - release_resource(host->res);
> + release_mem_region(host->res->start, resource_size(host->res));
> mmc_free_host(mmc);
> }
> platform_set_drvdata(pdev, NULL);
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-03-22 19:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-03-22 17:14 [PATCH 1/3] drivers/mmc/host/mvsdio.c: Convert release_resource to release_mem_region Julia Lawall
2011-03-22 19:04 ` Nicolas Pitre
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®