From: Jiri Slaby <jslaby@suse.cz>
To: jirislaby@gmail.com
Cc: linux-kernel@vger.kernel.org, Jiri Slaby <jslaby@suse.cz>,
Greg Kroah-Hartman <gregkh@suse.de>
Subject: [PATCH 3/7] Char: cyclades, fix unused variable
Date: Wed, 23 Mar 2011 09:49:56 +0100 [thread overview]
Message-ID: <1300870200-24405-3-git-send-email-jslaby@suse.cz> (raw)
In-Reply-To: <1300870200-24405-1-git-send-email-jslaby@suse.cz>
drivers/tty/cyclades.c:1454:2: warning: Value stored to 'channel' is never read
channel = info->line - card->first_line;
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Fix it by moving it to the appropriate debug section where it is used.
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Cc: Greg Kroah-Hartman <gregkh@suse.de>
---
drivers/tty/cyclades.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers/tty/cyclades.c b/drivers/tty/cyclades.c
index c99728f..e6f20d2 100644
--- a/drivers/tty/cyclades.c
+++ b/drivers/tty/cyclades.c
@@ -1445,13 +1445,11 @@ static void cy_shutdown(struct cyclades_port *info, struct tty_struct *tty)
{
struct cyclades_card *card;
unsigned long flags;
- int channel;
if (!(info->port.flags & ASYNC_INITIALIZED))
return;
card = info->card;
- channel = info->line - card->first_line;
if (!cy_is_Z(card)) {
spin_lock_irqsave(&card->card_lock, flags);
@@ -1476,6 +1474,7 @@ static void cy_shutdown(struct cyclades_port *info, struct tty_struct *tty)
spin_unlock_irqrestore(&card->card_lock, flags);
} else {
#ifdef CY_DEBUG_OPEN
+ int channel = info->line - card->first_line;
printk(KERN_DEBUG "cyc shutdown Z card %d, channel %d, "
"base_addr %p\n", card, channel, card->base_addr);
#endif
--
1.7.4.1
next prev parent reply other threads:[~2011-03-23 8:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-23 8:49 [PATCH 1/7] tty: VT, remove " Jiri Slaby
2011-03-23 8:49 ` [PATCH 2/7] TTY: serial_core, " Jiri Slaby
2011-03-23 9:15 ` Govindraj
2011-03-23 8:49 ` Jiri Slaby [this message]
2011-03-23 8:49 ` [PATCH 4/7] TTY: VT, remove unused variables Jiri Slaby
2011-03-23 8:49 ` [PATCH 5/7] I2C: eg20t, remove unused variable Jiri Slaby
2011-03-23 10:09 ` Jean Delvare
2011-03-23 10:50 ` Tomoya MORINAGA
2011-04-19 15:06 ` Jiri Slaby
2011-04-20 0:04 ` Tomoya MORINAGA
2011-03-23 8:49 ` [PATCH 6/7] Char: moxa, remove unused variables Jiri Slaby
2011-03-23 8:50 ` [PATCH 7/7] TTY: rocket, " Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1300870200-24405-3-git-send-email-jslaby@suse.cz \
--to=jslaby@suse.cz \
--cc=gregkh@suse.de \
--cc=jirislaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®