From: Jiri Slaby <jslaby@suse.cz>
To: jirislaby@gmail.com
Cc: linux-kernel@vger.kernel.org, Jiri Slaby <jslaby@suse.cz>,
Jean Delvare <khali@linux-fr.org>,
linux-i2c@vger.kernel.org
Subject: [PATCH 5/7] I2C: eg20t, remove unused variable
Date: Wed, 23 Mar 2011 09:49:58 +0100 [thread overview]
Message-ID: <1300870200-24405-5-git-send-email-jslaby@suse.cz> (raw)
In-Reply-To: <1300870200-24405-1-git-send-email-jslaby@suse.cz>
drivers/i2c/busses/i2c-eg20t.c:684:2: warning: Value stored to 'msglen' is never read
msglen = (pmsg->len) - (subaddrlen + 1);
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Cc: Jean Delvare <khali@linux-fr.org>
Cc: linux-i2c@vger.kernel.org
---
drivers/i2c/busses/i2c-eg20t.c | 8 --------
1 files changed, 0 insertions(+), 8 deletions(-)
diff --git a/drivers/i2c/busses/i2c-eg20t.c b/drivers/i2c/busses/i2c-eg20t.c
index 878a120..ea73252 100644
--- a/drivers/i2c/busses/i2c-eg20t.c
+++ b/drivers/i2c/busses/i2c-eg20t.c
@@ -651,8 +651,6 @@ static s32 pch_i2c_xfer(struct i2c_adapter *i2c_adap,
struct i2c_msg *pmsg;
u32 i = 0;
u32 status;
- u32 msglen;
- u32 subaddrlen;
s32 ret;
struct i2c_algo_pch_data *adap = i2c_adap->algo_data;
@@ -676,12 +674,6 @@ static s32 pch_i2c_xfer(struct i2c_adapter *i2c_adap,
status = pmsg->flags;
pch_dbg(adap,
"After invoking I2C_MODE_SEL :flag= 0x%x\n", status);
- /* calculate sub address length and message length */
- /* these are applicable only for buffer mode */
- subaddrlen = pmsg->buf[0];
- /* calculate actual message length excluding
- * the sub address fields */
- msglen = (pmsg->len) - (subaddrlen + 1);
if (status & (I2C_M_RD)) {
pch_dbg(adap, "invoking pch_i2c_readbytes\n");
ret = pch_i2c_readbytes(i2c_adap, pmsg, (i + 1 == num),
--
1.7.4.1
next prev parent reply other threads:[~2011-03-23 8:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-23 8:49 [PATCH 1/7] tty: VT, " Jiri Slaby
2011-03-23 8:49 ` [PATCH 2/7] TTY: serial_core, " Jiri Slaby
2011-03-23 9:15 ` Govindraj
2011-03-23 8:49 ` [PATCH 3/7] Char: cyclades, fix " Jiri Slaby
2011-03-23 8:49 ` [PATCH 4/7] TTY: VT, remove unused variables Jiri Slaby
2011-03-23 8:49 ` Jiri Slaby [this message]
2011-03-23 10:09 ` [PATCH 5/7] I2C: eg20t, remove unused variable Jean Delvare
2011-03-23 10:50 ` Tomoya MORINAGA
2011-04-19 15:06 ` Jiri Slaby
2011-04-20 0:04 ` Tomoya MORINAGA
2011-03-23 8:49 ` [PATCH 6/7] Char: moxa, remove unused variables Jiri Slaby
2011-03-23 8:50 ` [PATCH 7/7] TTY: rocket, " Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1300870200-24405-5-git-send-email-jslaby@suse.cz \
--to=jslaby@suse.cz \
--cc=jirislaby@gmail.com \
--cc=khali@linux-fr.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®