mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] mfd: Select MFD_CORE if TPS6105X driver is configured
@ 2011-03-24 19:12 Guenter Roeck
  2011-03-24 22:03 ` Linus Walleij
  0 siblings, 1 reply; 2+ messages in thread
From: Guenter Roeck @ 2011-03-24 19:12 UTC (permalink / raw)
  To: Samuel Ortiz; +Cc: linux-kernel, Guenter Roeck

The TPS61050/61052 driver uses MFD core code, yet does not specify the
dependency in Kconfig. If it is the only MFD driver configured, compilation
fails with

ERROR: "mfd_add_devices" [drivers/mfd/tps6105x.ko] undefined!
ERROR: "mfd_remove_devices" [drivers/mfd/tps6105x.ko] undefined!

Fix the problem by adding "select MFD_CORE" to the respective Kconfig entry.

Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com>
---
 drivers/mfd/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index a9a1af4..e986f91 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -133,6 +133,7 @@ config TPS6105X
 	tristate "TPS61050/61052 Boost Converters"
 	depends on I2C
 	select REGULATOR
+	select MFD_CORE
 	select REGULATOR_FIXED_VOLTAGE
 	help
 	  This option enables a driver for the TP61050/TPS61052
-- 
1.7.3.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] mfd: Select MFD_CORE if TPS6105X driver is configured
  2011-03-24 19:12 [PATCH] mfd: Select MFD_CORE if TPS6105X driver is configured Guenter Roeck
@ 2011-03-24 22:03 ` Linus Walleij
  0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2011-03-24 22:03 UTC (permalink / raw)
  To: Guenter Roeck; +Cc: Samuel Ortiz, linux-kernel

On Thu, Mar 24, 2011 at 8:12 PM, Guenter Roeck
<guenter.roeck@ericsson.com> wrote:

> The TPS61050/61052 driver uses MFD core code, yet does not specify the
> dependency in Kconfig. If it is the only MFD driver configured, compilation
> fails with
>
> ERROR: "mfd_add_devices" [drivers/mfd/tps6105x.ko] undefined!
> ERROR: "mfd_remove_devices" [drivers/mfd/tps6105x.ko] undefined!
>
> Fix the problem by adding "select MFD_CORE" to the respective Kconfig entry.
>
> Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com>

Acked-by: Linus Walleij <linus.walleij@linaro.org>

Thanks Günter,
Linus Walleij

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-03-24 22:03 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-03-24 19:12 [PATCH] mfd: Select MFD_CORE if TPS6105X driver is configured Guenter Roeck
2011-03-24 22:03 ` Linus Walleij

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®