From: David Daney <ddaney@caviumnetworks.com>
To: tglx@linutronix.de, linux-mips@linux-mips.org, ralf@linux-mips.org
Cc: linux-kernel@vger.kernel.org, David Daney <ddaney@caviumnetworks.com>
Subject: [PATCH v3 1/4] genirq: Reserve the irq when calling irq_set_chip()
Date: Fri, 25 Mar 2011 12:38:48 -0700 [thread overview]
Message-ID: <1301081931-11240-2-git-send-email-ddaney@caviumnetworks.com> (raw)
In-Reply-To: <1301081931-11240-1-git-send-email-ddaney@caviumnetworks.com>
The helper macros and functions like for_each_active_irq() don't work
unless the irq is in the allocated_irqs set.
In the case of !CONFIG_SPARSE_IRQ, instead of forcing all users of the
irq infrastructure to explicitly call irq_reserve_irq(), do it for
them.
Signed-off-by: David Daney <ddaney@caviumnetworks.com>
---
kernel/irq/chip.c | 6 ++++++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c
index c9c0601..54d9aab 100644
--- a/kernel/irq/chip.c
+++ b/kernel/irq/chip.c
@@ -37,6 +37,12 @@ int irq_set_chip(unsigned int irq, struct irq_chip *chip)
irq_chip_set_defaults(chip);
desc->irq_data.chip = chip;
irq_put_desc_unlock(desc, flags);
+ /*
+ * For !CONFIG_SPARSE_IRQ make the irq show up in
+ * allocated_irqs. For the CONFIG_SPARSE_IRQ case, it may
+ * already be there, and this call is harmless.
+ */
+ irq_reserve_irq(irq);
return 0;
}
EXPORT_SYMBOL(irq_set_chip);
--
1.7.2.3
next prev parent reply other threads:[~2011-03-25 19:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-25 19:38 [PATCH v3 0/4] Add IRQ chip hooks for taking CPUs on/off line David Daney
2011-03-25 19:38 ` David Daney [this message]
2011-03-25 22:30 ` [PATCH v3 1/4] genirq: Reserve the irq when calling irq_set_chip() Thomas Gleixner
2011-03-27 16:18 ` [tip:irq/urgent] " tip-bot for David Daney
2011-03-25 19:38 ` [PATCH v3 2/4] genirq: Add chip hooks for taking CPUs on/off line David Daney
2011-03-27 16:19 ` [tip:irq/urgent] " tip-bot for David Daney
2011-03-25 19:38 ` [PATCH v3 3/4] genirq: Split irq_set_affinity() so it can be called with lock held David Daney
2011-03-25 22:32 ` Thomas Gleixner
2011-03-27 16:20 ` [tip:irq/urgent] " tip-bot for David Daney
2011-03-25 19:38 ` [PATCH v3 4/4] MIPS: Octeon: Rewrite interrupt handling code David Daney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1301081931-11240-2-git-send-email-ddaney@caviumnetworks.com \
--to=ddaney@caviumnetworks.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®