mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: tip-bot for David Daney <ddaney@caviumnetworks.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@redhat.com,
	ddaney@caviumnetworks.com, tglx@linutronix.de
Subject: [tip:irq/urgent] genirq: Reserve the irq when calling irq_set_chip()
Date: Sun, 27 Mar 2011 16:18:56 GMT	[thread overview]
Message-ID: <tip-d72274e5895d11570a0a4a3214a1933c86d5ccb7@git.kernel.org> (raw)
In-Reply-To: <1301081931-11240-2-git-send-email-ddaney@caviumnetworks.com>

Commit-ID:  d72274e5895d11570a0a4a3214a1933c86d5ccb7
Gitweb:     http://git.kernel.org/tip/d72274e5895d11570a0a4a3214a1933c86d5ccb7
Author:     David Daney <ddaney@caviumnetworks.com>
AuthorDate: Fri, 25 Mar 2011 12:38:48 -0700
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Sun, 27 Mar 2011 17:45:58 +0200

genirq: Reserve the irq when calling irq_set_chip()

The helper macros and functions like for_each_active_irq() don't work
unless the irq is in the allocated_irqs set.

In the case of !CONFIG_SPARSE_IRQ, instead of forcing all users of the
irq infrastructure to explicitly call irq_reserve_irq(), do it for
them.

Signed-off-by: David Daney <ddaney@caviumnetworks.com>
Cc: linux-mips@linux-mips.org
Cc: ralf@linux-mips.org
LKML-Reference: <1301081931-11240-2-git-send-email-ddaney@caviumnetworks.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
 kernel/irq/chip.c |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c
index c9c0601..c35d74c 100644
--- a/kernel/irq/chip.c
+++ b/kernel/irq/chip.c
@@ -37,6 +37,12 @@ int irq_set_chip(unsigned int irq, struct irq_chip *chip)
 	irq_chip_set_defaults(chip);
 	desc->irq_data.chip = chip;
 	irq_put_desc_unlock(desc, flags);
+	/*
+	 * For !CONFIG_SPARSE_IRQ make the irq show up in
+	 * allocated_irqs. For the CONFIG_SPARSE_IRQ case, it is
+	 * already marked, and this call is harmless.
+	 */
+	irq_reserve_irq(irq);
 	return 0;
 }
 EXPORT_SYMBOL(irq_set_chip);

  parent reply	other threads:[~2011-03-27 16:19 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-25 19:38 [PATCH v3 0/4] Add IRQ chip hooks for taking CPUs on/off line David Daney
2011-03-25 19:38 ` [PATCH v3 1/4] genirq: Reserve the irq when calling irq_set_chip() David Daney
2011-03-25 22:30   ` Thomas Gleixner
2011-03-27 16:18   ` tip-bot for David Daney [this message]
2011-03-25 19:38 ` [PATCH v3 2/4] genirq: Add chip hooks for taking CPUs on/off line David Daney
2011-03-27 16:19   ` [tip:irq/urgent] " tip-bot for David Daney
2011-03-25 19:38 ` [PATCH v3 3/4] genirq: Split irq_set_affinity() so it can be called with lock held David Daney
2011-03-25 22:32   ` Thomas Gleixner
2011-03-27 16:20   ` [tip:irq/urgent] " tip-bot for David Daney
2011-03-25 19:38 ` [PATCH v3 4/4] MIPS: Octeon: Rewrite interrupt handling code David Daney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-d72274e5895d11570a0a4a3214a1933c86d5ccb7@git.kernel.org \
    --to=ddaney@caviumnetworks.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®