From: Joe Perches <joe@perches.com>
To: Ian Romanick <idr@freedesktop.org>
Cc: David Airlie <airlied@linux.ie>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm: Create and use drm_err
Date: Mon, 18 Apr 2011 16:05:39 -0700 [thread overview]
Message-ID: <1303167939.31723.47.camel@Joe-Laptop> (raw)
In-Reply-To: <4DACC1B1.8090808@freedesktop.org>
On Mon, 2011-04-18 at 15:56 -0700, Ian Romanick wrote:
> I believe that DRM_NAME is a define, and drm_stub.c is in common code.
> As a result, won't this change cause something different to get logged?
Nope. DRM_NAME is #defined only once.
include/drm/drm.h:#define DRM_NAME "drm"
The only real reason to do this is the "*ERROR*"
used in:
> > -#define DRM_ERROR(fmt, arg...) \
> > - printk(KERN_ERR "[" DRM_NAME ":%s] *ERROR* " fmt , __func__ , ##arg)
It'd be more or less similar to use:
#define DRM_ERROR(fmt, ...) \
pr_err("%s: " fmt, __func__, ##__VA_ARGS__)
or just convert DRM_ERROR to pr_err and DRM_INFO to pr_info.
next prev parent reply other threads:[~2011-04-18 23:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-18 3:35 [PATCH 0/2] drm: Message logging cleanups Joe Perches
2011-04-18 3:35 ` [PATCH 1/2] drm: Create and use drm_err Joe Perches
2011-04-18 22:56 ` Ian Romanick
2011-04-18 23:00 ` Dave Airlie
2011-04-18 23:05 ` Joe Perches [this message]
2011-04-18 3:35 ` [PATCH 2/2] drm: Verify debug message arguments Joe Perches
2011-04-18 23:01 ` Ian Romanick
2011-04-18 23:09 ` Joe Perches
2011-04-19 16:26 ` Marcin Slusarz
2011-04-19 16:31 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1303167939.31723.47.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=idr@freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®