From: Joe Perches <joe@perches.com>
To: Marcin Slusarz <marcin.slusarz@gmail.com>
Cc: Ian Romanick <idr@freedesktop.org>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 2/2] drm: Verify debug message arguments
Date: Tue, 19 Apr 2011 09:31:43 -0700 [thread overview]
Message-ID: <1303230703.31723.73.camel@Joe-Laptop> (raw)
In-Reply-To: <20110419162604.GA2861@joi.lan>
On Tue, 2011-04-19 at 18:26 +0200, Marcin Slusarz wrote:
> On Mon, Apr 18, 2011 at 04:09:11PM -0700, Joe Perches wrote:
> > On Mon, 2011-04-18 at 16:01 -0700, Ian Romanick wrote:
> > > > - DRM_DEBUG_KMS("LVDS downclock is found in VBT. ",
> > > > - "Normal Clock %dKHz, downclock %dKHz\n",
> > > > - temp_downclock, panel_fixed_mode->clock);
> > > > + DRM_DEBUG_KMS("LVDS downclock is found in VBT. "
> > > > + "Normal Clock %dKHz, downclock %dKHz\n",
> > > > + temp_downclock, panel_fixed_mode->clock);
> > > Does this hunk only change white space, or am I missing something?
> > No, you're right. It's just whitespace.
> > I prefer arguments aligned to open paren.
> It's not just whitespace. Look at the end of first line.
Heh. Thanks Marcin.
Teach me to just at the code in the patch.
It's a format error as the first quoted string has
a comma at the end so the arguments after the comma
were ignored.
prev parent reply other threads:[~2011-04-19 16:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-18 3:35 [PATCH 0/2] drm: Message logging cleanups Joe Perches
2011-04-18 3:35 ` [PATCH 1/2] drm: Create and use drm_err Joe Perches
2011-04-18 22:56 ` Ian Romanick
2011-04-18 23:00 ` Dave Airlie
2011-04-18 23:05 ` Joe Perches
2011-04-18 3:35 ` [PATCH 2/2] drm: Verify debug message arguments Joe Perches
2011-04-18 23:01 ` Ian Romanick
2011-04-18 23:09 ` Joe Perches
2011-04-19 16:26 ` Marcin Slusarz
2011-04-19 16:31 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1303230703.31723.73.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=idr@freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcin.slusarz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®