mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] mptsas: Fix annoying warning
@ 2011-05-02 14:49 Borislav Petkov
  2011-05-04 11:40 ` Desai, Kashyap
  0 siblings, 1 reply; 2+ messages in thread
From: Borislav Petkov @ 2011-05-02 14:49 UTC (permalink / raw)
  To: Eric Moore
  Cc: Borislav Petkov, support, DL-MPTFusionLinux, linux-scsi, linux-kernel

From: Borislav Petkov <borislav.petkov@amd.com>

Shut up

drivers/message/fusion/mptsas.c: In function 'mptsas_event_process':
drivers/message/fusion/mptsas.c:5015: warning: unused variable 'log_info'

for configs with CONFIG_SCSI_MPT2SAS_LOGGING unset.

Signed-off-by: Borislav Petkov <borislav.petkov@amd.com>
---
 drivers/message/fusion/mptsas.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/message/fusion/mptsas.c b/drivers/message/fusion/mptsas.c
index 66f9412..7596aec 100644
--- a/drivers/message/fusion/mptsas.c
+++ b/drivers/message/fusion/mptsas.c
@@ -5012,7 +5012,6 @@ mptsas_event_process(MPT_ADAPTER *ioc, EventNotificationReply_t *reply)
 			(ioc_stat & MPI_IOCSTATUS_FLAG_LOG_INFO_AVAILABLE)) {
 			VirtTarget *vtarget = NULL;
 			u8		id, channel;
-			u32	 log_info = le32_to_cpu(reply->IOCLogInfo);
 
 			id = sas_event_data->TargetID;
 			channel = sas_event_data->Bus;
@@ -5023,7 +5022,8 @@ mptsas_event_process(MPT_ADAPTER *ioc, EventNotificationReply_t *reply)
 				    "LogInfo (0x%x) available for "
 				   "INTERNAL_DEVICE_RESET"
 				   "fw_id %d fw_channel %d\n", ioc->name,
-				   log_info, id, channel));
+				   le32_to_cpu(reply->IOCLogInfo),
+				   id, channel));
 				if (vtarget->raidVolume) {
 					devtprintk(ioc, printk(MYIOC_s_DEBUG_FMT
 					"Skipping Raid Volume for inDMD\n",
-- 
1.7.4.rc2


^ permalink raw reply	[flat|nested] 2+ messages in thread

* RE: [PATCH] mptsas: Fix annoying warning
  2011-05-02 14:49 [PATCH] mptsas: Fix annoying warning Borislav Petkov
@ 2011-05-04 11:40 ` Desai, Kashyap
  0 siblings, 0 replies; 2+ messages in thread
From: Desai, Kashyap @ 2011-05-04 11:40 UTC (permalink / raw)
  To: Borislav Petkov, Moore, Eric
  Cc: Borislav Petkov, Support, DL-MPT Fusion Linux, linux-scsi,
	linux-kernel, James.Bottomley

Please consider this patch as an ACKed.

~ Kashyap

> -----Original Message-----
> From: Borislav Petkov [mailto:bp@amd64.org]
> Sent: Monday, May 02, 2011 8:20 PM
> To: Moore, Eric
> Cc: Borislav Petkov; Support; DL-MPT Fusion Linux; linux-
> scsi@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: [PATCH] mptsas: Fix annoying warning
> 
> From: Borislav Petkov <borislav.petkov@amd.com>
> 
> Shut up
> 
> drivers/message/fusion/mptsas.c: In function 'mptsas_event_process':
> drivers/message/fusion/mptsas.c:5015: warning: unused variable
> 'log_info'
> 
> for configs with CONFIG_SCSI_MPT2SAS_LOGGING unset.
> 
> Signed-off-by: Borislav Petkov <borislav.petkov@amd.com>
> ---
>  drivers/message/fusion/mptsas.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/message/fusion/mptsas.c
> b/drivers/message/fusion/mptsas.c
> index 66f9412..7596aec 100644
> --- a/drivers/message/fusion/mptsas.c
> +++ b/drivers/message/fusion/mptsas.c
> @@ -5012,7 +5012,6 @@ mptsas_event_process(MPT_ADAPTER *ioc,
> EventNotificationReply_t *reply)
>  			(ioc_stat & MPI_IOCSTATUS_FLAG_LOG_INFO_AVAILABLE)) {
>  			VirtTarget *vtarget = NULL;
>  			u8		id, channel;
> -			u32	 log_info = le32_to_cpu(reply->IOCLogInfo);
> 
>  			id = sas_event_data->TargetID;
>  			channel = sas_event_data->Bus;
> @@ -5023,7 +5022,8 @@ mptsas_event_process(MPT_ADAPTER *ioc,
> EventNotificationReply_t *reply)
>  				    "LogInfo (0x%x) available for "
>  				   "INTERNAL_DEVICE_RESET"
>  				   "fw_id %d fw_channel %d\n", ioc->name,
> -				   log_info, id, channel));
> +				   le32_to_cpu(reply->IOCLogInfo),
> +				   id, channel));
>  				if (vtarget->raidVolume) {
>  					devtprintk(ioc, printk(MYIOC_s_DEBUG_FMT
>  					"Skipping Raid Volume for inDMD\n",
> --
> 1.7.4.rc2


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-05-04 11:38 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-05-02 14:49 [PATCH] mptsas: Fix annoying warning Borislav Petkov
2011-05-04 11:40 ` Desai, Kashyap

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®