From: Johannes Berg <johannes@sipsolutions.net>
To: Rhyland Klein <rklein@nvidia.com>
Cc: "olof@lixom.net" <olof@lixom.net>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] net: rfkill: add generic gpio rfkill driver
Date: Thu, 12 May 2011 21:02:49 +0200 [thread overview]
Message-ID: <1305226969.3461.38.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1305226377.10961.12.camel@rklein-linux2>
On Thu, 2011-05-12 at 11:52 -0700, Rhyland Klein wrote:
> > If, on the other hand, rfkill decides that at the time of loading the
> > driver wifi should be on, then the first change would be +1 and it'll
> > flip between 0 and +1.
> >
> > This seems like it'll cause issues at some point, so I think you should
> > either allow the driver to set the initial state or hardcode one of
> > these possibilities (so at least it's predictable)
> I won't go negative, if you look, it only will disable clock if it knows
> it has already enabled it.
Ah, you're right, I misread the macros.
johannes
next prev parent reply other threads:[~2011-05-12 19:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-12 0:21 Rhyland Klein
2011-05-12 8:31 ` Johannes Berg
2011-05-12 18:23 ` Rhyland Klein
2011-05-12 18:40 ` Johannes Berg
2011-05-12 18:52 ` Rhyland Klein
2011-05-12 19:02 ` Johannes Berg [this message]
2011-05-12 21:23 ` Rhyland Klein
2011-05-13 7:15 ` Johannes Berg
2011-05-13 19:02 ` Rhyland Klein
2011-05-13 19:20 ` John W. Linville
2011-05-13 20:11 ` John W. Linville
2011-05-16 18:13 ` wireless-next-2.6 rebased -- " John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1305226969.3461.38.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=olof@lixom.net \
--cc=rklein@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome