mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH 3/3] printk loglevels modified to match the scenario
@ 2011-05-14 17:55 anish
  2011-05-16 15:49 ` [PATCH 3/3] printk loglevels modified to match the scenario [staging sm7xx] anish
  0 siblings, 1 reply; 2+ messages in thread
From: anish @ 2011-05-14 17:55 UTC (permalink / raw)
  To: greg, teddy.wang; +Cc: linux-kernel

KERN_ERR should be used in place of KERN_INFO in the case of
error scenarios.
Signed-off-by: anish kumar<anish198519851985@gmail.com>

---
drivers/staging/sm7xx/smtcfb.c |    8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/sm7xx/smtcfb.c
b/drivers/staging/sm7xx/smtcfb.c
index d1dd387..c8caf54 100644
--- a/drivers/staging/sm7xx/smtcfb.c
+++ b/drivers/staging/sm7xx/smtcfb.c
@@ -753,7 +753,7 @@ static int smtc_map_smem(struct smtcfb_info *sfb,
sfb->fb.screen_base = smtc_VRAMBaseAddress;

if (!sfb->fb.screen_base) {
- printk(KERN_INFO "%s: unable to map screen memory\n",
+ printk(KERN_ERR "%s: unable to map screen memory\n",
sfb->fb.fix.id);
return -ENOMEM;
}
@@ -908,7 +908,7 @@ static int __devinit smtcfb_pci_probe(struct pci_dev
*pdev,
}
#endif
if (!smtc_RegBaseAddress) {
- printk(KERN_INFO
+ printk(KERN_ERR
"%s: unable to map memory mapped IO\n",
sfb->fb.fix.id);
err = -ENOMEM;
@@ -943,7 +943,7 @@ static int __devinit smtcfb_pci_probe(struct pci_dev
*pdev,
smtc_seqw(0x6b, 0x02);
break;
default:
- printk(KERN_INFO
+ printk(KERN_ERR
"No valid Silicon Motion display chip was detected!\n");

goto failed_fb;
@@ -976,7 +976,7 @@ static int __devinit smtcfb_pci_probe(struct pci_dev
*pdev,
return 0;

  failed:
- printk(KERN_INFO "Silicon Motion, Inc.  primary display init fail\n");
+ printk(KERN_ERR "Silicon Motion, Inc.  primary display init fail\n");

smtc_unmap_smem(sfb);
smtc_unmap_mmio(sfb);
-- 
1.7.0.4




^ permalink raw reply	[flat|nested] 2+ messages in thread

* [PATCH 3/3] printk loglevels modified to match the scenario [staging sm7xx]
  2011-05-14 17:55 [PATCH 3/3] printk loglevels modified to match the scenario anish
@ 2011-05-16 15:49 ` anish
  0 siblings, 0 replies; 2+ messages in thread
From: anish @ 2011-05-16 15:49 UTC (permalink / raw)
  To: greg, teddy.wang, anish198519851985; +Cc: linux-kernel

KERN_ERR should be used in place of KERN_INFO in the case of
 error scenarios.
 Signed-off-by: anish kumar<anish198519851985@gmail.com>

---
 drivers/staging/sm7xx/smtcfb.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/sm7xx/smtcfb.c b/drivers/staging/sm7xx/smtcfb.c
index c41d2f7..a164fc4 100644
--- a/drivers/staging/sm7xx/smtcfb.c
+++ b/drivers/staging/sm7xx/smtcfb.c
@@ -783,7 +783,7 @@ static int smtc_map_smem(struct smtcfb_info *sfb,
 	sfb->fb.screen_base = smtc_VRAMBaseAddress;
 
 	if (!sfb->fb.screen_base) {
-		printk(KERN_INFO "%s: unable to map screen memory\n",
+		printk(KERN_ERR "%s: unable to map screen memory\n",
 				sfb->fb.fix.id);
 		return -ENOMEM;
 	}
@@ -938,7 +938,7 @@ static int __devinit smtcfb_pci_probe(struct pci_dev *pdev,
 		}
 #endif
 		if (!smtc_RegBaseAddress) {
-			printk(KERN_INFO
+			printk(KERN_ERR
 				"%s: unable to map memory mapped IO\n",
 				sfb->fb.fix.id);
 			err = -ENOMEM;
@@ -973,7 +973,7 @@ static int __devinit smtcfb_pci_probe(struct pci_dev *pdev,
 		smtc_seqw(0x6b, 0x02);
 		break;
 	default:
-		printk(KERN_INFO
+		printk(KERN_ERR
 		"No valid Silicon Motion display chip was detected!\n");
 
 		goto failed_fb;
@@ -1006,7 +1006,7 @@ static int __devinit smtcfb_pci_probe(struct pci_dev *pdev,
 	return 0;
 
 failed:
-	printk(KERN_INFO "Silicon Motion, Inc.  primary display init fail\n");
+	printk(KERN_ERR "Silicon Motion, Inc.  primary display init fail\n");
 
 	smtc_unmap_smem(sfb);
 	smtc_unmap_mmio(sfb);
-- 
1.7.0.4





^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-05-16 15:49 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-05-14 17:55 [PATCH 3/3] printk loglevels modified to match the scenario anish
2011-05-16 15:49 ` [PATCH 3/3] printk loglevels modified to match the scenario [staging sm7xx] anish

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®