[PATCH] dma: Initialize uninitialized variable

[PATCH] dma: Initialize uninitialized variable

[Guenter Roeck]

Uninitialized variable results in random debug output.
Fix by initializing to 0.

This commit fixes the following warning:

drivers/dma/pch_dma.c: In function pdc_desc_get:
drivers/dma/pch_dma.c:406: warning: i may be used uninitialized in this function

Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
 drivers/dma/pch_dma.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/dma/pch_dma.c b/drivers/dma/pch_dma.c
index 8d8fef1..6eebc62 100644
--- a/drivers/dma/pch_dma.c
+++ b/drivers/dma/pch_dma.c
@@ -403,7 +403,7 @@ static struct pch_dma_desc *pdc_desc_get(struct pch_dma_chan *pd_chan)
 {
 	struct pch_dma_desc *desc, *_d;
 	struct pch_dma_desc *ret = NULL;
-	int i;
+	int i = 0;
 
 	spin_lock(&pd_chan->lock);
 	list_for_each_entry_safe(desc, _d, &pd_chan->free_list, desc_node) {
-- 
1.7.1

Re: [PATCH] dma: Initialize uninitialized variable

[Koul, Vinod]

On Wed, 2011-05-25 at 23:48 -0700, Guenter Roeck wrote:
> Uninitialized variable results in random debug output.
> Fix by initializing to 0.
> 
> This commit fixes the following warning:
> 
> drivers/dma/pch_dma.c: In function pdc_desc_get:
> drivers/dma/pch_dma.c:406: warning: i may be used uninitialized in this function
> 
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
>  drivers/dma/pch_dma.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
Sorry I seem to have missed this earlier. This fix is already in place

commit 364de77831213be20f7f33c39ca1c194593b5c11
Author: Liu Yuan <tailai.ly@taobao.com>
Date:   Sat Apr 2 14:20:47 2011 +0800

    drivers, pch_dma: Fix uninitialized var before use
    
    In the function pdc_desc_get(), var 'i' is not
    initialized before use. This patch fixes it.
    
    Signed-off-by: Liu Yuan <tailai.ly@taobao.com>
    Signed-off-by: Vinod Koul <vinod.koul@intel.com>

~Vinod

> diff --git a/drivers/dma/pch_dma.c b/drivers/dma/pch_dma.c
> index 8d8fef1..6eebc62 100644
> --- a/drivers/dma/pch_dma.c
> +++ b/drivers/dma/pch_dma.c
> @@ -403,7 +403,7 @@ static struct pch_dma_desc *pdc_desc_get(struct pch_dma_chan *pd_chan)
>  {
>  	struct pch_dma_desc *desc, *_d;
>  	struct pch_dma_desc *ret = NULL;
> -	int i;
> +	int i = 0;
>  
>  	spin_lock(&pd_chan->lock);
>  	list_for_each_entry_safe(desc, _d, &pd_chan->free_list, desc_node) {