From: David Woodhouse <dwmw2@infradead.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix corruption of CONFIG_X86_32 in 'make oldconfig'
Date: Mon, 30 May 2011 09:57:12 +0100 [thread overview]
Message-ID: <1306745835.2029.389.camel@i7.infradead.org> (raw)
In-Reply-To: <20110530072300.GA9802@elte.hu>
On Mon, 2011-05-30 at 09:23 +0200, Ingo Molnar wrote:
> You thoroughly misunderstood my prior regression report, the problem
> with your patch was that your patch actually *broke* existing
> filtered-randconfig behavior, for example trying to get a 64-bit
> randconfig:
>
> make ARCH=x86_64 randconfig
>
> ... will today produce a 64-bit randconfig while with your old change
> applied it produced a 32-bit randconfig 50% of the time.
I believe that this 'filtered randconfig' behaviour is now fairly much
the *only* use for the old 'ARCH=i386' and 'ARCH=x86_64'.
Other than that, we ought to finally be able to 'complete' the merge of
32-bit and 64-bit support into ARCH=x86, and remove the last traces of
the obsolete ARCH={i386,x86_64} settings completely? Just as we did for
'ARCH=ppc{64,}' a few years ago.
And as I said, it's still an incomplete solution if you actually want a
'filtered randconfig' to do anything *useful*. You'd be much better off
implementing a *real* filtered randconfig that allows you to give a list
of hard-coded options, rather than relying on a dirty hack that only
actually sets *one* option of the many that you might need to
'hard-code' if you actually wanted a useful build.
So no, I don't think I misunderstood your "regression report" at all.
But go ahead and change the commit message if you must. As long as the
bug gets fixed, I'm content.
--
dwmw2
next prev parent reply other threads:[~2011-05-30 8:57 UTC|newest]
Thread overview: 88+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-29 22:14 David Woodhouse
2011-05-30 7:23 ` Ingo Molnar
2011-05-30 8:57 ` David Woodhouse [this message]
2011-05-30 9:15 ` Ingo Molnar
2011-05-30 9:27 ` David Woodhouse
2011-05-30 9:53 ` Ingo Molnar
2011-05-30 10:06 ` David Woodhouse
2011-05-30 10:25 ` Ingo Molnar
2011-05-30 11:01 ` David Woodhouse
2011-05-30 11:04 ` Ingo Molnar
2011-05-30 11:12 ` David Woodhouse
2011-05-30 11:42 ` Ingo Molnar
2011-05-30 11:55 ` David Woodhouse
2011-05-30 12:11 ` Ingo Molnar
2011-05-31 8:53 ` Geert Uytterhoeven
2011-05-31 10:48 ` Ingo Molnar
2011-05-30 10:40 ` Alexey Dobriyan
2011-05-30 10:09 ` [PATCH v2] x86, kconfig: Pick up the .config arch version " David Woodhouse
2011-06-24 13:37 ` Michal Marek
2011-06-24 14:45 ` David Woodhouse
2011-05-30 10:42 ` [PATCH] Fix corruption of CONFIG_X86_32 " Ingo Molnar
2011-05-30 10:46 ` Ingo Molnar
2011-05-30 10:53 ` Theodore Tso
2011-05-30 10:58 ` Ingo Molnar
2011-05-30 11:04 ` Theodore Tso
2011-05-30 11:30 ` Ingo Molnar
2011-05-30 17:29 ` Randy Dunlap
2011-05-30 11:57 ` David Woodhouse
2011-05-30 12:14 ` Ingo Molnar
2011-05-30 19:03 ` David Woodhouse
2011-05-30 19:55 ` Ted Ts'o
2011-05-30 20:12 ` David Woodhouse
2011-05-30 22:39 ` [PATCH] Enable 'make CONFIG_FOO=y oldconfig' David Woodhouse
2011-05-31 0:24 ` Arnaud Lacombe
2011-05-31 15:48 ` David Woodhouse
2011-05-31 16:12 ` Arnaud Lacombe
2011-06-24 13:49 ` Michal Marek
2011-07-29 23:32 ` [PATCH v2] " David Woodhouse
2011-07-30 1:15 ` Arnaud Lacombe
2011-07-30 9:04 ` David Woodhouse
2011-07-30 0:49 ` [PATCH v3] x86, kconfig: Default to ARCH=x86 to avoid overriding CONFIG_64BIT David Woodhouse
2011-07-30 1:26 ` Arnaud Lacombe
2011-07-30 8:37 ` David Woodhouse
2011-07-30 15:21 ` Arnaud Lacombe
2011-07-30 15:52 ` Arnaud Lacombe
2011-07-30 16:19 ` David Woodhouse
2011-07-30 16:33 ` Arnaud Lacombe
2011-07-30 18:59 ` H. Peter Anvin
2011-07-30 20:58 ` David Woodhouse
2011-07-30 22:03 ` H. Peter Anvin
2011-07-30 22:17 ` David Woodhouse
2011-07-30 22:21 ` H. Peter Anvin
2011-07-30 22:24 ` Arnaud Lacombe
2011-07-30 22:34 ` David Woodhouse
2011-07-30 22:39 ` H. Peter Anvin
2011-07-30 22:21 ` Arnaud Lacombe
2011-07-30 22:57 ` David Woodhouse
2011-07-31 19:40 ` Arnaud Lacombe
2011-07-31 20:00 ` David Woodhouse
2011-07-31 20:24 ` Arnaud Lacombe
2011-07-31 20:51 ` David Woodhouse
2011-07-31 5:18 ` Arnaud Lacombe
2011-07-31 8:13 ` David Woodhouse
2011-07-31 21:47 ` Arnaud Lacombe
2011-07-31 21:51 ` Arnaud Lacombe
2011-05-31 1:44 ` [PATCH] Fix corruption of CONFIG_X86_32 in 'make oldconfig' Ted Ts'o
2011-05-31 8:37 ` David Woodhouse
2011-05-31 7:53 ` Ingo Molnar
2011-05-31 8:55 ` David Woodhouse
2011-05-31 10:41 ` Ingo Molnar
2011-05-31 11:43 ` David Woodhouse
2011-05-31 12:45 ` Ingo Molnar
2011-05-31 13:44 ` David Woodhouse
2011-05-31 13:56 ` Ingo Molnar
2011-05-31 14:31 ` David Woodhouse
2011-05-31 14:14 ` Geert Uytterhoeven
2011-05-31 12:12 ` Ted Ts'o
2011-05-31 12:32 ` David Woodhouse
2011-05-31 12:50 ` Ingo Molnar
2011-05-30 11:06 ` David Woodhouse
2011-05-30 11:34 ` Ingo Molnar
2011-05-30 11:05 ` Arnd Bergmann
2011-05-30 17:27 ` Randy Dunlap
2011-05-30 18:40 ` Arnd Bergmann
2011-05-30 20:01 ` Randy Dunlap
2011-05-30 20:30 ` Arnaud Lacombe
2011-05-30 21:04 ` Arnd Bergmann
2011-05-30 21:16 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1306745835.2029.389.camel@i7.infradead.org \
--to=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®