From: David Woodhouse <dwmw2@infradead.org>
To: "Ted Ts'o" <tytso@mit.edu>
Cc: Ingo Molnar <mingo@elte.hu>,
x86@kernel.org, linux-kernel@vger.kernel.org,
linux-kbuild@vger.kernel.org
Subject: [PATCH] Enable 'make CONFIG_FOO=y oldconfig'
Date: Mon, 30 May 2011 23:39:43 +0100 [thread overview]
Message-ID: <1306795186.2029.459.camel@i7.infradead.org> (raw)
In-Reply-To: <alpine.LFD.2.02.1105302103220.3164@localhost6.localdomain6>
This allows you to set (and clear) config options on the make command
line, for all config targets. For example:
make CONFIG_64BIT=n randconfig
make CONFIG_64BIT=n allmodconfig
make CONFIG_64BIT=y CONFIG_SATA_MV=y oldconfig
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
diff --git a/scripts/kconfig/conf.c b/scripts/kconfig/conf.c
index 006ad81..2b91e3b 100644
--- a/scripts/kconfig/conf.c
+++ b/scripts/kconfig/conf.c
@@ -456,7 +456,7 @@ static struct option long_opts[] = {
{NULL, 0, NULL, 0}
};
-int main(int ac, char **av)
+int main(int ac, char **av, char **ep)
{
int opt;
const char *name;
@@ -563,6 +563,11 @@ int main(int ac, char **av)
break;
}
+ for ( ; *ep; ep++) {
+ if (!strncmp(*ep, CONFIG_, strlen(CONFIG_)))
+ conf_set_symbol_from_env(*ep);
+ }
+
if (sync_kconfig) {
if (conf_get_changed()) {
name = getenv("KCONFIG_NOSILENTUPDATE");
diff --git a/scripts/kconfig/confdata.c b/scripts/kconfig/confdata.c
index 61c35bf..e8ff902 100644
--- a/scripts/kconfig/confdata.c
+++ b/scripts/kconfig/confdata.c
@@ -338,6 +338,47 @@ setsym:
return 0;
}
+void conf_set_symbol_from_env(char *str)
+{
+ char *p = strchr(str, '=');
+ struct symbol *sym;
+ int def = S_DEF_USER;
+ int def_flags = SYMBOL_DEF << def;
+
+ if (!p)
+ return;
+
+ *p = 0;
+ sym = sym_find(str + strlen(CONFIG_));
+ *p++ = '=';
+
+ if (!sym)
+ return;
+
+ if (!sym_set_string_value(sym, p))
+ return;
+ conf_message("CONFIG_%s set to %s from environment", sym->name, p);
+ if (sym && sym_is_choice_value(sym)) {
+ struct symbol *cs = prop_get_symbol(sym_get_choice_prop(sym));
+ switch (sym->def[def].tri) {
+ case no:
+ break;
+ case mod:
+ if (cs->def[def].tri == yes) {
+ conf_warning("%s creates inconsistent choice state", sym->name);
+ cs->flags &= ~def_flags;
+ }
+ break;
+ case yes:
+ if (cs->def[def].tri != no)
+ conf_warning("override: %s changes choice state", sym->name);
+ cs->def[def].val = sym;
+ break;
+ }
+ cs->def[def].tri = EXPR_OR(cs->def[def].tri, sym->def[def].tri);
+ }
+}
+
int conf_read(const char *name)
{
struct symbol *sym, *choice_sym;
diff --git a/scripts/kconfig/lkc.h b/scripts/kconfig/lkc.h
index febf0c9..bf6fade 100644
--- a/scripts/kconfig/lkc.h
+++ b/scripts/kconfig/lkc.h
@@ -91,6 +91,7 @@ char *conf_get_default_confname(void);
void sym_set_change_count(int count);
void sym_add_change_count(int count);
void conf_set_all_new_symbols(enum conf_def_mode mode);
+void conf_set_symbol_from_env(char *);
/* confdata.c and expr.c */
static inline void xfwrite(const void *str, size_t len, size_t count, FILE *out)
--
dwmw2
next prev parent reply other threads:[~2011-05-30 22:39 UTC|newest]
Thread overview: 88+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-29 22:14 [PATCH] Fix corruption of CONFIG_X86_32 in 'make oldconfig' David Woodhouse
2011-05-30 7:23 ` Ingo Molnar
2011-05-30 8:57 ` David Woodhouse
2011-05-30 9:15 ` Ingo Molnar
2011-05-30 9:27 ` David Woodhouse
2011-05-30 9:53 ` Ingo Molnar
2011-05-30 10:06 ` David Woodhouse
2011-05-30 10:25 ` Ingo Molnar
2011-05-30 11:01 ` David Woodhouse
2011-05-30 11:04 ` Ingo Molnar
2011-05-30 11:12 ` David Woodhouse
2011-05-30 11:42 ` Ingo Molnar
2011-05-30 11:55 ` David Woodhouse
2011-05-30 12:11 ` Ingo Molnar
2011-05-31 8:53 ` Geert Uytterhoeven
2011-05-31 10:48 ` Ingo Molnar
2011-05-30 10:40 ` Alexey Dobriyan
2011-05-30 10:09 ` [PATCH v2] x86, kconfig: Pick up the .config arch version " David Woodhouse
2011-06-24 13:37 ` Michal Marek
2011-06-24 14:45 ` David Woodhouse
2011-05-30 10:42 ` [PATCH] Fix corruption of CONFIG_X86_32 " Ingo Molnar
2011-05-30 10:46 ` Ingo Molnar
2011-05-30 10:53 ` Theodore Tso
2011-05-30 10:58 ` Ingo Molnar
2011-05-30 11:04 ` Theodore Tso
2011-05-30 11:30 ` Ingo Molnar
2011-05-30 17:29 ` Randy Dunlap
2011-05-30 11:57 ` David Woodhouse
2011-05-30 12:14 ` Ingo Molnar
2011-05-30 19:03 ` David Woodhouse
2011-05-30 19:55 ` Ted Ts'o
2011-05-30 20:12 ` David Woodhouse
2011-05-30 22:39 ` David Woodhouse [this message]
2011-05-31 0:24 ` [PATCH] Enable 'make CONFIG_FOO=y oldconfig' Arnaud Lacombe
2011-05-31 15:48 ` David Woodhouse
2011-05-31 16:12 ` Arnaud Lacombe
2011-06-24 13:49 ` Michal Marek
2011-07-29 23:32 ` [PATCH v2] " David Woodhouse
2011-07-30 1:15 ` Arnaud Lacombe
2011-07-30 9:04 ` David Woodhouse
2011-07-30 0:49 ` [PATCH v3] x86, kconfig: Default to ARCH=x86 to avoid overriding CONFIG_64BIT David Woodhouse
2011-07-30 1:26 ` Arnaud Lacombe
2011-07-30 8:37 ` David Woodhouse
2011-07-30 15:21 ` Arnaud Lacombe
2011-07-30 15:52 ` Arnaud Lacombe
2011-07-30 16:19 ` David Woodhouse
2011-07-30 16:33 ` Arnaud Lacombe
2011-07-30 18:59 ` H. Peter Anvin
2011-07-30 20:58 ` David Woodhouse
2011-07-30 22:03 ` H. Peter Anvin
2011-07-30 22:17 ` David Woodhouse
2011-07-30 22:21 ` H. Peter Anvin
2011-07-30 22:24 ` Arnaud Lacombe
2011-07-30 22:34 ` David Woodhouse
2011-07-30 22:39 ` H. Peter Anvin
2011-07-30 22:21 ` Arnaud Lacombe
2011-07-30 22:57 ` David Woodhouse
2011-07-31 19:40 ` Arnaud Lacombe
2011-07-31 20:00 ` David Woodhouse
2011-07-31 20:24 ` Arnaud Lacombe
2011-07-31 20:51 ` David Woodhouse
2011-07-31 5:18 ` Arnaud Lacombe
2011-07-31 8:13 ` David Woodhouse
2011-07-31 21:47 ` Arnaud Lacombe
2011-07-31 21:51 ` Arnaud Lacombe
2011-05-31 1:44 ` [PATCH] Fix corruption of CONFIG_X86_32 in 'make oldconfig' Ted Ts'o
2011-05-31 8:37 ` David Woodhouse
2011-05-31 7:53 ` Ingo Molnar
2011-05-31 8:55 ` David Woodhouse
2011-05-31 10:41 ` Ingo Molnar
2011-05-31 11:43 ` David Woodhouse
2011-05-31 12:45 ` Ingo Molnar
2011-05-31 13:44 ` David Woodhouse
2011-05-31 13:56 ` Ingo Molnar
2011-05-31 14:31 ` David Woodhouse
2011-05-31 14:14 ` Geert Uytterhoeven
2011-05-31 12:12 ` Ted Ts'o
2011-05-31 12:32 ` David Woodhouse
2011-05-31 12:50 ` Ingo Molnar
2011-05-30 11:06 ` David Woodhouse
2011-05-30 11:34 ` Ingo Molnar
2011-05-30 11:05 ` Arnd Bergmann
2011-05-30 17:27 ` Randy Dunlap
2011-05-30 18:40 ` Arnd Bergmann
2011-05-30 20:01 ` Randy Dunlap
2011-05-30 20:30 ` Arnaud Lacombe
2011-05-30 21:04 ` Arnd Bergmann
2011-05-30 21:16 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1306795186.2029.459.camel@i7.infradead.org \
--to=dwmw2@infradead.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tytso@mit.edu \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®