[PATCH] leds: fix the menuconfig being wrongly displayed

[PATCH] leds: fix the menuconfig being wrongly displayed

[Eric Miao]

From: Eric Miao <eric.miao@canonical.com>

Seems when a config option does not have a dependency of the menuconfig,
it messes the display of the rest configs, even if it's a hidden one.

Signed-off-by: Eric Miao <eric.y.miao@gmail.com>
Cc: Richard Purdie <rpurdie@rpsys.net>
---
 drivers/leds/Kconfig |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
index 23f0d5e..7066820 100644
--- a/drivers/leds/Kconfig
+++ b/drivers/leds/Kconfig
@@ -7,6 +7,8 @@ menuconfig NEW_LEDS
 	  This is not related to standard keyboard LEDs which are controlled
 	  via the input system.
 
+if NEW_LEDS
+
 config LEDS_CLASS
 	bool "LED Class Support"
 	depends on NEW_LEDS
@@ -21,8 +23,6 @@ config LEDS_GPIO_REGISTER
 	  As this function is used by arch code it must not be compiled as a
 	  module.
 
-if NEW_LEDS
-
 comment "LED drivers"
 
 config LEDS_88PM860X
-- 
1.7.4.1

Re: [PATCH] leds: fix the menuconfig being wrongly displayed

[Valdis.Kletnieks]

[-- Attachment #1: Type: text/plain, Size: 881 bytes --]

On Thu, 02 Jun 2011 13:09:14 +0800, Eric Miao said:
> From: Eric Miao <eric.miao@canonical.com>
> 
> Seems when a config option does not have a dependency of the menuconfig,
> it messes the display of the rest configs, even if it's a hidden one.
> 
> Signed-off-by: Eric Miao <eric.y.miao@gmail.com>
> Cc: Richard Purdie <rpurdie@rpsys.net>
> ---
>  drivers/leds/Kconfig |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
> index 23f0d5e..7066820 100644
> --- a/drivers/leds/Kconfig
> +++ b/drivers/leds/Kconfig
> @@ -7,6 +7,8 @@ menuconfig NEW_LEDS
>  	  This is not related to standard keyboard LEDs which are controlled
>  	  via the input system.
>  
> +if NEW_LEDS
> +
>  config LEDS_CLASS
>  	bool "LED Class Support"
>  	depends on NEW_LEDS

Having added that 'if', do we still need that 'depends'?

[-- Attachment #2: Type: application/pgp-signature, Size: 227 bytes --]

Re: [PATCH] leds: fix the menuconfig being wrongly displayed

[Eric Miao]

On Thu, Jun 2, 2011 at 8:57 PM,  <Valdis.Kletnieks@vt.edu> wrote:
> On Thu, 02 Jun 2011 13:09:14 +0800, Eric Miao said:
>> From: Eric Miao <eric.miao@canonical.com>
>>
>> Seems when a config option does not have a dependency of the menuconfig,
>> it messes the display of the rest configs, even if it's a hidden one.
>>
>> Signed-off-by: Eric Miao <eric.y.miao@gmail.com>
>> Cc: Richard Purdie <rpurdie@rpsys.net>
>> ---
>>  drivers/leds/Kconfig |    4 ++--
>>  1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
>> index 23f0d5e..7066820 100644
>> --- a/drivers/leds/Kconfig
>> +++ b/drivers/leds/Kconfig
>> @@ -7,6 +7,8 @@ menuconfig NEW_LEDS
>>         This is not related to standard keyboard LEDs which are controlled
>>         via the input system.
>>
>> +if NEW_LEDS
>> +
>>  config LEDS_CLASS
>>       bool "LED Class Support"
>>       depends on NEW_LEDS
>
> Having added that 'if', do we still need that 'depends'?
>

I don't think so. We can definitely remove it. Updated as follows:

diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
index 23f0d5e..1251e6a 100644
--- a/drivers/leds/Kconfig
+++ b/drivers/leds/Kconfig
@@ -7,9 +7,10 @@ menuconfig NEW_LEDS
          This is not related to standard keyboard LEDs which are controlled
          via the input system.

+if NEW_LEDS
+
 config LEDS_CLASS
        bool "LED Class Support"
-       depends on NEW_LEDS
        help
          This option enables the led sysfs class in /sys/class/leds.  You'll
          need this to do anything useful with LEDs.  If unsure, say N.
@@ -21,8 +22,6 @@ config LEDS_GPIO_REGISTER
          As this function is used by arch code it must not be compiled as a
          module.

-if NEW_LEDS
-
 comment "LED drivers"

 config LEDS_88PM860X