* [PATCH] media: soc_camera_video_start - type should be const
@ 2011-06-05 20:45 Geert Uytterhoeven
2011-06-06 9:46 ` Guennadi Liakhovetski
0 siblings, 1 reply; 2+ messages in thread
From: Geert Uytterhoeven @ 2011-06-05 20:45 UTC (permalink / raw)
To: Mauro Carvalho Chehab, Guennadi Liakhovetski
Cc: linux-media, linux-kernel, Geert Uytterhoeven
drivers/media/video/soc_camera.c: In function ‘soc_camera_video_start’:
drivers/media/video/soc_camera.c:1515: warning: initialization discards qualifiers from pointer target type
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
drivers/media/video/soc_camera.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/media/video/soc_camera.c b/drivers/media/video/soc_camera.c
index 3988643..4e4d412 100644
--- a/drivers/media/video/soc_camera.c
+++ b/drivers/media/video/soc_camera.c
@@ -1512,7 +1512,7 @@ static int video_dev_create(struct soc_camera_device *icd)
*/
static int soc_camera_video_start(struct soc_camera_device *icd)
{
- struct device_type *type = icd->vdev->dev.type;
+ const struct device_type *type = icd->vdev->dev.type;
int ret;
if (!icd->dev.parent)
--
1.7.0.4
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] media: soc_camera_video_start - type should be const
2011-06-05 20:45 [PATCH] media: soc_camera_video_start - type should be const Geert Uytterhoeven
@ 2011-06-06 9:46 ` Guennadi Liakhovetski
0 siblings, 0 replies; 2+ messages in thread
From: Guennadi Liakhovetski @ 2011-06-06 9:46 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: Mauro Carvalho Chehab, linux-media, linux-kernel
Hi Geert
On Sun, 5 Jun 2011, Geert Uytterhoeven wrote:
> drivers/media/video/soc_camera.c: In function ‘soc_camera_video_start’:
> drivers/media/video/soc_camera.c:1515: warning: initialization discards qualifiers from pointer target type
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
> drivers/media/video/soc_camera.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/media/video/soc_camera.c b/drivers/media/video/soc_camera.c
> index 3988643..4e4d412 100644
> --- a/drivers/media/video/soc_camera.c
> +++ b/drivers/media/video/soc_camera.c
> @@ -1512,7 +1512,7 @@ static int video_dev_create(struct soc_camera_device *icd)
> */
> static int soc_camera_video_start(struct soc_camera_device *icd)
> {
> - struct device_type *type = icd->vdev->dev.type;
> + const struct device_type *type = icd->vdev->dev.type;
> int ret;
>
> if (!icd->dev.parent)
> --
> 1.7.0.4
Thanks for the patchm unfortunately, you're not the first:
http://www.mail-archive.com/linux-media@vger.kernel.org/msg32245.html
and not even the second;)
Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-06-06 9:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-06-05 20:45 [PATCH] media: soc_camera_video_start - type should be const Geert Uytterhoeven
2011-06-06 9:46 ` Guennadi Liakhovetski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®