From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: linux-kernel@vger.kernel.org
Cc: mingo@elte.hu, laijs@cn.fujitsu.com, dipankar@in.ibm.com,
akpm@linux-foundation.org, mathieu.desnoyers@polymtl.ca,
josh@joshtriplett.org, niv@us.ibm.com, tglx@linutronix.de,
peterz@infradead.org, rostedt@goodmis.org,
Valdis.Kletnieks@vt.edu, dhowells@redhat.com,
eric.dumazet@gmail.com, darren@dvhart.com, patches@linaro.org,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Subject: [PATCH tip/core/rcu 09/28] rcu: Catch rcutorture up to new RCU API additions
Date: Wed, 8 Jun 2011 12:29:48 -0700 [thread overview]
Message-ID: <1307561407-13809-9-git-send-email-paulmck@linux.vnet.ibm.com> (raw)
In-Reply-To: <20110608192943.GA13211@linux.vnet.ibm.com>
Now that the RCU API contains synchronize_rcu_bh(), synchronize_sched(),
call_rcu_sched(), and rcu_bh_expedited()...
Make rcutorture test synchronize_rcu_bh(), getting rid of the old
rcu_bh_torture_synchronize() workaround. Similarly, make rcutorture test
synchronize_sched(), getting rid of the old sched_torture_synchronize()
workaround. Make rcutorture test call_rcu_sched() instead of wrappering
synchronize_sched(). Also add testing of rcu_bh_expedited().
Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
---
kernel/rcutorture.c | 55 +++++++++++++++++++-------------------------------
1 files changed, 21 insertions(+), 34 deletions(-)
diff --git a/kernel/rcutorture.c b/kernel/rcutorture.c
index 40d9ed2..f736fe3 100644
--- a/kernel/rcutorture.c
+++ b/kernel/rcutorture.c
@@ -480,30 +480,6 @@ static void rcu_bh_torture_deferred_free(struct rcu_torture *p)
call_rcu_bh(&p->rtort_rcu, rcu_torture_cb);
}
-struct rcu_bh_torture_synchronize {
- struct rcu_head head;
- struct completion completion;
-};
-
-static void rcu_bh_torture_wakeme_after_cb(struct rcu_head *head)
-{
- struct rcu_bh_torture_synchronize *rcu;
-
- rcu = container_of(head, struct rcu_bh_torture_synchronize, head);
- complete(&rcu->completion);
-}
-
-static void rcu_bh_torture_synchronize(void)
-{
- struct rcu_bh_torture_synchronize rcu;
-
- init_rcu_head_on_stack(&rcu.head);
- init_completion(&rcu.completion);
- call_rcu_bh(&rcu.head, rcu_bh_torture_wakeme_after_cb);
- wait_for_completion(&rcu.completion);
- destroy_rcu_head_on_stack(&rcu.head);
-}
-
static struct rcu_torture_ops rcu_bh_ops = {
.init = NULL,
.cleanup = NULL,
@@ -512,7 +488,7 @@ static struct rcu_torture_ops rcu_bh_ops = {
.readunlock = rcu_bh_torture_read_unlock,
.completed = rcu_bh_torture_completed,
.deferred_free = rcu_bh_torture_deferred_free,
- .sync = rcu_bh_torture_synchronize,
+ .sync = synchronize_rcu_bh,
.cb_barrier = rcu_barrier_bh,
.fqs = rcu_bh_force_quiescent_state,
.stats = NULL,
@@ -528,7 +504,7 @@ static struct rcu_torture_ops rcu_bh_sync_ops = {
.readunlock = rcu_bh_torture_read_unlock,
.completed = rcu_bh_torture_completed,
.deferred_free = rcu_sync_torture_deferred_free,
- .sync = rcu_bh_torture_synchronize,
+ .sync = synchronize_rcu_bh,
.cb_barrier = NULL,
.fqs = rcu_bh_force_quiescent_state,
.stats = NULL,
@@ -536,6 +512,22 @@ static struct rcu_torture_ops rcu_bh_sync_ops = {
.name = "rcu_bh_sync"
};
+static struct rcu_torture_ops rcu_bh_expedited_ops = {
+ .init = rcu_sync_torture_init,
+ .cleanup = NULL,
+ .readlock = rcu_bh_torture_read_lock,
+ .read_delay = rcu_read_delay, /* just reuse rcu's version. */
+ .readunlock = rcu_bh_torture_read_unlock,
+ .completed = rcu_bh_torture_completed,
+ .deferred_free = rcu_sync_torture_deferred_free,
+ .sync = synchronize_rcu_bh_expedited,
+ .cb_barrier = NULL,
+ .fqs = rcu_bh_force_quiescent_state,
+ .stats = NULL,
+ .irq_capable = 1,
+ .name = "rcu_bh_expedited"
+};
+
/*
* Definitions for srcu torture testing.
*/
@@ -659,11 +651,6 @@ static void rcu_sched_torture_deferred_free(struct rcu_torture *p)
call_rcu_sched(&p->rtort_rcu, rcu_torture_cb);
}
-static void sched_torture_synchronize(void)
-{
- synchronize_sched();
-}
-
static struct rcu_torture_ops sched_ops = {
.init = rcu_sync_torture_init,
.cleanup = NULL,
@@ -672,7 +659,7 @@ static struct rcu_torture_ops sched_ops = {
.readunlock = sched_torture_read_unlock,
.completed = rcu_no_completed,
.deferred_free = rcu_sched_torture_deferred_free,
- .sync = sched_torture_synchronize,
+ .sync = synchronize_sched,
.cb_barrier = rcu_barrier_sched,
.fqs = rcu_sched_force_quiescent_state,
.stats = NULL,
@@ -688,7 +675,7 @@ static struct rcu_torture_ops sched_sync_ops = {
.readunlock = sched_torture_read_unlock,
.completed = rcu_no_completed,
.deferred_free = rcu_sync_torture_deferred_free,
- .sync = sched_torture_synchronize,
+ .sync = synchronize_sched,
.cb_barrier = NULL,
.fqs = rcu_sched_force_quiescent_state,
.stats = NULL,
@@ -1427,7 +1414,7 @@ rcu_torture_init(void)
int firsterr = 0;
static struct rcu_torture_ops *torture_ops[] =
{ &rcu_ops, &rcu_sync_ops, &rcu_expedited_ops,
- &rcu_bh_ops, &rcu_bh_sync_ops,
+ &rcu_bh_ops, &rcu_bh_sync_ops, &rcu_bh_expedited_ops,
&srcu_ops, &srcu_expedited_ops,
&sched_ops, &sched_sync_ops, &sched_expedited_ops, };
--
1.7.3.2
next prev parent reply other threads:[~2011-06-08 19:37 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-08 19:29 [PATCH tip/core/rcu 0/28] patches queued for 3.1, first installment Paul E. McKenney
2011-06-08 19:29 ` [PATCH tip/core/rcu 01/28] rcu: Simplify curing of load woes Paul E. McKenney
2011-06-10 14:18 ` Peter Zijlstra
2011-06-10 19:53 ` Paul E. McKenney
2011-06-08 19:29 ` [PATCH tip/core/rcu 02/28] rcu: Use kthread_create_on_node() Paul E. McKenney
2011-06-08 19:29 ` [PATCH tip/core/rcu 03/28] rcu: Streamline code produced by __rcu_read_unlock() Paul E. McKenney
2011-06-08 23:17 ` Mathieu Desnoyers
[not found] ` <BLU0-SMTP16E45D0FAD13ACF913B28B96620@phx.gbl>
2011-06-08 23:58 ` Paul E. McKenney
2011-06-09 3:45 ` Josh Triplett
2011-06-09 14:17 ` Paul E. McKenney
2011-06-10 7:14 ` Lai Jiangshan
2011-06-10 19:35 ` Paul E. McKenney
2011-06-08 19:29 ` [PATCH tip/core/rcu 04/28] rcu: Restore checks for blocking in RCU read-side critical sections Paul E. McKenney
2011-06-08 23:28 ` Frederic Weisbecker
2011-06-08 23:46 ` Paul E. McKenney
2011-06-08 23:48 ` Frederic Weisbecker
2011-06-08 19:29 ` [PATCH tip/core/rcu 05/28] rcu: Move rcu_head definition to types.h Paul E. McKenney
2011-06-08 23:26 ` Mathieu Desnoyers
[not found] ` <BLU0-SMTP635E2E394E1488A2717A5B96620@phx.gbl>
2011-06-09 0:02 ` Paul E. McKenney
2011-06-09 0:11 ` Mathieu Desnoyers
[not found] ` <BLU0-SMTP796363CC311D3AB84B196996650@phx.gbl>
2011-06-09 18:38 ` Paul E. McKenney
2011-06-09 20:12 ` Mathieu Desnoyers
2011-06-08 19:29 ` [PATCH tip/core/rcu 06/28] rcu: Update rcutorture documentation Paul E. McKenney
2011-06-08 19:29 ` [PATCH tip/core/rcu 07/28] Fix mismatched variable in rcutree_trace.c Paul E. McKenney
2011-06-08 23:23 ` Mathieu Desnoyers
[not found] ` <BLU0-SMTP181D8DEE03E1353C8A106396620@phx.gbl>
2011-06-09 0:03 ` Paul E. McKenney
2011-06-08 19:29 ` [PATCH tip/core/rcu 08/28] rcu: Abstract common code for RCU grace-period-wait primitives Paul E. McKenney
2011-06-08 19:29 ` Paul E. McKenney [this message]
2011-06-08 19:29 ` [PATCH tip/core/rcu 10/28] rcu: Fix RCU's NMI documentation Paul E. McKenney
2011-06-08 23:19 ` Mathieu Desnoyers
2011-06-08 19:29 ` [PATCH tip/core/rcu 11/28] audit_tree,rcu: Convert call_rcu(__put_tree) to kfree_rcu() Paul E. McKenney
2011-06-08 19:29 ` [PATCH tip/core/rcu 12/28] block,rcu: Convert call_rcu(cfq_cfqd_free) " Paul E. McKenney
2011-06-08 19:29 ` [PATCH tip/core/rcu 13/28] nfs,rcu: Convert call_rcu(nfs_free_delegation_callback) " Paul E. McKenney
2011-06-09 17:12 ` Trond Myklebust
2011-06-08 19:29 ` [PATCH tip/core/rcu 14/28] security,rcu: Convert call_rcu(whitelist_item_free) " Paul E. McKenney
2011-06-09 0:39 ` James Morris
2011-06-09 18:45 ` Paul E. McKenney
2011-06-08 19:29 ` [PATCH tip/core/rcu 15/28] scsi,rcu: Convert call_rcu(fc_rport_free_rcu) " Paul E. McKenney
2011-06-08 19:29 ` [PATCH tip/core/rcu 16/28] block,rcu: Convert call_rcu(disk_free_ptbl_rcu_cb) " Paul E. McKenney
2011-06-08 19:29 ` [PATCH tip/core/rcu 17/28] ia64,rcu: Convert call_rcu(sn_irq_info_free) " Paul E. McKenney
2011-06-08 19:29 ` [PATCH tip/core/rcu 18/28] jbd2,rcu: Convert call_rcu(free_devcache) " Paul E. McKenney
2011-06-08 19:34 ` Jan Kara
2011-06-08 19:47 ` Paul E. McKenney
2011-06-08 19:29 ` [PATCH tip/core/rcu 19/28] md,rcu: Convert call_rcu(free_conf) " Paul E. McKenney
2011-06-09 2:03 ` NeilBrown
2011-06-08 19:29 ` [PATCH tip/core/rcu 20/28] security,rcu: Convert call_rcu(sel_netnode_free) " Paul E. McKenney
2011-06-08 19:30 ` [PATCH tip/core/rcu 21/28] security,rcu: Convert call_rcu(sel_netport_free) " Paul E. McKenney
2011-06-08 19:30 ` [PATCH tip/core/rcu 22/28] ipc,rcu: Convert call_rcu(free_un) " Paul E. McKenney
2011-06-08 19:30 ` [PATCH tip/core/rcu 23/28] ipc,rcu: Convert call_rcu(ipc_immediate_free) " Paul E. McKenney
2011-06-08 19:30 ` [PATCH tip/core/rcu 24/28] vmalloc,rcu: Convert call_rcu(rcu_free_va) " Paul E. McKenney
2011-06-08 19:30 ` [PATCH tip/core/rcu 25/28] vmalloc,rcu: Convert call_rcu(rcu_free_vb) " Paul E. McKenney
2011-06-08 19:30 ` [PATCH tip/core/rcu 26/28] sysctl,rcu: Convert call_rcu(free_head) to kfree Paul E. McKenney
2011-06-08 19:30 ` [PATCH tip/core/rcu 27/28] net,rcu: Convert call_rcu(xt_rateest_free_rcu) to kfree_rcu() Paul E. McKenney
2011-06-08 19:30 ` [PATCH tip/core/rcu 28/28] net,rcu: Convert call_rcu(sk_filter_release_rcu) to kfree_rcu Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1307561407-13809-9-git-send-email-paulmck@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=Valdis.Kletnieks@vt.edu \
--cc=akpm@linux-foundation.org \
--cc=darren@dvhart.com \
--cc=dhowells@redhat.com \
--cc=dipankar@in.ibm.com \
--cc=eric.dumazet@gmail.com \
--cc=josh@joshtriplett.org \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@polymtl.ca \
--cc=mingo@elte.hu \
--cc=niv@us.ibm.com \
--cc=patches@linaro.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome