* [PATCH] spi/rtc-m41t93: Use spi_get_drvdata() for SPI devices
@ 2011-06-08 19:48 Geert Uytterhoeven
2011-06-08 20:34 ` Grant Likely
0 siblings, 1 reply; 2+ messages in thread
From: Geert Uytterhoeven @ 2011-06-08 19:48 UTC (permalink / raw)
To: Nikolaus Voss, Alessandro Zummo, Grant Likely, Andrew Morton
Cc: rtc-linux, linux-kernel, Geert Uytterhoeven
One new offender detected by the recently increased type checking in
platform_get_drvdata():
drivers/rtc/rtc-m41t93.c: In function ‘m41t93_remove’:
drivers/rtc/rtc-m41t93.c:192: warning: passing argument 1 of ‘platform_get_drvdata’ from incompatible pointer type
Use spi_get_drvdata() instead of platform_get_drvdata(), cfr. commit
42fea15d6dc410e62dac6a764142045280624a5b ("spi/rtc-{ds1390,ds3234,m41t94}:
Use spi_get_drvdata() for SPI devices")
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
drivers/rtc/rtc-m41t93.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/rtc/rtc-m41t93.c b/drivers/rtc/rtc-m41t93.c
index 1a84b3e..7317d3b 100644
--- a/drivers/rtc/rtc-m41t93.c
+++ b/drivers/rtc/rtc-m41t93.c
@@ -189,7 +189,7 @@ static int __devinit m41t93_probe(struct spi_device *spi)
static int __devexit m41t93_remove(struct spi_device *spi)
{
- struct rtc_device *rtc = platform_get_drvdata(spi);
+ struct rtc_device *rtc = spi_get_drvdata(spi);
if (rtc)
rtc_device_unregister(rtc);
--
1.7.0.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] spi/rtc-m41t93: Use spi_get_drvdata() for SPI devices
2011-06-08 19:48 [PATCH] spi/rtc-m41t93: Use spi_get_drvdata() for SPI devices Geert Uytterhoeven
@ 2011-06-08 20:34 ` Grant Likely
0 siblings, 0 replies; 2+ messages in thread
From: Grant Likely @ 2011-06-08 20:34 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Nikolaus Voss, Alessandro Zummo, Andrew Morton, rtc-linux, linux-kernel
On Wed, Jun 08, 2011 at 09:48:03PM +0200, Geert Uytterhoeven wrote:
> One new offender detected by the recently increased type checking in
> platform_get_drvdata():
>
> drivers/rtc/rtc-m41t93.c: In function ‘m41t93_remove’:
> drivers/rtc/rtc-m41t93.c:192: warning: passing argument 1 of ‘platform_get_drvdata’ from incompatible pointer type
Applied, thanks.
g.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-06-08 20:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-06-08 19:48 [PATCH] spi/rtc-m41t93: Use spi_get_drvdata() for SPI devices Geert Uytterhoeven
2011-06-08 20:34 ` Grant Likely
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®