From: Steven Rostedt <rostedt@goodmis.org>
To: David Rientjes <rientjes@google.com>
Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
vnagarnaik@google.com, mingo@redhat.com, fweisbec@gmail.com,
mrubin@google.com, dhsharp@google.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] trace: Set __GFP_NORETRY flag for ring buffer allocating process
Date: Thu, 09 Jun 2011 15:52:42 -0400 [thread overview]
Message-ID: <1307649162.9218.41.camel@gandalf.stny.rr.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1106091237580.11607@chino.kir.corp.google.com>
On Thu, 2011-06-09 at 12:42 -0700, David Rientjes wrote:
> It would only happen if there was an antagonist that stole the reclaimed
> pages before your __GFP_NORETRY allocation could allocate them, resulting
> in the system being oom again as it was before reclaim occurred. Without
> __GFP_NORETRY, we'd automatically retry these allocations in a loop until
> we found the memory since they are order-0, so the only side effect would
> be an increased latency in the allocation. I think if we still end up oom
> after reclaiming memory that was allocated by another thread that we
> probably don't want to be expanding the ring buffer and, thus, I see no
> problem with just failing.
Agreed, which is why I already pushed the patch.
-- Steve
next prev parent reply other threads:[~2011-06-09 19:52 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-26 19:52 [PATCH] trace: Set oom_score_adj to maximum " Vaibhav Nagarnaik
2011-05-26 20:04 ` Steven Rostedt
2011-05-26 20:22 ` David Rientjes
2011-05-26 20:23 ` Vaibhav Nagarnaik
2011-05-26 20:33 ` David Rientjes
2011-05-26 21:00 ` Steven Rostedt
2011-05-26 22:28 ` Vaibhav Nagarnaik
2011-05-26 23:38 ` Steven Rostedt
2011-05-27 9:43 ` David Rientjes
2011-05-27 12:48 ` Steven Rostedt
2011-05-26 23:23 ` Vaibhav Nagarnaik
2011-05-27 17:58 ` Vaibhav Nagarnaik
2011-05-27 23:22 ` David Rientjes
2011-05-28 0:44 ` Vaibhav Nagarnaik
2011-05-28 1:50 ` Steven Rostedt
2011-05-30 6:23 ` KOSAKI Motohiro
2011-05-30 23:54 ` Vaibhav Nagarnaik
2011-05-30 23:46 ` Vaibhav Nagarnaik
2011-06-07 23:07 ` Steven Rostedt
2011-06-07 23:30 ` Vaibhav Nagarnaik
2011-06-07 23:41 ` [PATCH] trace: Set __GFP_NORETRY flag " Vaibhav Nagarnaik
2011-06-07 23:47 ` Frederic Weisbecker
2011-06-08 0:01 ` [PATCH v2] " Vaibhav Nagarnaik
2011-06-08 2:30 ` David Rientjes
2011-06-09 11:37 ` KOSAKI Motohiro
2011-06-09 12:14 ` Steven Rostedt
2011-06-09 18:41 ` Vaibhav Nagarnaik
2011-06-09 19:42 ` David Rientjes
2011-06-09 19:52 ` Steven Rostedt [this message]
2011-07-05 12:54 ` [tip:perf/core] ring-buffer: " tip-bot for Vaibhav Nagarnaik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1307649162.9218.41.camel@gandalf.stny.rr.com \
--to=rostedt@goodmis.org \
--cc=dhsharp@google.com \
--cc=fweisbec@gmail.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mrubin@google.com \
--cc=rientjes@google.com \
--cc=vnagarnaik@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®