From: Vaibhav Nagarnaik <vnagarnaik@google.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: David Rientjes <rientjes@google.com>,
Ingo Molnar <mingo@redhat.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Michael Rubin <mrubin@google.com>,
David Sharp <dhsharp@google.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] trace: Set oom_score_adj to maximum for ring buffer allocating process
Date: Thu, 26 May 2011 16:23:58 -0700 [thread overview]
Message-ID: <BANLkTim_DLbOXrmRdMeOa9FhhqEgjMVZDg@mail.gmail.com> (raw)
In-Reply-To: <1306443612.3857.15.camel@gandalf.stny.rr.com>
On Thu, May 26, 2011 at 2:00 PM, Steven Rostedt <rostedt@goodmis.org> wrote:
> I'm thinking the oom killer used here got lucky. As it killed this task,
> we were still out of memory, and the ring buffer failed to get the
> memory it needed and freed up everything that it previously allocated,
> and returned. Then the process calling this function would be killed by
I have tested this multiple times and I don't see any other process
being killed, regardless of who invoked oom-killer. The oom-killer
always selects the "echo" process to kill because of its maximum
oom_score_adj and sets TIF_MEMDIE. Since the ring buffer is still
getting allocated, any further allocation from this process fails
because of this flag and the fatal signal pending. This causes the ring
buffer memory to be freed.
I don't see the oom-killer getting lucky in my test cases.
Vaibhav Nagarnaik
next prev parent reply other threads:[~2011-05-26 23:24 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-26 19:52 Vaibhav Nagarnaik
2011-05-26 20:04 ` Steven Rostedt
2011-05-26 20:22 ` David Rientjes
2011-05-26 20:23 ` Vaibhav Nagarnaik
2011-05-26 20:33 ` David Rientjes
2011-05-26 21:00 ` Steven Rostedt
2011-05-26 22:28 ` Vaibhav Nagarnaik
2011-05-26 23:38 ` Steven Rostedt
2011-05-27 9:43 ` David Rientjes
2011-05-27 12:48 ` Steven Rostedt
2011-05-26 23:23 ` Vaibhav Nagarnaik [this message]
2011-05-27 17:58 ` Vaibhav Nagarnaik
2011-05-27 23:22 ` David Rientjes
2011-05-28 0:44 ` Vaibhav Nagarnaik
2011-05-28 1:50 ` Steven Rostedt
2011-05-30 6:23 ` KOSAKI Motohiro
2011-05-30 23:54 ` Vaibhav Nagarnaik
2011-05-30 23:46 ` Vaibhav Nagarnaik
2011-06-07 23:07 ` Steven Rostedt
2011-06-07 23:30 ` Vaibhav Nagarnaik
2011-06-07 23:41 ` [PATCH] trace: Set __GFP_NORETRY flag " Vaibhav Nagarnaik
2011-06-07 23:47 ` Frederic Weisbecker
2011-06-08 0:01 ` [PATCH v2] " Vaibhav Nagarnaik
2011-06-08 2:30 ` David Rientjes
2011-06-09 11:37 ` KOSAKI Motohiro
2011-06-09 12:14 ` Steven Rostedt
2011-06-09 18:41 ` Vaibhav Nagarnaik
2011-06-09 19:42 ` David Rientjes
2011-06-09 19:52 ` Steven Rostedt
2011-07-05 12:54 ` [tip:perf/core] ring-buffer: " tip-bot for Vaibhav Nagarnaik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTim_DLbOXrmRdMeOa9FhhqEgjMVZDg@mail.gmail.com \
--to=vnagarnaik@google.com \
--cc=dhsharp@google.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mrubin@google.com \
--cc=rientjes@google.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®