* [PATCH] perf tools: Don't corrupt PERF-VERSION-FILE with make debug
@ 2011-06-20 15:53 Robert Richter
2011-06-22 9:50 ` Ingo Molnar
0 siblings, 1 reply; 2+ messages in thread
From: Robert Richter @ 2011-06-20 15:53 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo; +Cc: Ingo Molnar, LKML, Robert Richter
When running make with debug option -d the PERF-VERSION-FILE gets
corrupted because make is noisy:
PERF-VERSION-FILE:2: *** missing separator. Stop.
Fixing this by not passing the make flags in the MAKEFLAGS environment
variable to the sub-make that generates the version string.
Signed-off-by: Robert Richter <robert.richter@amd.com>
---
tools/perf/util/PERF-VERSION-GEN | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/tools/perf/util/PERF-VERSION-GEN b/tools/perf/util/PERF-VERSION-GEN
index 9c5fb4d..ad73300 100755
--- a/tools/perf/util/PERF-VERSION-GEN
+++ b/tools/perf/util/PERF-VERSION-GEN
@@ -23,7 +23,7 @@ if test -d ../../.git -o -f ../../.git &&
then
VN=$(echo "$VN" | sed -e 's/-/./g');
else
- VN=$(make -sC ../.. kernelversion)
+ VN=$(MAKEFLAGS= make -sC ../.. kernelversion)
fi
VN=$(expr "$VN" : v*'\(.*\)')
--
1.7.5.3
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] perf tools: Don't corrupt PERF-VERSION-FILE with make debug
2011-06-20 15:53 [PATCH] perf tools: Don't corrupt PERF-VERSION-FILE with make debug Robert Richter
@ 2011-06-22 9:50 ` Ingo Molnar
0 siblings, 0 replies; 2+ messages in thread
From: Ingo Molnar @ 2011-06-22 9:50 UTC (permalink / raw)
To: Robert Richter; +Cc: Arnaldo Carvalho de Melo, LKML
* Robert Richter <robert.richter@amd.com> wrote:
> When running make with debug option -d the PERF-VERSION-FILE gets
> corrupted because make is noisy:
>
> PERF-VERSION-FILE:2: *** missing separator. Stop.
>
> Fixing this by not passing the make flags in the MAKEFLAGS environment
> variable to the sub-make that generates the version string.
>
> Signed-off-by: Robert Richter <robert.richter@amd.com>
> ---
> tools/perf/util/PERF-VERSION-GEN | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/tools/perf/util/PERF-VERSION-GEN b/tools/perf/util/PERF-VERSION-GEN
> index 9c5fb4d..ad73300 100755
> --- a/tools/perf/util/PERF-VERSION-GEN
> +++ b/tools/perf/util/PERF-VERSION-GEN
> @@ -23,7 +23,7 @@ if test -d ../../.git -o -f ../../.git &&
> then
> VN=$(echo "$VN" | sed -e 's/-/./g');
> else
> - VN=$(make -sC ../.. kernelversion)
> + VN=$(MAKEFLAGS= make -sC ../.. kernelversion)
Yeah, and this has been fixed recently, via:
37aa9a2eb4d9: perf: clear out make flags when calling kernel make kernelver
Thanks,
Ingo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-06-22 9:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-06-20 15:53 [PATCH] perf tools: Don't corrupt PERF-VERSION-FILE with make debug Robert Richter
2011-06-22 9:50 ` Ingo Molnar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®