From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Liam Girdwood <lrg@ti.com>, Tony Lindgren <tony@atomide.com>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Samuel Ortiz <sameo@linux.intel.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org, linux-omap@vger.kernel.org,
linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
Misael Lopez Cruz <misael.lopez@ti.com>,
Peter Ujfalusi <peter.ujfalusi@ti.com>
Subject: [PATCH v6 15/18] ASoC: twl6040: Remove pll and headset mode dependency
Date: Tue, 21 Jun 2011 16:39:13 +0300 [thread overview]
Message-ID: <1308663556-29120-16-git-send-email-peter.ujfalusi@ti.com> (raw)
In-Reply-To: <1308663556-29120-1-git-send-email-peter.ujfalusi@ti.com>
From: Misael Lopez Cruz <misael.lopez@ti.com>
Remove dependency between pll (hppll, lppll) and headset power
mode (low-power, high-performance), as headset power mode can
be used with any pll.
A new control is created to allow headset power mode configuration
from userspace. Changing headset power mode during earpiece related
usecases is not propagated down to the codec as earpiece requires
HS DAC in HP mode.
Signed-off-by: Misael Lopez Cruz <misael.lopez@ti.com>
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
sound/soc/codecs/twl6040.c | 62 ++++++++++++++++++++++++++++++++++++++++---
1 files changed, 57 insertions(+), 5 deletions(-)
diff --git a/sound/soc/codecs/twl6040.c b/sound/soc/codecs/twl6040.c
index 7845cdb..c8f7fc2 100644
--- a/sound/soc/codecs/twl6040.c
+++ b/sound/soc/codecs/twl6040.c
@@ -79,6 +79,8 @@ struct twl6040_data {
int codec_powered;
int pll;
int non_lp;
+ int hs_power_mode;
+ int hs_power_mode_locked;
unsigned int clk_in;
unsigned int sysclk;
struct snd_pcm_hw_constraint_list *sysclk_constraints;
@@ -651,15 +653,26 @@ static int twl6040_power_mode_event(struct snd_soc_dapm_widget *w,
{
struct snd_soc_codec *codec = w->codec;
struct twl6040_data *priv = snd_soc_codec_get_drvdata(codec);
+ int ret = 0;
- if (SND_SOC_DAPM_EVENT_ON(event))
+ if (SND_SOC_DAPM_EVENT_ON(event)) {
priv->non_lp++;
- else
+ if (!strcmp(w->name, "Earphone Driver")) {
+ /* Earphone doesn't support low power mode */
+ priv->hs_power_mode_locked = 1;
+ ret = headset_power_mode(codec, 1);
+ }
+ } else {
priv->non_lp--;
+ if (!strcmp(w->name, "Earphone Driver")) {
+ priv->hs_power_mode_locked = 0;
+ ret = headset_power_mode(codec, priv->hs_power_mode);
+ }
+ }
msleep(1);
- return 0;
+ return ret;
}
static void twl6040_hs_jack_report(struct snd_soc_codec *codec,
@@ -964,6 +977,43 @@ static const struct snd_kcontrol_new hfr_mux_controls =
static const struct snd_kcontrol_new ep_driver_switch_controls =
SOC_DAPM_SINGLE("Switch", TWL6040_REG_EARCTL, 0, 1, 0);
+/* Headset power mode */
+static const char *twl6040_headset_power_texts[] = {
+ "Low-Power", "High-Perfomance",
+};
+
+static const struct soc_enum twl6040_headset_power_enum =
+ SOC_ENUM_SINGLE_EXT(ARRAY_SIZE(twl6040_headset_power_texts),
+ twl6040_headset_power_texts);
+
+static int twl6040_headset_power_get_enum(struct snd_kcontrol *kcontrol,
+ struct snd_ctl_elem_value *ucontrol)
+{
+ struct snd_soc_codec *codec = snd_kcontrol_chip(kcontrol);
+ struct twl6040_data *priv = snd_soc_codec_get_drvdata(codec);
+
+ ucontrol->value.enumerated.item[0] = priv->hs_power_mode;
+
+ return 0;
+}
+
+static int twl6040_headset_power_put_enum(struct snd_kcontrol *kcontrol,
+ struct snd_ctl_elem_value *ucontrol)
+{
+ struct snd_soc_codec *codec = snd_kcontrol_chip(kcontrol);
+ struct twl6040_data *priv = snd_soc_codec_get_drvdata(codec);
+ int high_perf = ucontrol->value.enumerated.item[0];
+ int ret = 0;
+
+ if (!priv->hs_power_mode_locked)
+ ret = headset_power_mode(codec, high_perf);
+
+ if (!ret)
+ priv->hs_power_mode = high_perf;
+
+ return ret;
+}
+
static const struct snd_kcontrol_new twl6040_snd_controls[] = {
/* Capture gains */
SOC_DOUBLE_TLV("Capture Preamplifier Volume",
@@ -982,6 +1032,10 @@ static const struct snd_kcontrol_new twl6040_snd_controls[] = {
TWL6040_REG_HFLGAIN, TWL6040_REG_HFRGAIN, 0, 0x1D, 1, hf_tlv),
SOC_SINGLE_TLV("Earphone Playback Volume",
TWL6040_REG_EARCTL, 1, 0xF, 1, ep_tlv),
+
+ SOC_ENUM_EXT("Headset Power Mode", twl6040_headset_power_enum,
+ twl6040_headset_power_get_enum,
+ twl6040_headset_power_put_enum),
};
static const struct snd_soc_dapm_widget twl6040_dapm_widgets[] = {
@@ -1339,7 +1393,6 @@ static int twl6040_set_dai_sysclk(struct snd_soc_dai *codec_dai,
if (ret)
return ret;
- headset_power_mode(codec, 0);
priv->sysclk_constraints = &lp_constraints;
break;
case TWL6040_SYSCLK_SEL_HPPLL:
@@ -1348,7 +1401,6 @@ static int twl6040_set_dai_sysclk(struct snd_soc_dai *codec_dai,
if (ret)
return ret;
- headset_power_mode(codec, 1);
priv->sysclk_constraints = &hp_constraints;
break;
default:
--
1.7.5.3
next prev parent reply other threads:[~2011-06-21 14:41 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-21 13:38 [PATCH v6 00/18] MFD/ASoC/Input: TWL4030/TWL60X0 changes Peter Ujfalusi
2011-06-21 13:38 ` [PATCH v6 01/18] OMAP: New twl-common for common TWL configuration Peter Ujfalusi
2011-06-21 13:39 ` [PATCH v6 02/18] OMAP4: Move common twl6030 configuration to twl-common Peter Ujfalusi
2011-06-21 13:39 ` [PATCH v6 03/18] OMAP3: Move common twl " Peter Ujfalusi
2011-06-21 13:39 ` [PATCH v6 04/18] OMAP3: Move common regulator " Peter Ujfalusi
2011-06-21 13:39 ` [PATCH v6 05/18] MFD: twl4030-codec: Rename internals from codec to audio Peter Ujfalusi
2011-06-21 13:39 ` [PATCH v6 06/18] MFD: twl4030-codec -> twl4030-audio: Rename the driver Peter Ujfalusi
2011-06-21 13:39 ` [PATCH v6 07/18] MFD: twl4030-audio: Rename platform data Peter Ujfalusi
2011-06-21 13:39 ` [PATCH v6 08/18] mfd: twl6040: Add initial support Peter Ujfalusi
2011-07-04 11:48 ` Samuel Ortiz
2011-07-04 13:11 ` Péter Ujfalusi
2011-07-04 14:08 ` Péter Ujfalusi
2011-07-04 17:39 ` Samuel Ortiz
2011-07-05 9:28 ` Péter Ujfalusi
2011-07-04 12:53 ` Felipe Balbi
2011-07-04 13:09 ` Péter Ujfalusi
2011-07-04 13:27 ` Felipe Balbi
2011-06-21 13:39 ` [PATCH v6 09/18] ASoC: twl6040: Convert into TWL6040 MFD child Peter Ujfalusi
2011-06-21 13:39 ` [PATCH v6 10/18] MFD: twl6040: Change platform data for soc codec driver Peter Ujfalusi
2011-06-21 13:39 ` [PATCH v6 11/18] input: Add initial support for TWL6040 vibrator Peter Ujfalusi
2011-06-21 20:32 ` Dmitry Torokhov
2011-06-22 11:37 ` Péter Ujfalusi
2011-06-21 13:39 ` [PATCH v6 12/18] OMAP4: SDP4430: Add twl6040 vibrator platform support Peter Ujfalusi
2011-06-21 13:39 ` [PATCH v6 13/18] ASoC: twl6040: add all ABE DAIs Peter Ujfalusi
2011-06-21 13:39 ` [PATCH v6 14/18] ASoC: twl6040: Support other sample rates in constraints Peter Ujfalusi
2011-06-21 13:39 ` Peter Ujfalusi [this message]
2011-06-21 17:35 ` [PATCH v6 15/18] ASoC: twl6040: Remove pll and headset mode dependency Mark Brown
2011-06-22 11:39 ` Péter Ujfalusi
2011-06-21 13:39 ` [PATCH v6 16/18] ASoC: twl6040: set default constraints Peter Ujfalusi
2011-06-21 13:39 ` [PATCH v6 17/18] ASoC: twl6040: Configure ramp step based on platform Peter Ujfalusi
2011-06-22 11:25 ` [PATCH v6 18/18] OMAP4: SDP4430: Add twl6040 codec platform support Peter Ujfalusi
2011-06-27 9:43 ` [PATCH v6 00/18] MFD/ASoC/Input: TWL4030/TWL60X0 changes Péter Ujfalusi
2011-06-27 10:18 ` Tony Lindgren
2011-06-27 14:30 ` Péter Ujfalusi
2011-06-28 6:17 ` Tony Lindgren
2011-06-28 6:44 ` Péter Ujfalusi
2011-06-28 6:50 ` Tony Lindgren
2011-07-04 11:51 ` Samuel Ortiz
2011-06-30 6:15 ` Re: [alsa-devel] " Péter Ujfalusi
2011-06-30 8:04 ` Samuel Ortiz
2011-06-30 9:41 ` Péter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1308663556-29120-16-git-send-email-peter.ujfalusi@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=lrg@ti.com \
--cc=misael.lopez@ti.com \
--cc=sameo@linux.intel.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®