mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Guenter Roeck <guenter.roeck@ericsson.com>
To: Fubo Chen <fubo.chen@gmail.com>
Cc: "Stijn Devriendt (sdevrien)" <sdevrien@cisco.com>,
	"khali@linux-fr.org" <khali@linux-fr.org>,
	"lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] Add support for the Philips SA56004 temperature sensor.
Date: Tue, 28 Jun 2011 11:19:48 -0700	[thread overview]
Message-ID: <1309285188.12139.1.camel@groeck-laptop> (raw)
In-Reply-To: <BANLkTim=9ygJScqy12PQXNPBStSgPbpedQ@mail.gmail.com>

On Tue, 2011-06-28 at 13:50 -0400, Fubo Chen wrote:
> On Mon, Jun 27, 2011 at 9:04 AM, Stijn Devriendt (sdevrien)
> <sdevrien@cisco.com> wrote:
> >> On Mon, Jun 6, 2011 at 12:40 PM,  <sdevrien@cisco.com> wrote:
> >> > +       } else
> >> > +       if (man_id == 0xA1) { /*  NXP Semiconductor/Philips */
> >>
> >> No kernel coder writes like this. Has this ever been run through
> >> checkpatch ?
> > It has. Unfortunately this is just the coding style in the whole
> > driver. I believe it's better to have a consistent file rather
> > than 3 different styles.
> 
> Makes sense to me. By the way, it's not forbidden to clean up unusual
> coding style from other developers.
> 
Yes, but as separate patch. Please feel free to submit such a patch.

Thanks,
Guenter



  reply	other threads:[~2011-06-28 18:21 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-06 10:40 sdevrien
2011-06-06 12:40 ` Guenter Roeck
2011-06-24 10:40   ` Stijn Devriendt (sdevrien)
2011-06-24 13:49     ` Guenter Roeck
2011-06-26 19:54 ` Fubo Chen
2011-06-26 20:20   ` Guenter Roeck
2011-06-27  7:04   ` Stijn Devriendt (sdevrien)
2011-06-28 17:50     ` Fubo Chen
2011-06-28 18:19       ` Guenter Roeck [this message]
2011-07-07 11:22   ` Jean Delvare
2011-06-26 20:26 ` [v3] " Guenter Roeck
2011-07-07 11:28   ` Jean Delvare

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1309285188.12139.1.camel@groeck-laptop \
    --to=guenter.roeck@ericsson.com \
    --cc=fubo.chen@gmail.com \
    --cc=khali@linux-fr.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lm-sensors@lm-sensors.org \
    --cc=sdevrien@cisco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®