From: Jean Delvare <khali@linux-fr.org>
To: Fubo Chen <fubo.chen@gmail.com>
Cc: sdevrien@cisco.com, lm-sensors@lm-sensors.org,
linux-kernel@vger.kernel.org, guenter.roeck@ericsson.com
Subject: Re: [PATCH v3] Add support for the Philips SA56004 temperature sensor.
Date: Thu, 7 Jul 2011 13:22:42 +0200 [thread overview]
Message-ID: <20110707132242.0aaff4ea@endymion.delvare> (raw)
In-Reply-To: <BANLkTi=gAqpDNBjCXzvNEhSuzm=3Mg9rVg@mail.gmail.com>
On Sun, 26 Jun 2011 21:54:37 +0200, Fubo Chen wrote:
> On Mon, Jun 6, 2011 at 12:40 PM, <sdevrien@cisco.com> wrote:
> > + } else
> > + if (man_id == 0xA1) { /* NXP Semiconductor/Philips */
>
> No kernel coder writes like this. Has this ever been run through checkpatch ?
Actually, I wrote that code, and I am a kernel coder. You may not like
it, but at the time it seemed the best way to keep the function
readable. This particular style allows for better placement of
comments, which are many in this function.
As long as checkpatch doesn't complain about it, I will not consider
changing it, and will reject any attempt to do so (simply by comparing
the readability before and after the patch and inevitably coming up to
the conclusion that the change isn't worth it.)
--
Jean Delvare
next prev parent reply other threads:[~2011-07-07 11:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-06 10:40 sdevrien
2011-06-06 12:40 ` Guenter Roeck
2011-06-24 10:40 ` Stijn Devriendt (sdevrien)
2011-06-24 13:49 ` Guenter Roeck
2011-06-26 19:54 ` Fubo Chen
2011-06-26 20:20 ` Guenter Roeck
2011-06-27 7:04 ` Stijn Devriendt (sdevrien)
2011-06-28 17:50 ` Fubo Chen
2011-06-28 18:19 ` Guenter Roeck
2011-07-07 11:22 ` Jean Delvare [this message]
2011-06-26 20:26 ` [v3] " Guenter Roeck
2011-07-07 11:28 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110707132242.0aaff4ea@endymion.delvare \
--to=khali@linux-fr.org \
--cc=fubo.chen@gmail.com \
--cc=guenter.roeck@ericsson.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=sdevrien@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome