From: Matthew Auld <matthew.auld@intel.com>
To: cgel.zte@gmail.com, jani.nikula@linux.intel.com
Cc: joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com,
airlied@linux.ie, daniel@ffwll.ch,
thomas.hellstrom@linux.intel.com, chris@chris-wilson.co.uk,
maarten.lankhorst@linux.intel.com, ran.jianping@zte.com.cn,
intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org, Zeal Robot <zealci@zte.com.cn>
Subject: Re: [PATCH] remove duplicate include in mock_region.c
Date: Tue, 19 Oct 2021 10:26:36 +0100 [thread overview]
Message-ID: <130dcbfd-ee6d-0d9a-602f-1aaca1229099@intel.com> (raw)
In-Reply-To: <20211019090205.1003458-1-ran.jianping@zte.com.cn>
On 19/10/2021 10:02, cgel.zte@gmail.com wrote:
> From: Ran Jianping <ran.jianping@zte.com.cn>
>
> 'drm/ttm/ttm_placement.h' included in
> 'drivers/gpu/drm/i915/selftests/mock_region.c' is duplicated.
> It is also included on the 9 line.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Ran Jianping <ran.jianping@zte.com.cn>
Commit tile should ideally be prefixed with 'drm/i915:'.
Can fix up when pushing though. Thanks,
Reviewed-by: Matthew Auld <matthew.auld@intel.com>
> ---
> drivers/gpu/drm/i915/selftests/mock_region.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/selftests/mock_region.c b/drivers/gpu/drm/i915/selftests/mock_region.c
> index efa86dffe3c6..75793008c4ef 100644
> --- a/drivers/gpu/drm/i915/selftests/mock_region.c
> +++ b/drivers/gpu/drm/i915/selftests/mock_region.c
> @@ -6,8 +6,6 @@
> #include <drm/ttm/ttm_placement.h>
> #include <linux/scatterlist.h>
>
> -#include <drm/ttm/ttm_placement.h>
> -
> #include "gem/i915_gem_region.h"
> #include "intel_memory_region.h"
> #include "intel_region_ttm.h"
>
next prev parent reply other threads:[~2021-10-19 9:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-19 9:02 cgel.zte
2021-10-19 9:26 ` Matthew Auld [this message]
2021-10-20 8:04 ` drm/i915: " Ran Jianping
2021-10-20 8:12 ` Matthew Auld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=130dcbfd-ee6d-0d9a-602f-1aaca1229099@intel.com \
--to=matthew.auld@intel.com \
--cc=airlied@linux.ie \
--cc=cgel.zte@gmail.com \
--cc=chris@chris-wilson.co.uk \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=ran.jianping@zte.com.cn \
--cc=rodrigo.vivi@intel.com \
--cc=thomas.hellstrom@linux.intel.com \
--cc=zealci@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®