* [PATCH] remove duplicate include in mock_region.c
@ 2021-10-19 9:02 cgel.zte
2021-10-19 9:26 ` Matthew Auld
0 siblings, 1 reply; 4+ messages in thread
From: cgel.zte @ 2021-10-19 9:02 UTC (permalink / raw)
To: jani.nikula
Cc: joonas.lahtinen, rodrigo.vivi, airlied, daniel, matthew.auld,
thomas.hellstrom, chris, maarten.lankhorst, ran.jianping,
intel-gfx, dri-devel, linux-kernel, Zeal Robot
From: Ran Jianping <ran.jianping@zte.com.cn>
'drm/ttm/ttm_placement.h' included in
'drivers/gpu/drm/i915/selftests/mock_region.c' is duplicated.
It is also included on the 9 line.
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Ran Jianping <ran.jianping@zte.com.cn>
---
drivers/gpu/drm/i915/selftests/mock_region.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/selftests/mock_region.c b/drivers/gpu/drm/i915/selftests/mock_region.c
index efa86dffe3c6..75793008c4ef 100644
--- a/drivers/gpu/drm/i915/selftests/mock_region.c
+++ b/drivers/gpu/drm/i915/selftests/mock_region.c
@@ -6,8 +6,6 @@
#include <drm/ttm/ttm_placement.h>
#include <linux/scatterlist.h>
-#include <drm/ttm/ttm_placement.h>
-
#include "gem/i915_gem_region.h"
#include "intel_memory_region.h"
#include "intel_region_ttm.h"
--
2.25.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] remove duplicate include in mock_region.c
2021-10-19 9:02 [PATCH] remove duplicate include in mock_region.c cgel.zte
@ 2021-10-19 9:26 ` Matthew Auld
2021-10-20 8:04 ` drm/i915: " Ran Jianping
0 siblings, 1 reply; 4+ messages in thread
From: Matthew Auld @ 2021-10-19 9:26 UTC (permalink / raw)
To: cgel.zte, jani.nikula
Cc: joonas.lahtinen, rodrigo.vivi, airlied, daniel, thomas.hellstrom,
chris, maarten.lankhorst, ran.jianping, intel-gfx, dri-devel,
linux-kernel, Zeal Robot
On 19/10/2021 10:02, cgel.zte@gmail.com wrote:
> From: Ran Jianping <ran.jianping@zte.com.cn>
>
> 'drm/ttm/ttm_placement.h' included in
> 'drivers/gpu/drm/i915/selftests/mock_region.c' is duplicated.
> It is also included on the 9 line.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Ran Jianping <ran.jianping@zte.com.cn>
Commit tile should ideally be prefixed with 'drm/i915:'.
Can fix up when pushing though. Thanks,
Reviewed-by: Matthew Auld <matthew.auld@intel.com>
> ---
> drivers/gpu/drm/i915/selftests/mock_region.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/selftests/mock_region.c b/drivers/gpu/drm/i915/selftests/mock_region.c
> index efa86dffe3c6..75793008c4ef 100644
> --- a/drivers/gpu/drm/i915/selftests/mock_region.c
> +++ b/drivers/gpu/drm/i915/selftests/mock_region.c
> @@ -6,8 +6,6 @@
> #include <drm/ttm/ttm_placement.h>
> #include <linux/scatterlist.h>
>
> -#include <drm/ttm/ttm_placement.h>
> -
> #include "gem/i915_gem_region.h"
> #include "intel_memory_region.h"
> #include "intel_region_ttm.h"
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* drm/i915: remove duplicate include in mock_region.c
2021-10-19 9:26 ` Matthew Auld
@ 2021-10-20 8:04 ` Ran Jianping
2021-10-20 8:12 ` Matthew Auld
0 siblings, 1 reply; 4+ messages in thread
From: Ran Jianping @ 2021-10-20 8:04 UTC (permalink / raw)
To: matthew.auld
Cc: airlied, cgel.zte, chris, daniel, dri-devel, intel-gfx,
jani.nikula, joonas.lahtinen, linux-kernel, maarten.lankhorst,
ran.jianping, rodrigo.vivi, thomas.hellstrom, zealci
From: ran jianping <ran.jianping@zte.com.cn>
'drm/ttm/ttm_placement.h' included in
'drivers/gpu/drm/i915/selftests/mock_region.c' is duplicated.
It is also included on the 9 line.
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: ran jianping <ran.jianping@zte.com.cn>
---
drivers/gpu/drm/i915/selftests/mock_region.c | 2 --
1 file changed, 2 deletion(-)
diff --git a/drivers/gpu/drm/i915/selftests/mock_region.c b/drivers/gpu/drm/i915/selftests/mock_region.c
index efa86dffe3c6..b6747b3eeac5 100644
--- a/drivers/gpu/drm/i915/selftests/mock_region.c
+++ b/drivers/gpu/drm/i915/selftests/mock_region.c
@@ -6,7 +6,5 @@
#include <drm/ttm/ttm_placement.h>
#include <linux/scatterlist.h>
-#include <drm/ttm/ttm_placement.h>
-
#include "gem/i915_gem_region.h"
#include "intel_memory_region.h"
--
2.25.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: drm/i915: remove duplicate include in mock_region.c
2021-10-20 8:04 ` drm/i915: " Ran Jianping
@ 2021-10-20 8:12 ` Matthew Auld
0 siblings, 0 replies; 4+ messages in thread
From: Matthew Auld @ 2021-10-20 8:12 UTC (permalink / raw)
To: Ran Jianping
Cc: airlied, chris, daniel, dri-devel, intel-gfx, jani.nikula,
joonas.lahtinen, linux-kernel, maarten.lankhorst, ran.jianping,
rodrigo.vivi, thomas.hellstrom, zealci
On 20/10/2021 09:04, Ran Jianping wrote:
> From: ran jianping <ran.jianping@zte.com.cn>
>
> 'drm/ttm/ttm_placement.h' included in
> 'drivers/gpu/drm/i915/selftests/mock_region.c' is duplicated.
> It is also included on the 9 line.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: ran jianping <ran.jianping@zte.com.cn>
Pushed to drm-intel-gt-next. Thanks.
> ---
> drivers/gpu/drm/i915/selftests/mock_region.c | 2 --
> 1 file changed, 2 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/selftests/mock_region.c b/drivers/gpu/drm/i915/selftests/mock_region.c
> index efa86dffe3c6..b6747b3eeac5 100644
> --- a/drivers/gpu/drm/i915/selftests/mock_region.c
> +++ b/drivers/gpu/drm/i915/selftests/mock_region.c
> @@ -6,7 +6,5 @@
> #include <drm/ttm/ttm_placement.h>
> #include <linux/scatterlist.h>
>
> -#include <drm/ttm/ttm_placement.h>
> -
> #include "gem/i915_gem_region.h"
> #include "intel_memory_region.h"
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-10-20 8:12 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-19 9:02 [PATCH] remove duplicate include in mock_region.c cgel.zte
2021-10-19 9:26 ` Matthew Auld
2021-10-20 8:04 ` drm/i915: " Ran Jianping
2021-10-20 8:12 ` Matthew Auld
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®