mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH 2/3] uml: drivers/slip_user.c memory leak fix
@ 2011-07-07 16:36 Vitaliy Ivanov
  0 siblings, 0 replies; only message in thread
From: Vitaliy Ivanov @ 2011-07-07 16:36 UTC (permalink / raw)
  To: Jeff Dike, Richard Weinberger; +Cc: user-mode-linux-devel, LKML, vitalivanov

>From d4f92205b89eedb5054091b9fc0e0186e9acd88b Mon Sep 17 00:00:00 2001
From: Vitaliy Ivanov <vitalivanov@gmail.com>
Date: Thu, 7 Jul 2011 19:27:32 +0300
Subject: [PATCH 2/3] uml: drivers/slip_user.c memory leak fix

Do not free memory when you failed to allocate it.

Signed-off-by: Vitaliy Ivanov <vitalivanov@gmail.com>
---
 arch/um/drivers/slip_user.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/arch/um/drivers/slip_user.c b/arch/um/drivers/slip_user.c
index a1c2d2c..cbacfc4 100644
--- a/arch/um/drivers/slip_user.c
+++ b/arch/um/drivers/slip_user.c
@@ -102,7 +102,7 @@ static int slip_tramp(char **argv, int fd)
 		       "buffer\n");
 		os_kill_process(pid, 1);
 		err = -ENOMEM;
-		goto out_free;
+		goto out_close;
 	}
 
 	close(fds[1]);
@@ -112,7 +112,6 @@ static int slip_tramp(char **argv, int fd)
 	err = helper_wait(pid);
 	close(fds[0]);
 
-out_free:
 	kfree(output);
 	return err;
 
-- 
1.7.0.4




^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2011-07-07 16:35 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-07-07 16:36 [PATCH 2/3] uml: drivers/slip_user.c memory leak fix Vitaliy Ivanov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome