* [PATCH] kconfig/nconf: remove useless conditionnal
@ 2011-07-10 7:27 Arnaud Lacombe
2011-07-18 18:11 ` Arnaud Lacombe
0 siblings, 1 reply; 3+ messages in thread
From: Arnaud Lacombe @ 2011-07-10 7:27 UTC (permalink / raw)
To: linux-kbuild, Michal Marek; +Cc: linux-kernel, Arnaud Lacombe, Nir Tzachar
After the test
if (!submenu || ...)
continue;
the variable `submenu' can _not_ be NULL, so do not test for this situation.
Cc: Nir Tzachar <nir.tzachar@gmail.com>
Signed-off-by: Arnaud Lacombe <lacombar@gmail.com>
---
scripts/kconfig/nconf.c | 5 +----
1 files changed, 1 insertions(+), 4 deletions(-)
diff --git a/scripts/kconfig/nconf.c b/scripts/kconfig/nconf.c
index eb9e49d..6b189c8 100644
--- a/scripts/kconfig/nconf.c
+++ b/scripts/kconfig/nconf.c
@@ -1155,10 +1155,7 @@ static void conf(struct menu *menu)
active_menu = (struct menu *)item_data();
if (!submenu || !menu_is_visible(submenu))
continue;
- if (submenu)
- sym = submenu->sym;
- else
- sym = NULL;
+ sym = submenu->sym;
switch (res) {
case ' ':
--
1.7.3.4.574.g608b.dirty
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] kconfig/nconf: remove useless conditionnal
2011-07-10 7:27 [PATCH] kconfig/nconf: remove useless conditionnal Arnaud Lacombe
@ 2011-07-18 18:11 ` Arnaud Lacombe
2011-07-21 5:08 ` Américo Wang
0 siblings, 1 reply; 3+ messages in thread
From: Arnaud Lacombe @ 2011-07-18 18:11 UTC (permalink / raw)
To: linux-kbuild, Michal Marek; +Cc: linux-kernel, Arnaud Lacombe, Nir Tzachar
Hi,
On Sun, Jul 10, 2011 at 3:27 AM, Arnaud Lacombe <lacombar@gmail.com> wrote:
> After the test
>
> if (!submenu || ...)
> continue;
>
> the variable `submenu' can _not_ be NULL, so do not test for this situation.
>
> Cc: Nir Tzachar <nir.tzachar@gmail.com>
> Signed-off-by: Arnaud Lacombe <lacombar@gmail.com>
> ---
> scripts/kconfig/nconf.c | 5 +----
> 1 files changed, 1 insertions(+), 4 deletions(-)
>
> diff --git a/scripts/kconfig/nconf.c b/scripts/kconfig/nconf.c
> index eb9e49d..6b189c8 100644
> --- a/scripts/kconfig/nconf.c
> +++ b/scripts/kconfig/nconf.c
> @@ -1155,10 +1155,7 @@ static void conf(struct menu *menu)
> active_menu = (struct menu *)item_data();
> if (!submenu || !menu_is_visible(submenu))
> continue;
> - if (submenu)
> - sym = submenu->sym;
> - else
> - sym = NULL;
> + sym = submenu->sym;
>
> switch (res) {
> case ' ':
Michal, ping ?
- Arnaud
> --
> 1.7.3.4.574.g608b.dirty
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] kconfig/nconf: remove useless conditionnal
2011-07-18 18:11 ` Arnaud Lacombe
@ 2011-07-21 5:08 ` Américo Wang
0 siblings, 0 replies; 3+ messages in thread
From: Américo Wang @ 2011-07-21 5:08 UTC (permalink / raw)
To: Arnaud Lacombe; +Cc: linux-kbuild, Michal Marek, linux-kernel, Nir Tzachar
On Tue, Jul 19, 2011 at 2:11 AM, Arnaud Lacombe <lacombar@gmail.com> wrote:
> Hi,
>
> On Sun, Jul 10, 2011 at 3:27 AM, Arnaud Lacombe <lacombar@gmail.com> wrote:
>> After the test
>>
>> if (!submenu || ...)
>> continue;
>>
>> the variable `submenu' can _not_ be NULL, so do not test for this situation.
>>
Yeah, looks good.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-07-21 5:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-07-10 7:27 [PATCH] kconfig/nconf: remove useless conditionnal Arnaud Lacombe
2011-07-18 18:11 ` Arnaud Lacombe
2011-07-21 5:08 ` Américo Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®