From: Joe Perches <joe@perches.com>
To: linux-kernel@vger.kernel.org
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.de>,
alsa-devel@alsa-project.org
Subject: Re: [PATCH 5/5] dbri: Add missing breaks in switch/case
Date: Sun, 10 Jul 2011 07:36:37 -0700 [thread overview]
Message-ID: <1310308597.3848.21.camel@Joe-Laptop> (raw)
In-Reply-To: <5aa8ee111dd52768622e89c06440e1328f0d2247.1310289795.git.joe@perches.com>
On Sun, 2011-07-10 at 02:28 -0700, Joe Perches wrote:
defective patch, please ignore.
> diff --git a/sound/sparc/dbri.c b/sound/sparc/dbri.c
> index 73f9cba..ca978b1 100644
> --- a/sound/sparc/dbri.c
> +++ b/sound/sparc/dbri.c
> @@ -578,14 +578,19 @@ static __u32 reverse_bytes(__u32 b, int len)
> switch (len) {
> case 32:
> b = ((b & 0xffff0000) >> 16) | ((b & 0x0000ffff) << 16);
> + break;
Maybe add a comment for fall through use instead.
prev parent reply other threads:[~2011-07-10 14:36 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-10 9:28 [PATCH 0/5] treewide: " Joe Perches
2011-07-10 9:28 ` [PATCH 1/5] gpio-tps65910.c: " Joe Perches
2011-07-10 10:47 ` Grant Likely
2011-07-10 9:28 ` [PATCH 2/5] tps65910-irq: " Joe Perches
2011-07-10 9:28 ` [PATCH 3/5] ath5k: " Joe Perches
2011-07-11 15:50 ` [ath5k-devel] " Pavel Roskin
2011-07-11 21:24 ` Nick Kossifidis
2011-07-10 9:28 ` [PATCH 4/5] fusb300_udc: " Joe Perches
2011-07-11 6:39 ` Felipe Balbi
2011-07-14 8:08 ` Sebastian Andrzej Siewior
2011-07-14 8:36 ` Wendy Yuan-Hsin Chen(陳元馨)
2011-07-14 10:36 ` Sebastian Andrzej Siewior
2011-07-14 13:28 ` Wendy Yuan-Hsin Chen(陳元馨)
2011-07-18 8:36 ` Felipe Balbi
2011-07-18 12:54 ` Wendy Yuan-Hsin Chen(陳元馨)
2011-07-19 19:47 ` [PATCH] usb/fusb300: remove #if 0 block Sebastian Andrzej Siewior
2011-07-26 14:52 ` Felipe Balbi
2011-07-10 9:28 ` [PATCH 5/5] dbri: Add missing breaks in switch/case Joe Perches
2011-07-10 14:36 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1310308597.3848.21.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome