* [PATCH 2/2] Staging: comedi: fix brace coding style issue in pcl818.c
[not found] <[PATCH 2/2]Staging: comedi: fix brace coding style issue in pcl818.c>
@ 2011-07-11 5:40 ` Ravishankar
2011-07-11 5:59 ` [PATCH] hid-multitouch driver: add one new hid multitouch device's VID/PID Ice.Chien
0 siblings, 1 reply; 6+ messages in thread
From: Ravishankar @ 2011-07-11 5:40 UTC (permalink / raw)
To: gregkh, wfp5p; +Cc: devel, linux-kernel, Ravishankar, Ravishankar
From: Ravishankar <ravi.shankar@greenturtles.in>
This is a patch to the pcl818.c file that fixes up a brace warning found by the checkpatch.pl tool
Signed-off-by: Ravishankar <ravishankarkm32@gmail.com>
---
drivers/staging/comedi/drivers/pcl818.c | 15 +++++----------
1 files changed, 5 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/comedi/drivers/pcl818.c b/drivers/staging/comedi/drivers/pcl818.c
index 6a7fa42..a42148e 100644
--- a/drivers/staging/comedi/drivers/pcl818.c
+++ b/drivers/staging/comedi/drivers/pcl818.c
@@ -463,9 +463,8 @@ static int pcl818_ao_insn_read(struct comedi_device *dev,
int n;
int chan = CR_CHAN(insn->chanspec);
- for (n = 0; n < insn->n; n++) {
+ for (n = 0; n < insn->n; n++)
data[n] = devpriv->ao_readback[chan];
- }
return n;
}
@@ -824,9 +823,8 @@ static irqreturn_t interrupt_pcl818_ai_mode13_fifo(int irq, void *d)
comedi_buf_put(s->async, (lo >> 4) | (inb(dev->iobase + PCL818_FI_DATAHI) << 4)); /* get one sample */
devpriv->act_chanlist_pos++;
- if (devpriv->act_chanlist_pos >= devpriv->act_chanlist_len) {
+ if (devpriv->act_chanlist_pos >= devpriv->act_chanlist_len)
devpriv->act_chanlist_pos = 0;
- }
s->async->cur_chan++;
if (s->async->cur_chan >= devpriv->ai_n_chan) {
s->async->cur_chan = 0;
@@ -1056,17 +1054,14 @@ static int pcl818_ai_cmd_mode(int mode, struct comedi_device *dev,
switch (devpriv->dma) {
case 1: /* DMA */
case 3:
- if (devpriv->dma_rtc == 0) {
+ if (devpriv->dma_rtc == 0)
pcl818_ai_mode13dma_int(mode, dev, s);
- }
#ifdef unused
- else {
+ else
pcl818_ai_mode13dma_rtc(mode, dev, s);
- }
#else
- else {
+ else
return -EINVAL;
- }
#endif
break;
case 0:
--
1.6.5.2
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] hid-multitouch driver: add one new hid multitouch device's VID/PID
2011-07-11 5:40 ` [PATCH 2/2] Staging: comedi: fix brace coding style issue in pcl818.c Ravishankar
@ 2011-07-11 5:59 ` Ice.Chien
2011-07-11 6:51 ` Benjamin Tissoires
2011-07-11 15:19 ` Jiri Kosina
0 siblings, 2 replies; 6+ messages in thread
From: Ice.Chien @ 2011-07-11 5:59 UTC (permalink / raw)
To: linux-kernel; +Cc: benjamin.tissoires, Jonson Wu
This is a patch to add one hid multitouch device's VID/PID in hid-ids.h
and hid-core.c
Signed-off-by: Ice Chien <ice.chien@accupoint.com.tw>
---
diff -u ./linux-2.6.39.3/drivers/hid//hid-core.c
./modified/drivers/hid//hid-core.c
--- ./linux-2.6.39.3/drivers/hid//hid-core.c 2011-07-09
14:16:06.000000000 +0800
+++ ./modified/drivers/hid//hid-core.c 2011-07-11 13:36:07.784957908
+0800
@@ -1482,6 +1482,7 @@
{ HID_USB_DEVICE(USB_VENDOR_ID_WALTOP,
USB_DEVICE_ID_WALTOP_SLIM_TABLET_12_1_INCH) },
{ HID_USB_DEVICE(USB_VENDOR_ID_WALTOP,
USB_DEVICE_ID_WALTOP_MEDIA_TABLET_10_6_INCH) },
{ HID_USB_DEVICE(USB_VENDOR_ID_WALTOP,
USB_DEVICE_ID_WALTOP_MEDIA_TABLET_14_1_INCH) },
+ { HID_USB_DEVICE(USB_VENDOR_ID_XAT, USB_DEVICE_ID_XAT_CSR) },
{ HID_USB_DEVICE(USB_VENDOR_ID_ZEROPLUS, 0x0005) },
{ HID_USB_DEVICE(USB_VENDOR_ID_ZEROPLUS, 0x0030) },
{ HID_USB_DEVICE(USB_VENDOR_ID_ZYDACRON,
USB_DEVICE_ID_ZYDACRON_REMOTE_CONTROL) },
diff -u ./linux-2.6.39.3/drivers/hid//hid-ids.h
./modified/drivers/hid//hid-ids.h
--- ./linux-2.6.39.3/drivers/hid//hid-ids.h 2011-07-09
14:16:06.000000000 +0800
+++ ./modified/drivers/hid//hid-ids.h 2011-07-11 13:36:05.969865971
+0800
@@ -607,6 +607,9 @@
#define USB_VENDOR_ID_WISEGROUP_LTD2 0x6677
#define USB_DEVICE_ID_SMARTJOY_DUAL_PLUS 0x8802
+#define USB_VENDOR_ID_XAT 0x2505
+#define USB_DEVICE_ID_XAT_CSR 0x0220
+
#define USB_VENDOR_ID_YEALINK 0x6993
#define USB_DEVICE_ID_YEALINK_P1K_P4K_B2K 0xb001
Common subdirectories: ./linux-2.6.39.3/drivers/hid//usbhid and
./modified/drivers/hid//usbhid
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] hid-multitouch driver: add one new hid multitouch device's VID/PID
2011-07-11 5:59 ` [PATCH] hid-multitouch driver: add one new hid multitouch device's VID/PID Ice.Chien
@ 2011-07-11 6:51 ` Benjamin Tissoires
2011-07-12 2:46 ` Ice.Chien
2011-07-11 15:19 ` Jiri Kosina
1 sibling, 1 reply; 6+ messages in thread
From: Benjamin Tissoires @ 2011-07-11 6:51 UTC (permalink / raw)
To: Ice.Chien
Cc: linux-kernel, Jonson Wu, linux-input, Jiri Kosina,
Dmitry Torokhov, Henrik Rydberg, Stéphane Chatty
Hi,
adding in CC the input list and the maintainers ;-)
Though the patch is clean (except that you should replace spaces by
tabs of 8 chars, I will mention it inlined in the patch), don't you
want to also add your device to the hid-multitouch driver?
If it's the case (we can still add it from the user space, but it will
not work out of the box for everybody), please also add it to
hid-multitouch and to the HID_MULTITOUCH section in the Kconfig file.
Thanks for the work.
On Mon, Jul 11, 2011 at 07:59, Ice.Chien <ice.chien@accupoint.com.tw> wrote:
> This is a patch to add one hid multitouch device's VID/PID in hid-ids.h
> and hid-core.c
>
> Signed-off-by: Ice Chien <ice.chien@accupoint.com.tw>
> ---
> diff -u ./linux-2.6.39.3/drivers/hid//hid-core.c
> ./modified/drivers/hid//hid-core.c
> --- ./linux-2.6.39.3/drivers/hid//hid-core.c 2011-07-09
> 14:16:06.000000000 +0800
> +++ ./modified/drivers/hid//hid-core.c 2011-07-11 13:36:07.784957908
> +0800
> @@ -1482,6 +1482,7 @@
> { HID_USB_DEVICE(USB_VENDOR_ID_WALTOP,
> USB_DEVICE_ID_WALTOP_SLIM_TABLET_12_1_INCH) },
> { HID_USB_DEVICE(USB_VENDOR_ID_WALTOP,
> USB_DEVICE_ID_WALTOP_MEDIA_TABLET_10_6_INCH) },
> { HID_USB_DEVICE(USB_VENDOR_ID_WALTOP,
> USB_DEVICE_ID_WALTOP_MEDIA_TABLET_14_1_INCH) },
> + { HID_USB_DEVICE(USB_VENDOR_ID_XAT, USB_DEVICE_ID_XAT_CSR) },
replace leading spaces by tabs here
> { HID_USB_DEVICE(USB_VENDOR_ID_ZEROPLUS, 0x0005) },
> { HID_USB_DEVICE(USB_VENDOR_ID_ZEROPLUS, 0x0030) },
> { HID_USB_DEVICE(USB_VENDOR_ID_ZYDACRON,
> USB_DEVICE_ID_ZYDACRON_REMOTE_CONTROL) },
> diff -u ./linux-2.6.39.3/drivers/hid//hid-ids.h
> ./modified/drivers/hid//hid-ids.h
> --- ./linux-2.6.39.3/drivers/hid//hid-ids.h 2011-07-09
> 14:16:06.000000000 +0800
> +++ ./modified/drivers/hid//hid-ids.h 2011-07-11 13:36:05.969865971
> +0800
> @@ -607,6 +607,9 @@
> #define USB_VENDOR_ID_WISEGROUP_LTD2 0x6677
> #define USB_DEVICE_ID_SMARTJOY_DUAL_PLUS 0x8802
>
> +#define USB_VENDOR_ID_XAT 0x2505
replace spaces by tabs
> +#define USB_DEVICE_ID_XAT_CSR 0x0220
again ;-)
Cheers,
Benjamin
> +
> #define USB_VENDOR_ID_YEALINK 0x6993
> #define USB_DEVICE_ID_YEALINK_P1K_P4K_B2K 0xb001
>
> Common subdirectories: ./linux-2.6.39.3/drivers/hid//usbhid and
> ./modified/drivers/hid//usbhid
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] hid-multitouch driver: add one new hid multitouch device's VID/PID
2011-07-11 5:59 ` [PATCH] hid-multitouch driver: add one new hid multitouch device's VID/PID Ice.Chien
2011-07-11 6:51 ` Benjamin Tissoires
@ 2011-07-11 15:19 ` Jiri Kosina
1 sibling, 0 replies; 6+ messages in thread
From: Jiri Kosina @ 2011-07-11 15:19 UTC (permalink / raw)
To: Ice.Chien; +Cc: linux-kernel, benjamin.tissoires, Jonson Wu
On Mon, 11 Jul 2011, Ice.Chien wrote:
> This is a patch to add one hid multitouch device's VID/PID in hid-ids.h
> and hid-core.c
>
> Signed-off-by: Ice Chien <ice.chien@accupoint.com.tw>
> ---
> diff -u ./linux-2.6.39.3/drivers/hid//hid-core.c
> ./modified/drivers/hid//hid-core.c
> --- ./linux-2.6.39.3/drivers/hid//hid-core.c 2011-07-09
> 14:16:06.000000000 +0800
> +++ ./modified/drivers/hid//hid-core.c 2011-07-11 13:36:07.784957908
> +0800
> @@ -1482,6 +1482,7 @@
> { HID_USB_DEVICE(USB_VENDOR_ID_WALTOP,
> USB_DEVICE_ID_WALTOP_SLIM_TABLET_12_1_INCH) },
> { HID_USB_DEVICE(USB_VENDOR_ID_WALTOP,
> USB_DEVICE_ID_WALTOP_MEDIA_TABLET_10_6_INCH) },
> { HID_USB_DEVICE(USB_VENDOR_ID_WALTOP,
> USB_DEVICE_ID_WALTOP_MEDIA_TABLET_14_1_INCH) },
> + { HID_USB_DEVICE(USB_VENDOR_ID_XAT, USB_DEVICE_ID_XAT_CSR) },
> { HID_USB_DEVICE(USB_VENDOR_ID_ZEROPLUS, 0x0005) },
> { HID_USB_DEVICE(USB_VENDOR_ID_ZEROPLUS, 0x0030) },
> { HID_USB_DEVICE(USB_VENDOR_ID_ZYDACRON,
> USB_DEVICE_ID_ZYDACRON_REMOTE_CONTROL) },
> diff -u ./linux-2.6.39.3/drivers/hid//hid-ids.h
> ./modified/drivers/hid//hid-ids.h
> --- ./linux-2.6.39.3/drivers/hid//hid-ids.h 2011-07-09
> 14:16:06.000000000 +0800
> +++ ./modified/drivers/hid//hid-ids.h 2011-07-11 13:36:05.969865971
> +0800
> @@ -607,6 +607,9 @@
> #define USB_VENDOR_ID_WISEGROUP_LTD2 0x6677
> #define USB_DEVICE_ID_SMARTJOY_DUAL_PLUS 0x8802
>
> +#define USB_VENDOR_ID_XAT 0x2505
> +#define USB_DEVICE_ID_XAT_CSR 0x0220
> +
> #define USB_VENDOR_ID_YEALINK 0x6993
> #define USB_DEVICE_ID_YEALINK_P1K_P4K_B2K 0xb001
>
> Common subdirectories: ./linux-2.6.39.3/drivers/hid//usbhid and
> ./modified/drivers/hid//usbhid
Hi,
first, your patch is line-wrapped and whitespace damaged. Please fix your
mailclient (*) for your future (re-)submissions.
Second, the patch seems incomplete. You probably want some specific driver
(persumably hid-multitouch?) to claim the device.
(*) see Documentation/email-clients.txt for details.
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] hid-multitouch driver: add one new hid multitouch device's VID/PID
2011-07-11 6:51 ` Benjamin Tissoires
@ 2011-07-12 2:46 ` Ice.Chien
2011-07-13 19:41 ` Benjamin Tissoires
0 siblings, 1 reply; 6+ messages in thread
From: Ice.Chien @ 2011-07-12 2:46 UTC (permalink / raw)
To: Benjamin Tissoires
Cc: linux-kernel, Jonson Wu, linux-input, Jiri Kosina,
Dmitry Torokhov, Henrik Rydberg, Stéphane Chatty
Hi Benjamin,
This is a patch to add one hid multitouch device's VID/PID in hid-core.c, hid-ids.h, hid-multitouch.c and Kconfig.
Please review if I make the correct change
Thanks.
Signed-off-by: Ice Chien <ice.chien@accupoint.com.tw>
---
diff -u ./linux-2.6.39.3/drivers/hid//hid-core.c ./modified/drivers/hid//hid-core.c
--- ./linux-2.6.39.3/drivers/hid//hid-core.c 2011-07-09 14:16:06.000000000 +0800
+++ ./modified/drivers/hid//hid-core.c 2011-07-11 13:36:07.784957908 +0800
@@ -1482,6 +1482,7 @@
{ HID_USB_DEVICE(USB_VENDOR_ID_WALTOP, USB_DEVICE_ID_WALTOP_SLIM_TABLET_12_1_INCH) },
{ HID_USB_DEVICE(USB_VENDOR_ID_WALTOP, USB_DEVICE_ID_WALTOP_MEDIA_TABLET_10_6_INCH) },
{ HID_USB_DEVICE(USB_VENDOR_ID_WALTOP, USB_DEVICE_ID_WALTOP_MEDIA_TABLET_14_1_INCH) },
+ { HID_USB_DEVICE(USB_VENDOR_ID_XAT, USB_DEVICE_ID_XAT_CSR) },
{ HID_USB_DEVICE(USB_VENDOR_ID_ZEROPLUS, 0x0005) },
{ HID_USB_DEVICE(USB_VENDOR_ID_ZEROPLUS, 0x0030) },
{ HID_USB_DEVICE(USB_VENDOR_ID_ZYDACRON, USB_DEVICE_ID_ZYDACRON_REMOTE_CONTROL) },
Diff -u ./linux-2.6.39.3/drivers/hid//hid-ids.h ./modified/drivers/hid//hid-ids.h
--- ./linux-2.6.39.3/drivers/hid//hid-ids.h 2011-07-09 14:16:06.000000000 +0800
+++ ./modified/drivers/hid//hid-ids.h 2011-07-11 13:36:05.969865971 +0800
@@ -607,6 +607,9 @@
#define USB_VENDOR_ID_WISEGROUP_LTD2 0x6677
#define USB_DEVICE_ID_SMARTJOY_DUAL_PLUS 0x8802
+#define USB_VENDOR_ID_XAT 0x2505
+#define USB_DEVICE_ID_XAT_CSR 0x0220
+
#define USB_VENDOR_ID_YEALINK 0x6993
#define USB_DEVICE_ID_YEALINK_P1K_P4K_B2K 0xb001
Diff -u ./linux-2.6.39.3/drivers/hid//hid-multitouch.c ./modified/drivers/hid//hid-multitouch.c
--- ./linux-2.6.39.3/drivers/hid//hid-multitouch.c 2011-07-09 14:16:06.000000000 +0800
+++ ./modified/drivers/hid//hid-multitouch.c 2011-07-12 10:07:46.505165622 +0800
@@ -487,6 +487,10 @@
}
Static const struct hid_device_id mt_devices[] = {
+ /* XAT */
+ { .driver_data = MT_CLS_DEFAULT,
+ HID_USB_DEVICE(USB_VENDOR_ID_XAT,
+ USB_DEVICE_ID_XAT_CSR) },
/* Cypress panel */
{ .driver_data = MT_CLS_CYPRESS,
Diff -u ./linux-2.6.39.3/drivers/hid//Kconfig ./modified/drivers/hid//Kconfig
--- ./linux-2.6.39.3/drivers/hid//Kconfig 2011-07-09 14:16:06.000000000 +0800
+++ ./modified/drivers/hid//Kconfig 2011-07-12 10:08:33.617597671 +0800
@@ -327,6 +327,7 @@
- 'Sensing Win7-TwoFinger' panel by GeneralTouch
- eGalax dual-touch panels, including the
Joojoo and Wetab tablets
+ - XAT optical touch panels
If unsure, say N.
Common subdirectories: ./linux-2.6.39.3/drivers/hid//usbhid and ./modified/drivers/hid//usbhid
-----Original Message-----
From: benjamin.tissoires@gmail.com [mailto:benjamin.tissoires@gmail.com] On Behalf Of Benjamin Tissoires
Sent: Monday, July 11, 2011 2:52 PM
To: Ice.Chien
Cc: linux-kernel@vger.kernel.org; Jonson Wu; linux-input; Jiri Kosina; Dmitry Torokhov; Henrik Rydberg; Stéphane Chatty
Subject: Re: [PATCH] hid-multitouch driver: add one new hid multitouch device's VID/PID
Hi,
adding in CC the input list and the maintainers ;-)
Though the patch is clean (except that you should replace spaces by
tabs of 8 chars, I will mention it inlined in the patch), don't you
want to also add your device to the hid-multitouch driver?
If it's the case (we can still add it from the user space, but it will
not work out of the box for everybody), please also add it to
hid-multitouch and to the HID_MULTITOUCH section in the Kconfig file.
Thanks for the work.
On Mon, Jul 11, 2011 at 07:59, Ice.Chien <ice.chien@accupoint.com.tw> wrote:
> This is a patch to add one hid multitouch device's VID/PID in hid-ids.h
> and hid-core.c
>
> Signed-off-by: Ice Chien <ice.chien@accupoint.com.tw>
> ---
> diff -u ./linux-2.6.39.3/drivers/hid//hid-core.c
> ./modified/drivers/hid//hid-core.c
> --- ./linux-2.6.39.3/drivers/hid//hid-core.c 2011-07-09
> 14:16:06.000000000 +0800
> +++ ./modified/drivers/hid//hid-core.c 2011-07-11 13:36:07.784957908
> +0800
> @@ -1482,6 +1482,7 @@
> { HID_USB_DEVICE(USB_VENDOR_ID_WALTOP,
> USB_DEVICE_ID_WALTOP_SLIM_TABLET_12_1_INCH) },
> { HID_USB_DEVICE(USB_VENDOR_ID_WALTOP,
> USB_DEVICE_ID_WALTOP_MEDIA_TABLET_10_6_INCH) },
> { HID_USB_DEVICE(USB_VENDOR_ID_WALTOP,
> USB_DEVICE_ID_WALTOP_MEDIA_TABLET_14_1_INCH) },
> + { HID_USB_DEVICE(USB_VENDOR_ID_XAT, USB_DEVICE_ID_XAT_CSR) },
replace leading spaces by tabs here
> { HID_USB_DEVICE(USB_VENDOR_ID_ZEROPLUS, 0x0005) },
> { HID_USB_DEVICE(USB_VENDOR_ID_ZEROPLUS, 0x0030) },
> { HID_USB_DEVICE(USB_VENDOR_ID_ZYDACRON,
> USB_DEVICE_ID_ZYDACRON_REMOTE_CONTROL) },
> diff -u ./linux-2.6.39.3/drivers/hid//hid-ids.h
> ./modified/drivers/hid//hid-ids.h
> --- ./linux-2.6.39.3/drivers/hid//hid-ids.h 2011-07-09
> 14:16:06.000000000 +0800
> +++ ./modified/drivers/hid//hid-ids.h 2011-07-11 13:36:05.969865971
> +0800
> @@ -607,6 +607,9 @@
> #define USB_VENDOR_ID_WISEGROUP_LTD2 0x6677
> #define USB_DEVICE_ID_SMARTJOY_DUAL_PLUS 0x8802
>
> +#define USB_VENDOR_ID_XAT 0x2505
replace spaces by tabs
> +#define USB_DEVICE_ID_XAT_CSR 0x0220
again ;-)
Cheers,
Benjamin
> +
> #define USB_VENDOR_ID_YEALINK 0x6993
> #define USB_DEVICE_ID_YEALINK_P1K_P4K_B2K 0xb001
>
> Common subdirectories: ./linux-2.6.39.3/drivers/hid//usbhid and
> ./modified/drivers/hid//usbhid
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] hid-multitouch driver: add one new hid multitouch device's VID/PID
2011-07-12 2:46 ` Ice.Chien
@ 2011-07-13 19:41 ` Benjamin Tissoires
0 siblings, 0 replies; 6+ messages in thread
From: Benjamin Tissoires @ 2011-07-13 19:41 UTC (permalink / raw)
To: Ice.Chien
Cc: linux-kernel, Jonson Wu, linux-input, Jiri Kosina,
Dmitry Torokhov, Henrik Rydberg, Stéphane Chatty
Hi,
the patch looks good in terms of functionality. However there is still
a problem in the format introduced by your mail client.
As mentioned by Jiri, you'll find some answers in the file
Documentation/email-clients.txt at the root of the kernel tree (or
directly at http://git.kernel.org/?p=linux/kernel/git/next/linux-next.git;a=blob_plain;f=Documentation/email-clients.txt;hb=HEAD).
Basically copy/paste usually doesn't work.
If you still have problem in formatting the mail, you can also send me
the patch in private and I'll send it for you.
Cheers,
Benjamin
On Tue, Jul 12, 2011 at 04:46, Ice.Chien <ice.chien@accupoint.com.tw> wrote:
> Hi Benjamin,
>
> This is a patch to add one hid multitouch device's VID/PID in hid-core.c, hid-ids.h, hid-multitouch.c and Kconfig.
> Please review if I make the correct change
> Thanks.
>
> Signed-off-by: Ice Chien <ice.chien@accupoint.com.tw>
> ---
> diff -u ./linux-2.6.39.3/drivers/hid//hid-core.c ./modified/drivers/hid//hid-core.c
> --- ./linux-2.6.39.3/drivers/hid//hid-core.c 2011-07-09 14:16:06.000000000 +0800
> +++ ./modified/drivers/hid//hid-core.c 2011-07-11 13:36:07.784957908 +0800
> @@ -1482,6 +1482,7 @@
> { HID_USB_DEVICE(USB_VENDOR_ID_WALTOP, USB_DEVICE_ID_WALTOP_SLIM_TABLET_12_1_INCH) },
> { HID_USB_DEVICE(USB_VENDOR_ID_WALTOP, USB_DEVICE_ID_WALTOP_MEDIA_TABLET_10_6_INCH) },
> { HID_USB_DEVICE(USB_VENDOR_ID_WALTOP, USB_DEVICE_ID_WALTOP_MEDIA_TABLET_14_1_INCH) },
> + { HID_USB_DEVICE(USB_VENDOR_ID_XAT, USB_DEVICE_ID_XAT_CSR) },
> { HID_USB_DEVICE(USB_VENDOR_ID_ZEROPLUS, 0x0005) },
> { HID_USB_DEVICE(USB_VENDOR_ID_ZEROPLUS, 0x0030) },
> { HID_USB_DEVICE(USB_VENDOR_ID_ZYDACRON, USB_DEVICE_ID_ZYDACRON_REMOTE_CONTROL) },
> Diff -u ./linux-2.6.39.3/drivers/hid//hid-ids.h ./modified/drivers/hid//hid-ids.h
> --- ./linux-2.6.39.3/drivers/hid//hid-ids.h 2011-07-09 14:16:06.000000000 +0800
> +++ ./modified/drivers/hid//hid-ids.h 2011-07-11 13:36:05.969865971 +0800
> @@ -607,6 +607,9 @@
> #define USB_VENDOR_ID_WISEGROUP_LTD2 0x6677
> #define USB_DEVICE_ID_SMARTJOY_DUAL_PLUS 0x8802
>
> +#define USB_VENDOR_ID_XAT 0x2505
> +#define USB_DEVICE_ID_XAT_CSR 0x0220
> +
> #define USB_VENDOR_ID_YEALINK 0x6993
> #define USB_DEVICE_ID_YEALINK_P1K_P4K_B2K 0xb001
>
> Diff -u ./linux-2.6.39.3/drivers/hid//hid-multitouch.c ./modified/drivers/hid//hid-multitouch.c
> --- ./linux-2.6.39.3/drivers/hid//hid-multitouch.c 2011-07-09 14:16:06.000000000 +0800
> +++ ./modified/drivers/hid//hid-multitouch.c 2011-07-12 10:07:46.505165622 +0800
> @@ -487,6 +487,10 @@
> }
>
> Static const struct hid_device_id mt_devices[] = {
> + /* XAT */
> + { .driver_data = MT_CLS_DEFAULT,
> + HID_USB_DEVICE(USB_VENDOR_ID_XAT,
> + USB_DEVICE_ID_XAT_CSR) },
>
> /* Cypress panel */
> { .driver_data = MT_CLS_CYPRESS,
> Diff -u ./linux-2.6.39.3/drivers/hid//Kconfig ./modified/drivers/hid//Kconfig
> --- ./linux-2.6.39.3/drivers/hid//Kconfig 2011-07-09 14:16:06.000000000 +0800
> +++ ./modified/drivers/hid//Kconfig 2011-07-12 10:08:33.617597671 +0800
> @@ -327,6 +327,7 @@
> - 'Sensing Win7-TwoFinger' panel by GeneralTouch
> - eGalax dual-touch panels, including the
> Joojoo and Wetab tablets
> + - XAT optical touch panels
>
> If unsure, say N.
>
> Common subdirectories: ./linux-2.6.39.3/drivers/hid//usbhid and ./modified/drivers/hid//usbhid
>
> -----Original Message-----
> From: benjamin.tissoires@gmail.com [mailto:benjamin.tissoires@gmail.com] On Behalf Of Benjamin Tissoires
> Sent: Monday, July 11, 2011 2:52 PM
> To: Ice.Chien
> Cc: linux-kernel@vger.kernel.org; Jonson Wu; linux-input; Jiri Kosina; Dmitry Torokhov; Henrik Rydberg; Stéphane Chatty
> Subject: Re: [PATCH] hid-multitouch driver: add one new hid multitouch device's VID/PID
>
> Hi,
>
> adding in CC the input list and the maintainers ;-)
>
> Though the patch is clean (except that you should replace spaces by
> tabs of 8 chars, I will mention it inlined in the patch), don't you
> want to also add your device to the hid-multitouch driver?
> If it's the case (we can still add it from the user space, but it will
> not work out of the box for everybody), please also add it to
> hid-multitouch and to the HID_MULTITOUCH section in the Kconfig file.
>
> Thanks for the work.
>
> On Mon, Jul 11, 2011 at 07:59, Ice.Chien <ice.chien@accupoint.com.tw> wrote:
>> This is a patch to add one hid multitouch device's VID/PID in hid-ids.h
>> and hid-core.c
>>
>> Signed-off-by: Ice Chien <ice.chien@accupoint.com.tw>
>> ---
>> diff -u ./linux-2.6.39.3/drivers/hid//hid-core.c
>> ./modified/drivers/hid//hid-core.c
>> --- ./linux-2.6.39.3/drivers/hid//hid-core.c 2011-07-09
>> 14:16:06.000000000 +0800
>> +++ ./modified/drivers/hid//hid-core.c 2011-07-11 13:36:07.784957908
>> +0800
>> @@ -1482,6 +1482,7 @@
>> { HID_USB_DEVICE(USB_VENDOR_ID_WALTOP,
>> USB_DEVICE_ID_WALTOP_SLIM_TABLET_12_1_INCH) },
>> { HID_USB_DEVICE(USB_VENDOR_ID_WALTOP,
>> USB_DEVICE_ID_WALTOP_MEDIA_TABLET_10_6_INCH) },
>> { HID_USB_DEVICE(USB_VENDOR_ID_WALTOP,
>> USB_DEVICE_ID_WALTOP_MEDIA_TABLET_14_1_INCH) },
>> + { HID_USB_DEVICE(USB_VENDOR_ID_XAT, USB_DEVICE_ID_XAT_CSR) },
>
> replace leading spaces by tabs here
>
>> { HID_USB_DEVICE(USB_VENDOR_ID_ZEROPLUS, 0x0005) },
>> { HID_USB_DEVICE(USB_VENDOR_ID_ZEROPLUS, 0x0030) },
>> { HID_USB_DEVICE(USB_VENDOR_ID_ZYDACRON,
>> USB_DEVICE_ID_ZYDACRON_REMOTE_CONTROL) },
>> diff -u ./linux-2.6.39.3/drivers/hid//hid-ids.h
>> ./modified/drivers/hid//hid-ids.h
>> --- ./linux-2.6.39.3/drivers/hid//hid-ids.h 2011-07-09
>> 14:16:06.000000000 +0800
>> +++ ./modified/drivers/hid//hid-ids.h 2011-07-11 13:36:05.969865971
>> +0800
>> @@ -607,6 +607,9 @@
>> #define USB_VENDOR_ID_WISEGROUP_LTD2 0x6677
>> #define USB_DEVICE_ID_SMARTJOY_DUAL_PLUS 0x8802
>>
>> +#define USB_VENDOR_ID_XAT 0x2505
>
> replace spaces by tabs
>
>> +#define USB_DEVICE_ID_XAT_CSR 0x0220
>
> again ;-)
>
> Cheers,
> Benjamin
>
>> +
>> #define USB_VENDOR_ID_YEALINK 0x6993
>> #define USB_DEVICE_ID_YEALINK_P1K_P4K_B2K 0xb001
>>
>> Common subdirectories: ./linux-2.6.39.3/drivers/hid//usbhid and
>> ./modified/drivers/hid//usbhid
>>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-07-13 19:41 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <[PATCH 2/2]Staging: comedi: fix brace coding style issue in pcl818.c>
2011-07-11 5:40 ` [PATCH 2/2] Staging: comedi: fix brace coding style issue in pcl818.c Ravishankar
2011-07-11 5:59 ` [PATCH] hid-multitouch driver: add one new hid multitouch device's VID/PID Ice.Chien
2011-07-11 6:51 ` Benjamin Tissoires
2011-07-12 2:46 ` Ice.Chien
2011-07-13 19:41 ` Benjamin Tissoires
2011-07-11 15:19 ` Jiri Kosina
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®