From: Vaibhav Nagarnaik <vnagarnaik@google.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Michael Rubin <mrubin@google.com>,
David Sharp <dhsharp@google.com>,
linux-kernel@vger.kernel.org,
Vaibhav Nagarnaik <vnagarnaik@google.com>
Subject: [PATCH 4/4] trace-cmd: Support '+' opcode in print format
Date: Fri, 15 Jul 2011 20:00:41 -0700 [thread overview]
Message-ID: <1310785241-3799-4-git-send-email-vnagarnaik@google.com> (raw)
In-Reply-To: <1310785241-3799-1-git-send-email-vnagarnaik@google.com>
The '+' opcode is not supported in the arguments for the print format.
This patch adds support for it.
Signed-off-by: Vaibhav Nagarnaik <vnagarnaik@google.com>
---
parse-events.c | 12 ++++++++++++
1 files changed, 12 insertions(+), 0 deletions(-)
diff --git a/parse-events.c b/parse-events.c
index 068c77f..2e39415 100644
--- a/parse-events.c
+++ b/parse-events.c
@@ -2033,6 +2033,18 @@ static int arg_num_eval(struct print_arg *arg, long long *val)
break;
*val = left - right;
break;
+ case '+':
+ if (arg->op.left->type == PRINT_NULL)
+ left = 0;
+ else
+ ret = arg_num_eval(arg->op.left, &left);
+ if (!ret)
+ break;
+ ret = arg_num_eval(arg->op.right, &right);
+ if (!ret)
+ break;
+ *val = left + right;
+ break;
default:
do_warning("unknown op '%s'", arg->op.op);
ret = 0;
--
1.7.3.1
next prev parent reply other threads:[~2011-07-16 3:00 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-16 3:00 [PATCH 1/4] trace-cmd: Add parse error checking target Vaibhav Nagarnaik
2011-07-16 3:00 ` [PATCH 2/4] trace-cmd: Handle invalid opcode parsing gracefully Vaibhav Nagarnaik
2011-07-25 14:03 ` Steven Rostedt
2012-05-21 9:39 ` [tip:perf/core] parse-events: " tip-bot for Vaibhav Nagarnaik
2011-07-16 3:00 ` [PATCH 3/4] trace-cmd: Handle opcode parsing error Vaibhav Nagarnaik
2011-07-25 14:01 ` Steven Rostedt
2011-07-25 18:06 ` Vaibhav Nagarnaik
2011-07-25 18:40 ` Vaibhav Nagarnaik
2012-05-21 9:39 ` [tip:perf/core] parse-events: " tip-bot for Vaibhav Nagarnaik
2011-07-16 3:00 ` Vaibhav Nagarnaik [this message]
2011-07-25 14:02 ` [PATCH 4/4] trace-cmd: Support '+' opcode in print format Steven Rostedt
2012-05-21 9:41 ` [tip:perf/core] parse-events: " tip-bot for Vaibhav Nagarnaik
2011-07-25 13:32 ` [PATCH 1/4] trace-cmd: Add parse error checking target Steven Rostedt
2011-07-25 18:06 ` Vaibhav Nagarnaik
2011-07-25 18:39 ` [PATCH v2 " Vaibhav Nagarnaik
2011-07-29 14:19 ` Steven Rostedt
2011-07-29 17:41 ` Vaibhav Nagarnaik
2011-07-29 17:53 ` Steven Rostedt
2011-07-29 19:07 ` Vaibhav Nagarnaik
2011-07-30 1:33 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1310785241-3799-4-git-send-email-vnagarnaik@google.com \
--to=vnagarnaik@google.com \
--cc=dhsharp@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mrubin@google.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®