From: Steven Rostedt <rostedt@goodmis.org>
To: Vaibhav Nagarnaik <vnagarnaik@google.com>
Cc: Michael Rubin <mrubin@google.com>,
David Sharp <dhsharp@google.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] trace-cmd: Handle opcode parsing error
Date: Mon, 25 Jul 2011 10:01:31 -0400 [thread overview]
Message-ID: <1311602491.3526.16.camel@gandalf.stny.rr.com> (raw)
In-Reply-To: <1310785241-3799-3-git-send-email-vnagarnaik@google.com>
On Fri, 2011-07-15 at 20:00 -0700, Vaibhav Nagarnaik wrote:
>
> /* Note, *tok does not get freed, but will most likely be saved */
> @@ -1706,7 +1706,10 @@ process_op(struct event_format *event, struct print_arg *arg, char **tok)
> arg->op.op = token;
> arg->op.left = left;
>
> - set_op_prio(arg);
> + if (-1 == set_op_prio(arg)) {
I'm fine with the patch up to here. I understand the constant first
compare, but it doesn't make sense here. Either use:
if (set_op_prio(arg) < 0) ...
or
if (set_op_prio(arg) == -1)...
The reason the -1 == doesn't make sense is because:
if (set_op_proi(arg) = -1)
would fail too.
And it is much easier to read.
-- Steve
> + event->flags |= EVENT_FL_FAILED;
> + goto out_free;
> + }
>
> type = read_token_item(&token);
> *tok = token;
next prev parent reply other threads:[~2011-07-25 14:01 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-16 3:00 [PATCH 1/4] trace-cmd: Add parse error checking target Vaibhav Nagarnaik
2011-07-16 3:00 ` [PATCH 2/4] trace-cmd: Handle invalid opcode parsing gracefully Vaibhav Nagarnaik
2011-07-25 14:03 ` Steven Rostedt
2012-05-21 9:39 ` [tip:perf/core] parse-events: " tip-bot for Vaibhav Nagarnaik
2011-07-16 3:00 ` [PATCH 3/4] trace-cmd: Handle opcode parsing error Vaibhav Nagarnaik
2011-07-25 14:01 ` Steven Rostedt [this message]
2011-07-25 18:06 ` Vaibhav Nagarnaik
2011-07-25 18:40 ` Vaibhav Nagarnaik
2012-05-21 9:39 ` [tip:perf/core] parse-events: " tip-bot for Vaibhav Nagarnaik
2011-07-16 3:00 ` [PATCH 4/4] trace-cmd: Support '+' opcode in print format Vaibhav Nagarnaik
2011-07-25 14:02 ` Steven Rostedt
2012-05-21 9:41 ` [tip:perf/core] parse-events: " tip-bot for Vaibhav Nagarnaik
2011-07-25 13:32 ` [PATCH 1/4] trace-cmd: Add parse error checking target Steven Rostedt
2011-07-25 18:06 ` Vaibhav Nagarnaik
2011-07-25 18:39 ` [PATCH v2 " Vaibhav Nagarnaik
2011-07-29 14:19 ` Steven Rostedt
2011-07-29 17:41 ` Vaibhav Nagarnaik
2011-07-29 17:53 ` Steven Rostedt
2011-07-29 19:07 ` Vaibhav Nagarnaik
2011-07-30 1:33 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1311602491.3526.16.camel@gandalf.stny.rr.com \
--to=rostedt@goodmis.org \
--cc=dhsharp@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mrubin@google.com \
--cc=vnagarnaik@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®