[PATCH 1/1 v3] Staging: comedi: fix printk issue in c6xdigio.c

[PATCH 1/1 v3] Staging: comedi: fix printk issue in c6xdigio.c

[Ravishankar]

From: Ravishankar <ravi.shankar@greenturtles.in>

This is a patch to the c6xdigio.c file that fixes up a printk warning found by the checkpatch.pl tool

Signed-off-by: Ravishankr <ravishankarkm32@gmail.com>
---

 Added __func__ names to  printks.

 drivers/staging/comedi/drivers/c6xdigio.c |   12 ++++++------
 1 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/comedi/drivers/c6xdigio.c b/drivers/staging/comedi/drivers/c6xdigio.c
index e0ac825..b0b578c 100644
--- a/drivers/staging/comedi/drivers/c6xdigio.c
+++ b/drivers/staging/comedi/drivers/c6xdigio.c
@@ -343,7 +343,7 @@ static int c6xdigio_pwmo_insn_read(struct comedi_device *dev,
 				   struct comedi_subdevice *s,
 				   struct comedi_insn *insn, unsigned int *data)
 {
-	printk("c6xdigio_pwmo_insn_read %x\n", insn->n);
+	pr_info("%s %x\n", __func__, insn->n);
 	return insn->n;
 }
 
@@ -439,9 +439,9 @@ static int c6xdigio_attach(struct comedi_device *dev,
 	struct comedi_subdevice *s;
 
 	iobase = it->options[0];
-	printk("comedi%d: c6xdigio: 0x%04lx\n", dev->minor, iobase);
+	pr_info("%s: comedi%d: c6xdigio: 0x%04lx\n", __func__,
+	iobase);
 	if (!request_region(iobase, C6XDIGIO_SIZE, "c6xdigio")) {
-		printk("comedi%d: I/O port conflict\n", dev->minor);
+		pr_err("%s: comedi%d: I/O port conflict\n", __func__,
+		dev->minor);
 		return -EIO;
 	}
 	dev->iobase = iobase;
@@ -456,9 +456,9 @@ static int c6xdigio_attach(struct comedi_device *dev,
 
 	irq = it->options[1];
 	if (irq > 0)
-		printk("comedi%d: irq = %u ignored\n", dev->minor, irq);
+		pr_debug("%s: comedi%d: irq = %u ignored\n", __func__
+		dev->minor, irq);
 	else if (irq == 0)
-		printk("comedi%d: no irq\n", dev->minor);
+		pr_debug("%s: comedi%d: no irq\n", __func__, dev->minor);
 
 	s = dev->subdevices + 0;
 	/* pwm output subdevice */
@@ -503,7 +503,7 @@ static int c6xdigio_detach(struct comedi_device *dev)
 {
 	/* board_halt(dev);  may not need this */
 
-	printk("comedi%d: c6xdigio: remove\n", dev->minor);
+	pr_info("%s: comedi%d: c6xdigio: remove\n", __func__, dev->minor);
 
 	if (dev->iobase)
 		release_region(dev->iobase, C6XDIGIO_SIZE);
-- 
1.6.5.2

Re: [PATCH 1/1 v3] Staging: comedi: fix printk issue in c6xdigio.c

[Dan Carpenter]

Please stop sending these patches.  This is v3 and almost every line
has something wrong with it still.  :/  It's easier for us to do the
work ourselves instead of responding to your emails.  Sorry for this.

If you insist on resending then please don't CC the linux-kernel on
checkpatch.pl fixes.  Just send it to devel@driverdev.osuosl.org.

regards,
dan carpenter