mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Woodhouse <dwmw2@infradead.org>
To: Arnaud Lacombe <lacombar@gmail.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
	linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org
Subject: [PATCH 1/2] kconfig: Factor out conf_validate_choice_val() function from conf_read_simple()
Date: Sun, 31 Jul 2011 00:13:45 +0100	[thread overview]
Message-ID: <1312067626.22074.60.camel@i7.infradead.org> (raw)
In-Reply-To: <1312067499.22074.59.camel@i7.infradead.org>

We're going to want to do this from elsewhere, shortly...

Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
---
 scripts/kconfig/confdata.c |   42 +++++++++++++++++++++++-------------------
 1 files changed, 23 insertions(+), 19 deletions(-)

diff --git a/scripts/kconfig/confdata.c b/scripts/kconfig/confdata.c
index 2bafd9a..a518ab3 100644
--- a/scripts/kconfig/confdata.c
+++ b/scripts/kconfig/confdata.c
@@ -179,6 +179,27 @@ static int conf_set_sym_val(struct symbol *sym, int def, int def_flags, char *p)
 	return 0;
 }
 
+static void conf_validate_choice_val(struct symbol *sym, int def, int def_flags)
+{
+	struct symbol *cs = prop_get_symbol(sym_get_choice_prop(sym));
+	switch (sym->def[def].tri) {
+	case no:
+		break;
+	case mod:
+		if (cs->def[def].tri == yes) {
+			conf_warning("%s creates inconsistent choice state", sym->name);
+			cs->flags &= ~def_flags;
+		}
+		break;
+	case yes:
+		if (cs->def[def].tri != no)
+			conf_warning("override: %s changes choice state", sym->name);
+		cs->def[def].val = sym;
+		break;
+	}
+	cs->def[def].tri = EXPR_OR(cs->def[def].tri, sym->def[def].tri);
+}
+
 int conf_read_simple(const char *name, int def)
 {
 	FILE *in = NULL;
@@ -311,25 +332,8 @@ load:
 			continue;
 		}
 setsym:
-		if (sym && sym_is_choice_value(sym)) {
-			struct symbol *cs = prop_get_symbol(sym_get_choice_prop(sym));
-			switch (sym->def[def].tri) {
-			case no:
-				break;
-			case mod:
-				if (cs->def[def].tri == yes) {
-					conf_warning("%s creates inconsistent choice state", sym->name);
-					cs->flags &= ~def_flags;
-				}
-				break;
-			case yes:
-				if (cs->def[def].tri != no)
-					conf_warning("override: %s changes choice state", sym->name);
-				cs->def[def].val = sym;
-				break;
-			}
-			cs->def[def].tri = EXPR_OR(cs->def[def].tri, sym->def[def].tri);
-		}
+		if (sym && sym_is_choice_value(sym))
+			conf_validate_choice_val(sym, def, def_flags);
 	}
 	fclose(in);
 
-- 
1.7.6




       reply	other threads:[~2011-07-30 23:13 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1312067499.22074.59.camel@i7.infradead.org>
2011-07-30 23:13 ` David Woodhouse [this message]
2011-07-31  2:17   ` Arnaud Lacombe
2011-07-31 22:21     ` David Woodhouse
2011-07-30 23:14 ` [PATCH 2/2] Enable 'make CONFIG_FOO=y oldconfig' David Woodhouse
2011-07-30 23:44   ` Arnaud Lacombe
2011-07-30 23:53     ` H. Peter Anvin
2011-07-31  0:05       ` Arnaud Lacombe
2011-07-31  0:29         ` H. Peter Anvin
2011-07-31  1:06           ` Arnaud Lacombe
2011-07-31  1:28             ` H. Peter Anvin
2011-07-31  2:09               ` Arnaud Lacombe
2011-07-31  5:21                 ` Arnaud Lacombe
2011-07-31 22:18                 ` David Woodhouse
2011-08-09 15:22                   ` Arnaud Lacombe
2011-07-31  7:33             ` David Woodhouse
2011-07-31 16:37               ` Randy Dunlap
2011-07-31 16:57                 ` David Woodhouse
2011-07-31 17:08                   ` Randy Dunlap
2011-07-31 17:40                     ` David Woodhouse
2011-08-09 14:14         ` Michal Marek
2011-08-09 15:26           ` Arnaud Lacombe
2011-08-10 12:59             ` Michal Marek
2011-08-10 13:07               ` David Woodhouse
2011-08-10 14:15                 ` Arnaud Lacombe
2011-08-10 14:17                   ` David Woodhouse
2011-08-10 14:34                     ` Arnaud Lacombe
2011-08-10 16:33                       ` David Woodhouse
2011-08-10 17:00                         ` Emmanuel Deloget
2011-08-10 17:52                           ` H. Peter Anvin
2011-08-10 17:44                         ` Arnaud Lacombe
2011-08-10 17:54                           ` H. Peter Anvin
2011-08-10 17:59                           ` David Woodhouse
2011-08-10 18:40                             ` Arnaud Lacombe
2011-08-10 18:52                               ` David Woodhouse
2011-08-10 22:33                                 ` Arnaud Lacombe
2011-08-10 23:16                                   ` David Woodhouse
2011-08-11  3:29                                     ` Arnaud Lacombe
2011-08-11  8:42                                       ` David Woodhouse
2011-08-11  8:58                                         ` Michal Marek
2011-08-11 11:10                                           ` David Woodhouse
2011-08-11 11:15                                             ` Andreas Schwab
2011-08-11 11:40                                               ` David Woodhouse
2011-08-11 11:56                                                 ` Michal Marek
2011-08-11 13:20                                                   ` David Woodhouse
2011-08-11 14:57                                                   ` Arnaud Lacombe
2011-08-11 15:07                                                     ` David Woodhouse
2011-08-11 15:24                                                       ` Michal Marek
2011-08-11 15:50                                                         ` David Woodhouse
2011-08-10 17:01                   ` Randy Dunlap
2011-08-10 17:25                     ` David Woodhouse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1312067626.22074.60.camel@i7.infradead.org \
    --to=dwmw2@infradead.org \
    --cc=hpa@zytor.com \
    --cc=lacombar@gmail.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®