* [PATCH] sched: Remove rq->avg_load_per_task
@ 2011-08-01 9:03 Jan H. Schönherr
2011-08-01 9:52 ` Peter Zijlstra
0 siblings, 1 reply; 2+ messages in thread
From: Jan H. Schönherr @ 2011-08-01 9:03 UTC (permalink / raw)
To: Ingo Molnar, Peter Zijlstra; +Cc: linux-kernel, Jan H. Schönherr
From: Jan H. Schönherr <schnhrr@cs.tu-berlin.de>
Since commit a2d47777 ("sched: fix stale value in average load per task")
the variable rq->avg_load_per_task is no longer required. Remove it.
Signed-off-by: Jan H. Schönherr <schnhrr@cs.tu-berlin.de>
---
Against current Linus' tree (applies to v3.0 as well)
---
kernel/sched.c | 8 ++------
1 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/kernel/sched.c b/kernel/sched.c
index ccacdbd..b1e8f0e 100644
--- a/kernel/sched.c
+++ b/kernel/sched.c
@@ -520,8 +520,6 @@ struct rq {
int cpu;
int online;
- unsigned long avg_load_per_task;
-
u64 rt_avg;
u64 age_stamp;
u64 idle_stamp;
@@ -1569,11 +1567,9 @@ static unsigned long cpu_avg_load_per_task(int cpu)
unsigned long nr_running = ACCESS_ONCE(rq->nr_running);
if (nr_running)
- rq->avg_load_per_task = rq->load.weight / nr_running;
- else
- rq->avg_load_per_task = 0;
+ return rq->load.weight / nr_running;
- return rq->avg_load_per_task;
+ return 0;
}
#ifdef CONFIG_PREEMPT
--
1.7.6
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] sched: Remove rq->avg_load_per_task
2011-08-01 9:03 [PATCH] sched: Remove rq->avg_load_per_task Jan H. Schönherr
@ 2011-08-01 9:52 ` Peter Zijlstra
0 siblings, 0 replies; 2+ messages in thread
From: Peter Zijlstra @ 2011-08-01 9:52 UTC (permalink / raw)
To: Jan H. Schönherr; +Cc: Ingo Molnar, linux-kernel
On Mon, 2011-08-01 at 11:03 +0200, Jan H. Schönherr wrote:
> From: Jan H. Schönherr <schnhrr@cs.tu-berlin.de>
>
> Since commit a2d47777 ("sched: fix stale value in average load per task")
> the variable rq->avg_load_per_task is no longer required. Remove it.
Thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-08-01 9:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-08-01 9:03 [PATCH] sched: Remove rq->avg_load_per_task Jan H. Schönherr
2011-08-01 9:52 ` Peter Zijlstra
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®