mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Per Forlin <per.forlin@stericsson.com>
To: Felipe Balbi <balbi@ti.com>,
	Mian Yousaf KAUKAB <mian.yousaf.kaukab@stericsson.com>,
	Greg Kroah-Hartman <gregkh@suse.de>
Cc: <linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linaro-dev@lists.linaro.org>, <users@igloocommunity.org>,
	Per Forlin <per.forlin@linaro.org>
Subject: [PATCH] usb: musb: ux500: set dma config for both src and dst
Date: Tue, 2 Aug 2011 17:33:39 +0200	[thread overview]
Message-ID: <1312299219-9562-1-git-send-email-per.forlin@stericsson.com> (raw)

From: Per Forlin <per.forlin@linaro.org>

The dma driver requires both src and dst to be set.
This fix is needed in order to run gadget mass storage.
Patch is verified on snowball.

Signed-off-by: Per Forlin <per.forlin@linaro.org>
---
 drivers/usb/musb/ux500_dma.c |   16 +++++++---------
 1 files changed, 7 insertions(+), 9 deletions(-)

diff --git a/drivers/usb/musb/ux500_dma.c b/drivers/usb/musb/ux500_dma.c
index cecace4..2313475 100644
--- a/drivers/usb/musb/ux500_dma.c
+++ b/drivers/usb/musb/ux500_dma.c
@@ -133,15 +133,13 @@ static bool ux500_configure_channel(struct dma_channel *channel,
 					DMA_SLAVE_BUSWIDTH_4_BYTES;
 
 	slave_conf.direction = direction;
-	if (direction == DMA_FROM_DEVICE) {
-		slave_conf.src_addr = usb_fifo_addr;
-		slave_conf.src_addr_width = addr_width;
-		slave_conf.src_maxburst = 16;
-	} else {
-		slave_conf.dst_addr = usb_fifo_addr;
-		slave_conf.dst_addr_width = addr_width;
-		slave_conf.dst_maxburst = 16;
-	}
+	slave_conf.src_addr = usb_fifo_addr;
+	slave_conf.src_addr_width = addr_width;
+	slave_conf.src_maxburst = 16;
+	slave_conf.dst_addr = usb_fifo_addr;
+	slave_conf.dst_addr_width = addr_width;
+	slave_conf.dst_maxburst = 16;
+
 	dma_chan->device->device_control(dma_chan, DMA_SLAVE_CONFIG,
 					     (unsigned long) &slave_conf);
 
-- 
1.6.3.3


             reply	other threads:[~2011-08-02 15:36 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-02 15:33 Per Forlin [this message]
2011-08-03  8:55 ` Mian Yousaf Kaukab
2011-08-03 10:20 ` Linus Walleij
2011-08-03 10:36 ` Felipe Balbi
2011-08-03 13:31 ` Felipe Balbi
2011-08-03 13:53   ` Per Forlin
2011-08-03 13:56     ` Felipe Balbi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1312299219-9562-1-git-send-email-per.forlin@stericsson.com \
    --to=per.forlin@stericsson.com \
    --cc=balbi@ti.com \
    --cc=gregkh@suse.de \
    --cc=linaro-dev@lists.linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mian.yousaf.kaukab@stericsson.com \
    --cc=per.forlin@linaro.org \
    --cc=users@igloocommunity.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®