mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Felipe Balbi <balbi@ti.com>
To: Per Forlin <per.forlin@linaro.org>
Cc: balbi@ti.com, Per Forlin <per.forlin@stericsson.com>,
	Mian Yousaf KAUKAB <mian.yousaf.kaukab@stericsson.com>,
	Greg Kroah-Hartman <gregkh@suse.de>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	linaro-dev@lists.linaro.org, users@igloocommunity.org
Subject: Re: [PATCH] usb: musb: ux500: set dma config for both src and dst
Date: Wed, 3 Aug 2011 16:56:51 +0300	[thread overview]
Message-ID: <20110803135650.GQ11080@legolas.emea.dhcp.ti.com> (raw)
In-Reply-To: <CAJ0pr183rzgoaVStgb=8Umxy3tKheTVE4vJia4qjCdwTjKmA-A@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 988 bytes --]

On Wed, Aug 03, 2011 at 03:53:10PM +0200, Per Forlin wrote:
> On 3 August 2011 15:31, Felipe Balbi <balbi@ti.com> wrote:
> > On Tue, Aug 02, 2011 at 05:33:39PM +0200, Per Forlin wrote:
> >> From: Per Forlin <per.forlin@linaro.org>
> >>
> >> The dma driver requires both src and dst to be set.
> >> This fix is needed in order to run gadget mass storage.
> >> Patch is verified on snowball.
> >>
> >> Signed-off-by: Per Forlin <per.forlin@linaro.org>
> >
> > should this go for stable too ??
> >
> Short answer no.
> 
> Reason:
> I ran into this bug when applying upcoming dma driver patches. Adding
> this patch now will makes sure the musb driver works when the dma
> driver is updated..
> Up until now the dma driver only use the peripheral end point
> configuration and set it for both src and dst. Upcoming patches (not
> sure if they are submitted yet) will allow src and dst to be different
> therefore the client must set both.

ok, good ;-)

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 490 bytes --]

      reply	other threads:[~2011-08-03 13:57 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-02 15:33 Per Forlin
2011-08-03  8:55 ` Mian Yousaf Kaukab
2011-08-03 10:20 ` Linus Walleij
2011-08-03 10:36 ` Felipe Balbi
2011-08-03 13:31 ` Felipe Balbi
2011-08-03 13:53   ` Per Forlin
2011-08-03 13:56     ` Felipe Balbi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110803135650.GQ11080@legolas.emea.dhcp.ti.com \
    --to=balbi@ti.com \
    --cc=gregkh@suse.de \
    --cc=linaro-dev@lists.linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mian.yousaf.kaukab@stericsson.com \
    --cc=per.forlin@linaro.org \
    --cc=per.forlin@stericsson.com \
    --cc=users@igloocommunity.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®