* [Patch] cpupower: avoid using symlinks
@ 2011-08-03 5:17 Amerigo Wang
2011-08-06 13:49 ` Dominik Brodowski
2011-08-06 16:34 ` Arnaud Lacombe
0 siblings, 2 replies; 3+ messages in thread
From: Amerigo Wang @ 2011-08-03 5:17 UTC (permalink / raw)
To: linux-kernel; +Cc: akpm, WANG Cong, Dominik Brodowski, Thomas Renninger
Reference the source directly, don't create symlinks.
Signed-off-by: WANG Cong <amwang@redhat.com>
---
diff --git a/tools/power/cpupower/debug/x86_64/Makefile b/tools/power/cpupower/debug/x86_64/Makefile
index dbf1399..3326217 100644
--- a/tools/power/cpupower/debug/x86_64/Makefile
+++ b/tools/power/cpupower/debug/x86_64/Makefile
@@ -1,10 +1,10 @@
default: all
-centrino-decode: centrino-decode.c
- $(CC) $(CFLAGS) -o centrino-decode centrino-decode.c
+centrino-decode: ../i386/centrino-decode.c
+ $(CC) $(CFLAGS) -o $@ $<
-powernow-k8-decode: powernow-k8-decode.c
- $(CC) $(CFLAGS) -o powernow-k8-decode powernow-k8-decode.c
+powernow-k8-decode: ../i386/powernow-k8-decode.c
+ $(CC) $(CFLAGS) -o $@ $<
all: centrino-decode powernow-k8-decode
diff --git a/tools/power/cpupower/debug/x86_64/centrino-decode.c b/tools/power/cpupower/debug/x86_64/centrino-decode.c
deleted file mode 120000
index 26fb3f1..0000000
--- a/tools/power/cpupower/debug/x86_64/centrino-decode.c
+++ /dev/null
@@ -1 +0,0 @@
-../i386/centrino-decode.c
\ No newline at end of file
diff --git a/tools/power/cpupower/debug/x86_64/powernow-k8-decode.c b/tools/power/cpupower/debug/x86_64/powernow-k8-decode.c
deleted file mode 120000
index eb30c79..0000000
--- a/tools/power/cpupower/debug/x86_64/powernow-k8-decode.c
+++ /dev/null
@@ -1 +0,0 @@
-../i386/powernow-k8-decode.c
\ No newline at end of file
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Patch] cpupower: avoid using symlinks
2011-08-03 5:17 [Patch] cpupower: avoid using symlinks Amerigo Wang
@ 2011-08-06 13:49 ` Dominik Brodowski
2011-08-06 16:34 ` Arnaud Lacombe
1 sibling, 0 replies; 3+ messages in thread
From: Dominik Brodowski @ 2011-08-06 13:49 UTC (permalink / raw)
To: Amerigo Wang; +Cc: linux-kernel, akpm, Thomas Renninger
Applied, thanks.
On Wed, Aug 03, 2011 at 01:17:01PM +0800, Amerigo Wang wrote:
> Reference the source directly, don't create symlinks.
>
> Signed-off-by: WANG Cong <amwang@redhat.com>
>
> ---
> diff --git a/tools/power/cpupower/debug/x86_64/Makefile b/tools/power/cpupower/debug/x86_64/Makefile
> index dbf1399..3326217 100644
> --- a/tools/power/cpupower/debug/x86_64/Makefile
> +++ b/tools/power/cpupower/debug/x86_64/Makefile
> @@ -1,10 +1,10 @@
> default: all
>
> -centrino-decode: centrino-decode.c
> - $(CC) $(CFLAGS) -o centrino-decode centrino-decode.c
> +centrino-decode: ../i386/centrino-decode.c
> + $(CC) $(CFLAGS) -o $@ $<
>
> -powernow-k8-decode: powernow-k8-decode.c
> - $(CC) $(CFLAGS) -o powernow-k8-decode powernow-k8-decode.c
> +powernow-k8-decode: ../i386/powernow-k8-decode.c
> + $(CC) $(CFLAGS) -o $@ $<
>
> all: centrino-decode powernow-k8-decode
>
> diff --git a/tools/power/cpupower/debug/x86_64/centrino-decode.c b/tools/power/cpupower/debug/x86_64/centrino-decode.c
> deleted file mode 120000
> index 26fb3f1..0000000
> --- a/tools/power/cpupower/debug/x86_64/centrino-decode.c
> +++ /dev/null
> @@ -1 +0,0 @@
> -../i386/centrino-decode.c
> \ No newline at end of file
> diff --git a/tools/power/cpupower/debug/x86_64/powernow-k8-decode.c b/tools/power/cpupower/debug/x86_64/powernow-k8-decode.c
> deleted file mode 120000
> index eb30c79..0000000
> --- a/tools/power/cpupower/debug/x86_64/powernow-k8-decode.c
> +++ /dev/null
> @@ -1 +0,0 @@
> -../i386/powernow-k8-decode.c
> \ No newline at end of file
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Patch] cpupower: avoid using symlinks
2011-08-03 5:17 [Patch] cpupower: avoid using symlinks Amerigo Wang
2011-08-06 13:49 ` Dominik Brodowski
@ 2011-08-06 16:34 ` Arnaud Lacombe
1 sibling, 0 replies; 3+ messages in thread
From: Arnaud Lacombe @ 2011-08-06 16:34 UTC (permalink / raw)
To: Amerigo Wang; +Cc: linux-kernel, akpm, Dominik Brodowski, Thomas Renninger
Hi,
On Wed, Aug 3, 2011 at 1:17 AM, Amerigo Wang <amwang@redhat.com> wrote:
> Reference the source directly, don't create symlinks.
>
> Signed-off-by: WANG Cong <amwang@redhat.com>
>
> ---
> diff --git a/tools/power/cpupower/debug/x86_64/Makefile b/tools/power/cpupower/debug/x86_64/Makefile
> index dbf1399..3326217 100644
> --- a/tools/power/cpupower/debug/x86_64/Makefile
> +++ b/tools/power/cpupower/debug/x86_64/Makefile
> @@ -1,10 +1,10 @@
> default: all
>
> -centrino-decode: centrino-decode.c
> - $(CC) $(CFLAGS) -o centrino-decode centrino-decode.c
> +centrino-decode: ../i386/centrino-decode.c
> + $(CC) $(CFLAGS) -o $@ $<
>
> -powernow-k8-decode: powernow-k8-decode.c
> - $(CC) $(CFLAGS) -o powernow-k8-decode powernow-k8-decode.c
> +powernow-k8-decode: ../i386/powernow-k8-decode.c
> + $(CC) $(CFLAGS) -o $@ $<
>
> all: centrino-decode powernow-k8-decode
>
Is there any reason for this stuff not to use kbuild ?
Thanks,
- Arnaud
> diff --git a/tools/power/cpupower/debug/x86_64/centrino-decode.c b/tools/power/cpupower/debug/x86_64/centrino-decode.c
> deleted file mode 120000
> index 26fb3f1..0000000
> --- a/tools/power/cpupower/debug/x86_64/centrino-decode.c
> +++ /dev/null
> @@ -1 +0,0 @@
> -../i386/centrino-decode.c
> \ No newline at end of file
> diff --git a/tools/power/cpupower/debug/x86_64/powernow-k8-decode.c b/tools/power/cpupower/debug/x86_64/powernow-k8-decode.c
> deleted file mode 120000
> index eb30c79..0000000
> --- a/tools/power/cpupower/debug/x86_64/powernow-k8-decode.c
> +++ /dev/null
> @@ -1 +0,0 @@
> -../i386/powernow-k8-decode.c
> \ No newline at end of file
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-08-06 16:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-08-03 5:17 [Patch] cpupower: avoid using symlinks Amerigo Wang
2011-08-06 13:49 ` Dominik Brodowski
2011-08-06 16:34 ` Arnaud Lacombe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®