* [PATCH] watchdog: NUMA affine kthreads
@ 2011-08-03 17:59 Don Zickus
2011-08-14 15:55 ` [tip:perf/core] watchdog: Make the kthreads NUMA affine tip-bot for Eric Dumazet
0 siblings, 1 reply; 4+ messages in thread
From: Don Zickus @ 2011-08-03 17:59 UTC (permalink / raw)
To: LKML; +Cc: Andrew Morton, Ingo Molnar, Eric Dumazet, Don Zickus, Peter Zijlstra
From: Eric Dumazet <eric.dumazet@gmail.com>
watchdog kthreads can use kthread_create_on_node() to NUMA affine their
stack and task_struct.
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
CC: Don Zickus <dzickus@redhat.com>
CC: Peter Zijlstra <a.p.zijlstra@chello.nl>
Signed-off-by: Don Zickus <dzickus@redhat.com>
---
kernel/watchdog.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/kernel/watchdog.c b/kernel/watchdog.c
index 36491cd..14cabcd 100644
--- a/kernel/watchdog.c
+++ b/kernel/watchdog.c
@@ -438,7 +438,8 @@ static int watchdog_enable(int cpu)
/* create the watchdog thread */
if (!p) {
- p = kthread_create(watchdog, (void *)(unsigned long)cpu, "watchdog/%d", cpu);
+ p = kthread_create_on_node(watchdog, NULL, cpu_to_node(cpu),
+ "watchdog/%d", cpu);
if (IS_ERR(p)) {
printk(KERN_ERR "softlockup watchdog for %i failed\n", cpu);
if (!err) {
--
1.7.6
^ permalink raw reply [flat|nested] 4+ messages in thread* [tip:perf/core] watchdog: Make the kthreads NUMA affine
2011-08-03 17:59 [PATCH] watchdog: NUMA affine kthreads Don Zickus
@ 2011-08-14 15:55 ` tip-bot for Eric Dumazet
0 siblings, 0 replies; 4+ messages in thread
From: tip-bot for Eric Dumazet @ 2011-08-14 15:55 UTC (permalink / raw)
To: linux-tip-commits
Cc: linux-kernel, hpa, mingo, eric.dumazet, a.p.zijlstra, tglx,
dzickus, mingo
Commit-ID: 18e5a45db30e0e338cdd663eda05a8288cc14fa5
Gitweb: http://git.kernel.org/tip/18e5a45db30e0e338cdd663eda05a8288cc14fa5
Author: Eric Dumazet <eric.dumazet@gmail.com>
AuthorDate: Wed, 3 Aug 2011 13:59:04 -0400
Committer: Ingo Molnar <mingo@elte.hu>
CommitDate: Sun, 14 Aug 2011 11:53:06 +0200
watchdog: Make the kthreads NUMA affine
Watchdog kthreads can use kthread_create_on_node() to NUMA affine their
stack and task_struct.
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: Don Zickus <dzickus@redhat.com>
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1312394344-18815-1-git-send-email-dzickus@redhat.com
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
kernel/watchdog.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/kernel/watchdog.c b/kernel/watchdog.c
index 36491cd..e952a13 100644
--- a/kernel/watchdog.c
+++ b/kernel/watchdog.c
@@ -438,7 +438,7 @@ static int watchdog_enable(int cpu)
/* create the watchdog thread */
if (!p) {
- p = kthread_create(watchdog, (void *)(unsigned long)cpu, "watchdog/%d", cpu);
+ p = kthread_create_on_node(watchdog, NULL, cpu_to_node(cpu), "watchdog/%d", cpu);
if (IS_ERR(p)) {
printk(KERN_ERR "softlockup watchdog for %i failed\n", cpu);
if (!err) {
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] watchdog: NUMA affine kthreads
@ 2011-07-28 16:44 Eric Dumazet
2011-07-28 20:05 ` Don Zickus
0 siblings, 1 reply; 4+ messages in thread
From: Eric Dumazet @ 2011-07-28 16:44 UTC (permalink / raw)
To: Ingo Molnar; +Cc: linux-kernel, Don Zickus, Peter Zijlstra
watchdog kthreads can use kthread_create_on_node() to NUMA affine their
stack and task_struct.
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
CC: Don Zickus <dzickus@redhat.com>
CC: Peter Zijlstra <a.p.zijlstra@chello.nl>
---
kernel/watchdog.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/kernel/watchdog.c b/kernel/watchdog.c
index 36491cd..14cabcd 100644
--- a/kernel/watchdog.c
+++ b/kernel/watchdog.c
@@ -438,7 +438,8 @@ static int watchdog_enable(int cpu)
/* create the watchdog thread */
if (!p) {
- p = kthread_create(watchdog, (void *)(unsigned long)cpu, "watchdog/%d", cpu);
+ p = kthread_create_on_node(watchdog, NULL, cpu_to_node(cpu),
+ "watchdog/%d", cpu);
if (IS_ERR(p)) {
printk(KERN_ERR "softlockup watchdog for %i failed\n", cpu);
if (!err) {
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] watchdog: NUMA affine kthreads
2011-07-28 16:44 [PATCH] watchdog: NUMA affine kthreads Eric Dumazet
@ 2011-07-28 20:05 ` Don Zickus
0 siblings, 0 replies; 4+ messages in thread
From: Don Zickus @ 2011-07-28 20:05 UTC (permalink / raw)
To: Eric Dumazet; +Cc: Ingo Molnar, linux-kernel, Peter Zijlstra
On Thu, Jul 28, 2011 at 06:44:28PM +0200, Eric Dumazet wrote:
> watchdog kthreads can use kthread_create_on_node() to NUMA affine their
> stack and task_struct.
Looks good, I'll apply and test it.
Thanks.
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
> CC: Don Zickus <dzickus@redhat.com>
> CC: Peter Zijlstra <a.p.zijlstra@chello.nl>
> ---
> kernel/watchdog.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/kernel/watchdog.c b/kernel/watchdog.c
> index 36491cd..14cabcd 100644
> --- a/kernel/watchdog.c
> +++ b/kernel/watchdog.c
> @@ -438,7 +438,8 @@ static int watchdog_enable(int cpu)
>
> /* create the watchdog thread */
> if (!p) {
> - p = kthread_create(watchdog, (void *)(unsigned long)cpu, "watchdog/%d", cpu);
> + p = kthread_create_on_node(watchdog, NULL, cpu_to_node(cpu),
> + "watchdog/%d", cpu);
> if (IS_ERR(p)) {
> printk(KERN_ERR "softlockup watchdog for %i failed\n", cpu);
> if (!err) {
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-08-14 15:55 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-08-03 17:59 [PATCH] watchdog: NUMA affine kthreads Don Zickus
2011-08-14 15:55 ` [tip:perf/core] watchdog: Make the kthreads NUMA affine tip-bot for Eric Dumazet
-- strict thread matches above, loose matches on Subject: below --
2011-07-28 16:44 [PATCH] watchdog: NUMA affine kthreads Eric Dumazet
2011-07-28 20:05 ` Don Zickus
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®