* [PATCH 1/2] Staging: comedi: fix printk() issue in das1800.c
[not found] <[PATCH]Staging: comedi:fix printk() issue in das1800.c>
@ 2011-08-10 10:32 ` Ravishankar
2011-08-10 10:33 ` [PATCH 2/2] " Ravishankar
1 sibling, 0 replies; 2+ messages in thread
From: Ravishankar @ 2011-08-10 10:32 UTC (permalink / raw)
To: gregkh, wfp5p; +Cc: devel, linux-kernel, Ravishankar, Ravishankar
From: Ravishankar <ravi.shankar@greenturtles.in>
This is a patch to the das1800.c file that fixes up a printk() warning found by the checkpatch.pl tool
Signed-off-by: Ravishankar <ravishankarkm32@gmail.com>
---
drivers/staging/comedi/drivers/das1800.c | 24 ++++++++++++------------
1 files changed, 12 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/comedi/drivers/das1800.c b/drivers/staging/comedi/drivers/das1800.c
index a6df30b..c4fcd17 100644
--- a/drivers/staging/comedi/drivers/das1800.c
+++ b/drivers/staging/comedi/drivers/das1800.c
@@ -631,8 +631,8 @@ static int das1800_attach(struct comedi_device *dev,
if (alloc_private(dev, sizeof(struct das1800_private)) < 0)
return -ENOMEM;
- printk("comedi%d: %s: io 0x%lx", dev->minor, driver_das1800.driver_name,
- iobase);
+ printk(KERN_WARNING "comedi%d: %s: io 0x%lx",
+ dev->minor, driver_das1800.driver_name, iobase);
if (irq) {
printk(", irq %u", irq);
if (dma0) {
@@ -644,22 +644,22 @@ static int das1800_attach(struct comedi_device *dev,
printk("\n");
if (iobase == 0) {
- printk(" io base address required\n");
+ printk(KERN_CONT " io base address required\n");
return -EINVAL;
}
/* check if io addresses are available */
if (!request_region(iobase, DAS1800_SIZE, driver_das1800.driver_name)) {
- printk
- (" I/O port conflict: failed to allocate ports 0x%lx to 0x%lx\n",
- iobase, iobase + DAS1800_SIZE - 1);
+ printk(KERN_CONT " I/O port conflict:"
+ " failed to allocate ports 0x%lx to 0x%lx\n",
+ iobase, iobase + DAS1800_SIZE - 1);
return -EIO;
}
dev->iobase = iobase;
board = das1800_probe(dev);
if (board < 0) {
- printk(" unable to determine board type\n");
+ printk(KERN_CONT " unable to determine board type\n");
return -ENODEV;
}
@@ -671,9 +671,9 @@ static int das1800_attach(struct comedi_device *dev,
iobase2 = iobase + IOBASE2;
if (!request_region(iobase2, DAS1800_SIZE,
driver_das1800.driver_name)) {
- printk
- (" I/O port conflict: failed to allocate ports 0x%lx to 0x%lx\n",
- iobase2, iobase2 + DAS1800_SIZE - 1);
+ printk(KERN_CONT " I/O port conflict:"
+ " failed to allocate ports 0x%lx to 0x%lx\n",
+ iobase2, iobase2 + DAS1800_SIZE - 1);
return -EIO;
}
devpriv->iobase2 = iobase2;
@@ -683,7 +683,7 @@ static int das1800_attach(struct comedi_device *dev,
if (irq) {
if (request_irq(irq, das1800_interrupt, 0,
driver_das1800.driver_name, dev)) {
- printk(" unable to allocate irq %u\n", irq);
+ printk(KERN_CONT " unable to allocate irq %u\n", irq);
return -EINVAL;
}
}
@@ -712,7 +712,7 @@ static int das1800_attach(struct comedi_device *dev,
devpriv->irq_dma_bits |= 0x38;
break;
default:
- printk(" irq out of range\n");
+ printk(KERN_CONT " irq out of range\n");
return -EINVAL;
break;
}
--
1.6.5.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH 2/2] Staging: comedi: fix printk() issue in das1800.c
[not found] <[PATCH]Staging: comedi:fix printk() issue in das1800.c>
2011-08-10 10:32 ` [PATCH 1/2] Staging: comedi: fix printk() issue in das1800.c Ravishankar
@ 2011-08-10 10:33 ` Ravishankar
1 sibling, 0 replies; 2+ messages in thread
From: Ravishankar @ 2011-08-10 10:33 UTC (permalink / raw)
To: gregkh, wfp5p; +Cc: devel, linux-kernel, Ravishankar, Ravishankar
From: Ravishankar <ravi.shankar@greenturtles.in>
This is a patch to the das1800.c file that fixes up a printk() warning found by the checkpatch.pl tool
Signed-off-by: Ravishankar <ravishankarkm32@gmail.com>
---
drivers/staging/comedi/drivers/das1800.c | 13 +++++++------
1 files changed, 7 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/comedi/drivers/das1800.c b/drivers/staging/comedi/drivers/das1800.c
index c4fcd17..b6052a8 100644
--- a/drivers/staging/comedi/drivers/das1800.c
+++ b/drivers/staging/comedi/drivers/das1800.c
@@ -573,22 +573,23 @@ static int das1800_init_dma(struct comedi_device *dev, unsigned int dma0,
devpriv->dma_bits |= DMA_CH7_CH5;
break;
default:
- printk(" only supports dma channels 5 through 7\n"
- " Dual dma only allows the following combinations:\n"
- " dma 5,6 / 6,7 / or 7,5\n");
+ printk(KERN_WARNING " only supports dma channels 5 through 7\n"
+ " Dual dma only allows the following combinations:\n"
+ " dma 5,6 / 6,7 / or 7,5\n");
return -EINVAL;
break;
}
if (request_dma(dma0, driver_das1800.driver_name)) {
- printk(" failed to allocate dma channel %i\n", dma0);
+ printk(KERN_WARNING " failed to allocate dma channel %i\n",
+ dma0);
return -EINVAL;
}
devpriv->dma0 = dma0;
devpriv->dma_current = dma0;
if (dma1) {
if (request_dma(dma1, driver_das1800.driver_name)) {
- printk(" failed to allocate dma channel %i\n",
- dma1);
+ printk(KERN_WARNING " failed to allocate dma channel %i\n",
+ dma1);
return -EINVAL;
}
devpriv->dma1 = dma1;
--
1.6.5.2
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-08-10 10:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <[PATCH]Staging: comedi:fix printk() issue in das1800.c>
2011-08-10 10:32 ` [PATCH 1/2] Staging: comedi: fix printk() issue in das1800.c Ravishankar
2011-08-10 10:33 ` [PATCH 2/2] " Ravishankar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®