* [PATCH] drivers/char: don't use IS_ERR()
@ 2011-08-10 17:41 Thomas Meyer
0 siblings, 0 replies; only message in thread
From: Thomas Meyer @ 2011-08-10 17:41 UTC (permalink / raw)
To: Andrew Morton, Niranjana Vishwanathapura, Linux Kernel Mailing List
From: Thomas Meyer <thomas@m3y3r.de>
The various basic memory allocation functions don't return ERR_PTR
The semantic patch that makes this change is available
in scripts/coccinelle/null/eno.cocci.
More information about semantic patching is available at
http://coccinelle.lip6.fr/
Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
---
diff --git a/drivers/char/msm_smd_pkt.c b/drivers/char/msm_smd_pkt.c
index b6f8a65..ceece48 100644
--- a/drivers/char/msm_smd_pkt.c
+++ b/drivers/char/msm_smd_pkt.c
@@ -379,9 +379,8 @@ static int __init smd_pkt_init(void)
for (i = 0; i < NUM_SMD_PKT_PORTS; ++i) {
smd_pkt_devp[i] = kzalloc(sizeof(struct smd_pkt_dev),
GFP_KERNEL);
- if (IS_ERR(smd_pkt_devp[i])) {
- r = PTR_ERR(smd_pkt_devp[i]);
- pr_err("kmalloc() failed %d\n", r);
+ if (!smd_pkt_devp[i]) {
+ pr_err("kmalloc() failed\n");
goto clean_cdevs;
}
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2011-08-10 17:42 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-08-10 17:41 [PATCH] drivers/char: don't use IS_ERR() Thomas Meyer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®