* [PATCH] um: drivers/xterm.c: fix a file descriptor leak
@ 2011-08-12 0:24 Jonathan Neuschäfer
0 siblings, 0 replies; only message in thread
From: Jonathan Neuschäfer @ 2011-08-12 0:24 UTC (permalink / raw)
To: user-mode-linux-devel
Cc: Jeff Dike, Richard Weinberger, linux-kernel, Jonathan Neuschäfer
I could use out_close1, but that seems to be the code path to close the
fd returned by os_create_unix_socket, and using it to close the fd
returned by mkstemp might lead to some confusion, so I don't do it.
Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
---
arch/um/drivers/xterm.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/arch/um/drivers/xterm.c b/arch/um/drivers/xterm.c
index 8ac7146..2e1de57 100644
--- a/arch/um/drivers/xterm.c
+++ b/arch/um/drivers/xterm.c
@@ -123,6 +123,7 @@ static int xterm_open(int input, int output, int primary, void *d,
err = -errno;
printk(UM_KERN_ERR "xterm_open : unlink failed, errno = %d\n",
errno);
+ close(fd);
return err;
}
close(fd);
--
1.7.5.4
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2011-08-12 0:24 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-08-12 0:24 [PATCH] um: drivers/xterm.c: fix a file descriptor leak Jonathan Neuschäfer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®