mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Johan Hovold <jhovold@gmail.com>
To: Liam Girdwood <lrg@ti.com>,
	Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Liam Girdwood <lrg@slimlogic.co.uk>,
	Jorge Eduardo Candelaria <jedu@slimlogic.co.uk>,
	Samuel Ortiz <sameo@linux.intel.com>,
	linux-kernel@vger.kernel.org, Johan Hovold <jhovold@gmail.com>,
	stable@kernel.org
Subject: [PATCH 1/3] regulator: tps65910: fix device initialisation
Date: Mon, 15 Aug 2011 12:45:25 +0200	[thread overview]
Message-ID: <1313405127-2724-1-git-send-email-jhovold@gmail.com> (raw)

Fix regression introduced by commit
a320e3c3d6351814afa5182159df88d2637e0f6f (regulator: tps65911: Add new
chip version) which broke probe for all devices:

	"Invalid tps chip version"

Cc: stable@kernel.org
Signed-off-by: Johan Hovold <jhovold@gmail.com>
---
 drivers/regulator/tps65910-regulator.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/regulator/tps65910-regulator.c b/drivers/regulator/tps65910-regulator.c
index 55dd4e6..bc5ed25 100644
--- a/drivers/regulator/tps65910-regulator.c
+++ b/drivers/regulator/tps65910-regulator.c
@@ -898,9 +898,11 @@ static __devinit int tps65910_probe(struct platform_device *pdev)
 	case TPS65910:
 		pmic->get_ctrl_reg = &tps65910_get_ctrl_register;
 		info = tps65910_regs;
+		break;
 	case TPS65911:
 		pmic->get_ctrl_reg = &tps65911_get_ctrl_register;
 		info = tps65911_regs;
+		break;
 	default:
 		pr_err("Invalid tps chip version\n");
 		return -ENODEV;
-- 
1.7.6


             reply	other threads:[~2011-08-15 10:45 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-15 10:45 Johan Hovold [this message]
2011-08-15 10:45 ` [PATCH 2/3] regulator: tps65910: fix list_voltage for VDD1 and VDD2 Johan Hovold
2011-08-15 13:09   ` Mark Brown
2011-08-15 14:29     ` Johan Hovold
2011-08-15 14:49       ` Mark Brown
2011-08-15 15:12         ` Johan Hovold
2011-08-15 15:39           ` Mark Brown
2011-08-15 10:45 ` [PATCH 3/3] regulator: tps65910: verify dcdc regulator ids Johan Hovold
2011-08-15 13:10   ` Mark Brown
2011-08-30 16:07   ` [PATCH 3/3 v2] " Johan Hovold
2011-08-30 16:07     ` Mark Brown
2011-08-31 13:26     ` Liam Girdwood
2011-08-15 13:08 ` [PATCH 1/3] regulator: tps65910: fix device initialisation Mark Brown
2011-08-28 16:32 ` Liam Girdwood
2011-08-30 16:05   ` Johan Hovold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1313405127-2724-1-git-send-email-jhovold@gmail.com \
    --to=jhovold@gmail.com \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=jedu@slimlogic.co.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lrg@slimlogic.co.uk \
    --cc=lrg@ti.com \
    --cc=sameo@linux.intel.com \
    --cc=stable@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome