From: Johan Hovold <jhovold@gmail.com>
To: Liam Girdwood <lrg@ti.com>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>,
Jorge Eduardo Candelaria <jedu@slimlogic.co.uk>,
Samuel Ortiz <sameo@linux.intel.com>,
linux-kernel@vger.kernel.org, Johan Hovold <jhovold@gmail.com>
Subject: [PATCH 3/3 v2] regulator: tps65910: verify dcdc regulator ids
Date: Tue, 30 Aug 2011 18:07:06 +0200 [thread overview]
Message-ID: <1314720426-23007-1-git-send-email-jhovold@gmail.com> (raw)
In-Reply-To: <1313405127-2724-3-git-send-email-jhovold@gmail.com>
Add default case to switches in dcdc voltage functions.
Signed-off-by: Johan Hovold <jhovold@gmail.com>
---
drivers/regulator/tps65910-regulator.c | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/drivers/regulator/tps65910-regulator.c b/drivers/regulator/tps65910-regulator.c
index 66d2d60..633ecd4 100644
--- a/drivers/regulator/tps65910-regulator.c
+++ b/drivers/regulator/tps65910-regulator.c
@@ -534,6 +534,8 @@ static int tps65910_get_voltage_dcdc(struct regulator_dev *dev)
srvsel &= VDDCTRL_SR_SEL_MASK;
vselmax = 64;
break;
+ default:
+ return -EINVAL;
}
/* multiplier 0 == 1 but 2,3 normal */
@@ -688,6 +690,9 @@ static int tps65910_set_voltage_dcdc(struct regulator_dev *dev,
case TPS65911_REG_VDDCTRL:
vsel = selector;
tps65910_reg_write(pmic, TPS65911_VDDCTRL_OP, vsel);
+ break;
+ default:
+ return -EINVAL;
}
return 0;
--
1.7.6
next prev parent reply other threads:[~2011-08-30 16:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-15 10:45 [PATCH 1/3] regulator: tps65910: fix device initialisation Johan Hovold
2011-08-15 10:45 ` [PATCH 2/3] regulator: tps65910: fix list_voltage for VDD1 and VDD2 Johan Hovold
2011-08-15 13:09 ` Mark Brown
2011-08-15 14:29 ` Johan Hovold
2011-08-15 14:49 ` Mark Brown
2011-08-15 15:12 ` Johan Hovold
2011-08-15 15:39 ` Mark Brown
2011-08-15 10:45 ` [PATCH 3/3] regulator: tps65910: verify dcdc regulator ids Johan Hovold
2011-08-15 13:10 ` Mark Brown
2011-08-30 16:07 ` Johan Hovold [this message]
2011-08-30 16:07 ` [PATCH 3/3 v2] " Mark Brown
2011-08-31 13:26 ` Liam Girdwood
2011-08-15 13:08 ` [PATCH 1/3] regulator: tps65910: fix device initialisation Mark Brown
2011-08-28 16:32 ` Liam Girdwood
2011-08-30 16:05 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1314720426-23007-1-git-send-email-jhovold@gmail.com \
--to=jhovold@gmail.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=jedu@slimlogic.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome