From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: linux-kernel@vger.kernel.org
Cc: Bruce Allan <bruce.w.allan@intel.com>,
Joe Perches <joe@perches.com>,
Anish Kumar <anish198519851985@gmail.com>,
Andy Whitcroft <apw@canonical.com>,
Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Subject: [PATCH] checkpatch: do not test/warn of leading whitespace before signature tags
Date: Wed, 17 Aug 2011 23:48:32 -0700 [thread overview]
Message-ID: <1313650112-17287-1-git-send-email-jeffrey.t.kirsher@intel.com> (raw)
From: Bruce Allan <bruce.w.allan@intel.com>
Commit 2011247 introduced additional style checks for signature tags in
patches which is good. Unfortunately, now whenever patches are checked
by piping the output of 'git show' or 'stg show' through checkpatch it
warns not to use whitespace before all signature tags since these (and the
rest of the patch description) are indented. Remove this test/warning.
Signed-off-by: Bruce Allan <bruce.w.allan@intel.com>
Cc: Joe Perches <joe@perches.com>
Cc: Anish Kumar <anish198519851985@gmail.com>
Cc: Andy Whitcroft <apw@canonical.com>
Tested-by: Aaron Brown <aaron.f.brown@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
scripts/checkpatch.pl | 13 ++++---------
1 files changed, 4 insertions(+), 9 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 9d761c9..a2a205a 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -1539,17 +1539,12 @@ sub process {
}
# Check signature styles
- if ($line =~ /^(\s*)($signature_tags)(\s*)(.*)/) {
- my $space_before = $1;
- my $sign_off = $2;
- my $space_after = $3;
- my $email = $4;
+ if ($line =~ /^\s*($signature_tags)(\s*)(.*)/) {
+ my $sign_off = $1;
+ my $space_after = $2;
+ my $email = $3;
my $ucfirst_sign_off = ucfirst(lc($sign_off));
- if (defined $space_before && $space_before ne "") {
- WARN("BAD_SIGN_OFF",
- "Do not use whitespace before $ucfirst_sign_off\n" . $herecurr);
- }
if ($sign_off =~ /-by:$/i && $sign_off ne $ucfirst_sign_off) {
WARN("BAD_SIGN_OFF",
"'$ucfirst_sign_off' is the preferred signature form\n" . $herecurr);
--
1.7.6
next reply other threads:[~2011-08-18 6:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-18 6:48 Jeff Kirsher [this message]
2011-08-18 7:26 ` Joe Perches
2011-08-18 7:47 ` Jeff Kirsher
2011-08-18 7:59 ` Joe Perches
2011-08-18 8:07 ` Jeff Kirsher
2011-08-18 8:16 ` Joe Perches
2011-08-18 8:26 ` Jeff Kirsher
2011-08-18 8:31 ` Joe Perches
2011-08-18 8:43 ` Jeff Kirsher
2011-08-18 8:56 ` Joe Perches
2011-08-18 9:21 ` Jeff Kirsher
2011-08-18 8:16 ` Jeff Kirsher
2011-08-19 14:13 ` Michal Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1313650112-17287-1-git-send-email-jeffrey.t.kirsher@intel.com \
--to=jeffrey.t.kirsher@intel.com \
--cc=anish198519851985@gmail.com \
--cc=apw@canonical.com \
--cc=bruce.w.allan@intel.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®